[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #60 from Katrin Fischer --- (In reply to Mirjam Vantieghem from comment #59) > Thanks for your reply, Katrin. Someone has already done this: bug 30438. > I saw this only after I placed my comment ... Great :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #59 from Mirjam Vantieghem --- Thanks for your reply, Katrin. Someone has already done this: bug 30438. I saw this only after I placed my comment ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #58 from Katrin Fischer --- (In reply to Mirjam Vantieghem from comment #57) > (In reply to Jonathan Druart from comment #44) > > We would have certainly saved time, lines of code, readability and > > maintainability with only one table and correct filters. > > > > [un]select all links are missing, not considering blocker however. > > We are very happy with this enhancement! > It would be even greater if there would be "(un)select all" links. > Not sure if I have to file a new bug for this? Hi Mirjam, once a feature/bug has been published in a release, we always need a new bug for any fixes or further improvements. Please file one! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Mirjam Vantieghem changed: What|Removed |Added CC||mirjam.vantieg...@etf.edu --- Comment #57 from Mirjam Vantieghem --- (In reply to Jonathan Druart from comment #44) > We would have certainly saved time, lines of code, readability and > maintainability with only one table and correct filters. > > [un]select all links are missing, not considering blocker however. We are very happy with this enhancement! It would be even greater if there would be "(un)select all" links. Not sure if I have to file a new bug for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature Text to go in the|These patches split the |This new feature splits the release notes|view of the invoice search |view of the invoice search |results into opened and |results into opened and |closed tables. Each table |closed tables and adds the |has checkboxes and a button |ability to bulk close or |to bulk close or reopen |reopen invoices. |invoices. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #56 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #55 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #54 from Nick Clemens --- Created attachment 119290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119290&action=edit Bug 22773: (follow-up) Fix id clash and data element -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #116010|0 |1 is obsolete|| --- Comment #53 from Nick Clemens --- Created attachment 119289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119289&action=edit Bug 22773: Assign different id to checkboxes Otherwise clicking the label does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115426|0 |1 is obsolete|| --- Comment #52 from Nick Clemens --- Created attachment 119288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119288&action=edit Bug 22773: (follow-up) Ensure buttons only affect their related table Also cleans up a few rebase issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115423|0 |1 is obsolete|| --- Comment #49 from Nick Clemens --- Created attachment 119285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119285&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer Signed-off-by: Katrin Fischer Rebase add comma -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115422|0 |1 is obsolete|| --- Comment #48 from Nick Clemens --- Created attachment 119284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119284&action=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115425|0 |1 is obsolete|| --- Comment #51 from Nick Clemens --- Created attachment 119287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119287&action=edit Bug 22773: (QA follow-up) Fix missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115424|0 |1 is obsolete|| --- Comment #50 from Nick Clemens --- Created attachment 119286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119286&action=edit Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label Fixes the checkbox label by adding an id, so that when you click on "Show only subscriptons" the checkbox will be checked. Adds standard classes to the existing "Merge selected invoices" button to make things more consistent. Also added the fa-compress icon that we use in cataloguing on the merge records button. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115421|0 |1 is obsolete|| --- Comment #47 from Nick Clemens --- Created attachment 119283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119283&action=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #115420|0 |1 is obsolete|| --- Comment #46 from Nick Clemens --- Created attachment 119282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119282&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Bug 22773: The deprecated plugin is removed Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer Signed-off-by: Katrin Fischer Remove asset for removed js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #45 from Jonathan Druart --- Sorry, found a bug. Merge is broken, there are elements sharing the same id (in this case #merge). To recreate, have 2 open invoices, select them, click merge You get "You must select at least two invoices to merge."... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #44 from Jonathan Druart --- We would have certainly saved time, lines of code, readability and maintainability with only one table and correct filters. [un]select all links are missing, not considering blocker however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #43 from Jonathan Druart --- Created attachment 116010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116010&action=edit Bug 22773: Assign different id to checkboxes Otherwise clicking the label does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Text to go in the||These patches split the release notes||view of the invoice search ||results into opened and ||closed tables. Each table ||has checkboxes and a button ||to bulk close or reopen ||invoices. --- Comment #42 from Nick Clemens --- (In reply to Jonathan Druart from comment #34) > 1. Please squash to avoid dataTables.fnFilterAll.js to be tracked (we never > used it) Done > 2. Buttons are not aligned/styled correctly: https://snipboard.io/wyac78.jpg yarn build -the margin on merge button is removed in these patches and fixes alignment > 3. We should not send the checkboxes from the other tabs. Fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #41 from Nick Clemens --- Created attachment 115426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115426&action=edit Bug 22773: (follow-up) Ensure buttons only affect their related table Also cleans up a few rebase issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #40 from Nick Clemens --- Created attachment 115425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115425&action=edit Bug 22773: (QA follow-up) Fix missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #39 from Nick Clemens --- Created attachment 115424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115424&action=edit Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label Fixes the checkbox label by adding an id, so that when you click on "Show only subscriptons" the checkbox will be checked. Adds standard classes to the existing "Merge selected invoices" button to make things more consistent. Also added the fa-compress icon that we use in cataloguing on the merge records button. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #38 from Nick Clemens --- Created attachment 115423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115423&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #37 from Nick Clemens --- Created attachment 115422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115422&action=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #36 from Nick Clemens --- Created attachment 115421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115421&action=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Attachment #106538|0 |1 is obsolete|| Attachment #106539|0 |1 is obsolete|| Attachment #106540|0 |1 is obsolete|| Attachment #106541|0 |1 is obsolete|| Attachment #106542|0 |1 is obsolete|| Attachment #106543|0 |1 is obsolete|| Attachment #106544|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 115420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115420&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Bug 22773: The deprecated plugin is removed Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer Signed-off-by: Katrin Fischer Remove asset for removed js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #34 from Jonathan Druart --- 3 smalls things: 1. Please squash Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) and Bug 22773: The deprecated plugin is removed to avoid dataTables.fnFilterAll.js to be tracked (we never used it) 2. Buttons are not aligned/styled correctly: https://snipboard.io/wyac78.jpg 3. We should not send the checkboxes from the other tabs. To recreate: - Have 1+ closed and 1+ opened invoice - Make sure the closedate is != from today - Don't tick anything - Click "Please select at least one invoice." => You get the JS alert OK - Tick the closed invoices and click the "Close selected invoices" from the "Open invoices" tab => You don't get the JS alert KO => the closedate is not today KO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98733|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 106542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106542&action=edit Bug 22773: The deprecated plugin is removed Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #32 from Katrin Fischer --- Created attachment 106543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106543&action=edit Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label Fixes the checkbox label by adding an id, so that when you click on "Show only subscriptons" the checkbox will be checked. Adds standard classes to the existing "Merge selected invoices" button to make things more consistent. Also added the fa-compress icon that we use in cataloguing on the merge records button. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98731|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 106540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106540&action=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #33 from Katrin Fischer --- Created attachment 106544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106544&action=edit Bug 22773: (QA follow-up) Fix missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98732|0 |1 is obsolete|| --- Comment #30 from Katrin Fischer --- Created attachment 106541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106541&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98730|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 106539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106539&action=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Attachment #98729|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 106538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106538&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #26 from Katrin Fischer --- I've tested merging invoices from 2 different tabs and it worked nicely. I did 2 follow-ups for some cosmetics (the label on the subscription limit and the buttons). Ready to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Summary|Bulk Close invoices and |Bulk close invoices and |Filter invoice view |filter invoice view |(open/closed) |(open/closed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #25 from Jonathan Druart --- (In reply to Kelly McElligott from comment #19) > I am signing off on this bug. To comment on Jonathan's comments. > > > > 2. Click "Show only subscriptions" label does not select the checkbox. > Missing id. > > I created a subscription order and this worked as the other orders did. If > there are no subscriptions then it produces no results which will not let > you move on. The "missing label" thing means that when you click on the label of the checkbox, the checkbox does not check/uncheck. > 3. You can select subscriptions from the 2 tabs then click "Merge selected > invoices". It's expected but as the button is inside the tab (so 2 buttons) > it's not obvious. > > I am not sure what this means? I did merge two invoices and it worked > correctly. If anything the merge button is not as pronounced (no black > outline) The screen is: https://snipboard.io/yjkFzV.jpg The first question is: Are we suppose to merge open and close invoices? The "Merge selected invoices" button is inside the "open invoices" fieldset/block. However, if you select invoices from the "open invoices" and the "closed invoices", the merge button will work. IMO it's ergonomically wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96910|0 |1 is obsolete|| --- Comment #24 from ByWater Sandboxes --- Created attachment 98733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98733&action=edit Bug 22773: The deprecated plugin is removed Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96908|0 |1 is obsolete|| --- Comment #22 from ByWater Sandboxes --- Created attachment 98731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98731&action=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96909|0 |1 is obsolete|| --- Comment #23 from ByWater Sandboxes --- Created attachment 98732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98732&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96907|0 |1 is obsolete|| --- Comment #21 from ByWater Sandboxes --- Created attachment 98730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98730&action=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #96906|0 |1 is obsolete|| --- Comment #20 from ByWater Sandboxes --- Created attachment 98729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98729&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #19 from Kelly McElligott --- I am signing off on this bug. To comment on Jonathan's comments. 2. Click "Show only subscriptions" label does not select the checkbox. Missing id. I created a subscription order and this worked as the other orders did. If there are no subscriptions then it produces no results which will not let you move on. 3. You can select subscriptions from the 2 tabs then click "Merge selected invoices". It's expected but as the button is inside the tab (so 2 buttons) it's not obvious. I am not sure what this means? I did merge two invoices and it worked correctly. If anything the merge button is not as pronounced (no black outline) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #95290|0 |1 is obsolete|| --- Comment #18 from ByWater Sandboxes --- Created attachment 96910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96910&action=edit Bug 22773: The deprecated plugin is removed Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93448|0 |1 is obsolete|| --- Comment #15 from ByWater Sandboxes --- Created attachment 96907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96907&action=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93375|0 |1 is obsolete|| --- Comment #14 from ByWater Sandboxes --- Created attachment 96906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96906&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #94411|0 |1 is obsolete|| --- Comment #17 from ByWater Sandboxes --- Created attachment 96909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96909&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93660|0 |1 is obsolete|| --- Comment #16 from ByWater Sandboxes --- Created attachment 96908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96908&action=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #13 from Jonathan Druart --- It's not clear with 2 tabs. Sorry to insist but: 1. Do not select anything, click "close selected invoices" => You get a warning "nothing selected" Now tick an open invoice, and click "open selected invoices" => You do not get the warning 2. Click "Show only subscriptions" label does not select the checkbox. Missing id. 3. You can select subscriptions from the 2 tabs then click "Merge selected invoices". It's expected but as the button is inside the tab (so 2 buttons) it's not obvious. Not blocker as other QAers agreed with the tab, but insufficient for me to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #12 from Devinim --- Created attachment 95290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95290&action=edit Bug 22773: The deprecated plugin is removed We used the deprecated plugin (fnFilterAll) to benefit "Show only subscriptions" checkbox property. In this new patch we removed fnFilterAll plugin and we put "Show only subscriptions" checkbox in each tab to be able to show checked subscriptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #11 from Martin Renvoize --- I don't mind whether we use tabs or a single table and filter.. there's precedence for both. I really don't like the idea of introducing a new dependency that is already officially deprecated, so if there's any way to work around that then I'd be onboard with it. Hope that helps guide this.. it's a nice feature and would be good to get moving again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #10 from Katrin Fischer --- Hi all, as there are some concerns about the datatables plugin used, could it be an option to see how it was solved for the subscription (separate tabs for active and closed subscriptions) and if this could be a way to avoid the plugin? If it turns out that we can't do without the plugin for now, we could still maybe add it with a FIXME. Would that be agreeable? Then this leaves updating the number displayed on the bug (comment#8). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > 1. Not sure the tabs are the best choice here. We could have had 2 links to > filter by open/close invoices. It would have made the code easier :) > Not blocker. > > 2. Also not sure why we need this plugin. Cannot we retrieve the instances > of DataTable and filter them individually? > > 3. Should not we update the number of invoices displayed in each tab? > "Open invoices (X)" About 1) - we have something very similar for the closed and open subscriptions. Both are searched, but displayed in different tabs, so the pattern already exists. Not sure how it works, but maybe worth taking a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- 1. Not sure the tabs are the best choice here. We could have had 2 links to filter by open/close invoices. It would have made the code easier :) Not blocker. 2. Also not sure why we need this plugin. Cannot we retrieve the instances of DataTable and filter them individually? 3. Should not we update the number of invoices displayed in each tab? "Open invoices (X)" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #7 from Devinim --- Created attachment 94411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94411&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #6 from Owen Leonard ---
(In reply to Katrin Fischer from comment #3)
> - The buttons don't align - we are missing: margin: .5em 0 0; on the second
> button.
Actually the right fix would be to remove the lin in staff-global.scss for
"#merge" (currently line 3488).
> They should also be using: btn btn-default classes instead of submit.
This still needs to be fixed.
> - The alignment on the 'closed inovices' table seems a bit off. It's much
> smaller than my other table in testing and aligns 'center'.
I suggest adding "autoWidth: false" to the DataTable configuration.
By the way, I mentioned in conversation with Katrin on IRC that the
dataTables.fnFilterAll.js should be unnecessary. The source of the plugin
itself says it is deprecated:
" * DataTables 1.10+ provides this ability through its new API, which is able
to
* to control multiple tables at a time.
* `$('.dataTable').DataTable().search( ... )` for example will apply the same
* filter to all tables on the page. The new API should be used in preference
* to this older method if at all possible."
However I wasn't able to get this method to work on both tables, so it appears
the plugin is required for now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #5 from Devinim --- Created attachment 93660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93660&action=edit Bug 22773: Message appearing if any invoice selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #4 from Katrin Fischer --- Created attachment 93448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93448&action=edit Bug 22773: (follow-up) Fix capitalization -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What|Removed |Added Keywords||rel_19_11_candidate CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- This works really well, but can please do a minor follow-up? - Capitalization on the tab names and the new button is wrong: only the first word should begin with a capital letter (attaching a follow-up for this) - The buttons don't align - we are missing: margin: .5em 0 0; on the second button. They should also be using: btn btn-default classes instead of submit. - The alignment on the 'closed inovices' table seems a bit off. It's much smaller than my other table in testing and aligns 'center'. The data is almost indentical, so I think it's not that. - It would be nice if there is a message when you don't check anything and click on the button (we do that in other places, like when selecting records for merging). (not blocker) Please keep in touch - labelling this as 19.11 candidate for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What|Removed |Added Attachment #93357|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 93375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93375&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #1 from Devinim --- Created attachment 93357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93357&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Test plan: 1)Verify that close tab occurse for closed invoices. 2)Try to select bulk invoices in open invoices tab and press button "Close selected invoices". Verify that your selected invoices moved to close invoices tab. 3)Try to select bulk invoices in close invoices tab and press button "Reopen selected invoices". Verify that your selected invoices moved to open invoices tab. 4)Check also when you check on "Show only subscriptions" checkbox you may see subscribed invoices in all tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Joy Nelson changed: What|Removed |Added Assignee|kyle.m.h...@gmail.com |kohadevi...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Joy Nelson changed: What|Removed |Added Summary|Bulk Close invoices |Bulk Close invoices and ||Filter invoice view ||(open/closed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
