[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #200 from Lucas Gass --- new feature will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #199 from Andrew Isherwood --- Thanks for that fix Jonathan! I actually had 4 parameters when I tested the upgrade, then just prior to committing I removed the last one thinking its absence would infer undef, I didn't realise last_insert_id expected 4. Sorry, silly mistake! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #198 from Jonathan Druart --- (In reply to Didier Gautheron from comment #197) > Update datanase isn't working for me > > DBI last_insert_id: invalid number of arguments: got handle + 3, expected > handle + between 4 and 5 > Usage: $h->last_insert_id($catalog, $schema, $table_name, $field_name [, > \%attr ]) at ./installer/data/mysql/updatedatabase.pl line 23326. I pushed a fix more than 1h ago: commit dcc1b96ea9cba850b1d5cfb84a171685b1b2a5ad Bug 22818: Fix the last_insert_id call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Didier Gautheron changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #197 from Didier Gautheron --- Update datanase isn't working for me DBI last_insert_id: invalid number of arguments: got handle + 3, expected handle + between 4 and 5 Usage: $h->last_insert_id($catalog, $schema, $table_name, $field_name [, \%attr ]) at ./installer/data/mysql/updatedatabase.pl line 23326. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #195 from Jonathan Druart --- Created attachment 113584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113584=edit Bug 22818: Fix the last_insert_id call DBI last_insert_id: invalid number of arguments: got handle + 3, expected handle + between 4 and 5 Usage: $h->last_insert_id($catalog, $schema, $table_name, $field_name [, \%attr ]) at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23326. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #196 from Jonathan Druart --- (In reply to Jonathan Druart from comment #194) > Same, I can't recreate anymore, weird! Will see later if it popups. > > Last patch pushed to master. Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #194 from Jonathan Druart --- Same, I can't recreate anymore, weird! Will see later if it popups. Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #193 from Andrew Isherwood --- Arghhh, I missed that you'd run 3 lots of tests there. Anyway, I just tried that, and still can't replicate it: root@kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t t/db_dependent/Illrequests.t t/db_dependent/Circulation.t ok t/db_dependent/Circulation/issue.t .. ok t/db_dependent/Illrequests.t ok All tests successful. Files=3, Tests=112, 84 wallclock secs ( 0.19 usr 0.03 sys + 61.96 cusr 10.98 csys = 73.16 CPU) Result: PASS root@kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t t/db_dependent/Illrequests.t t/db_dependent/Circulation.t ok t/db_dependent/Circulation/issue.t .. ok t/db_dependent/Illrequests.t ok All tests successful. Files=3, Tests=112, 83 wallclock secs ( 0.19 usr 0.02 sys + 61.94 cusr 10.65 csys = 72.80 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #192 from Jonathan Druart --- (In reply to Andrew Isherwood from comment #191) > (In reply to Jonathan Druart from comment #188) > > 3. t/db_dependent/Illrequests.t is passing but, only when run once: > > I can't replicate this: Did you try $prove t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #191 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #188)
Hi Jonathan
> 1. Fix the checkbox wording
Done
> 2. $dbh->{mysql_insertid}; in the upgrade process should be replaced. It's a
> MySQLism
Good point, done
> 3. t/db_dependent/Illrequests.t is passing but, only when run once:
I can't replicate this:
root@kohadevbox:koha(master)$ prove t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. ok
All tests successful.
Files=1, Tests=13, 19 wallclock secs ( 0.08 usr 0.01 sys + 12.17 cusr 3.31
csys = 15.57 CPU)
Result: PASS
root@kohadevbox:koha(master)$ prove t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. ok
All tests successful.
Files=1, Tests=13, 19 wallclock secs ( 0.06 usr 0.01 sys + 12.25 cusr 2.83
csys = 15.15 CPU)
Result: PASS
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #190 from Andrew Isherwood --- Created attachment 113549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113549=edit Bug 22818: (QA follow-up) Respond to feedback This commit addresses the requests from Jonathan in comment #188 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart changed: What|Removed |Added Attachment #113479|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #189 from Jonathan Druart --- Created attachment 113522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113522=edit Bug 22818: Fix TestBuilder.t t/db_dependent/TestBuilder.t .. 12/13 # Failed test 'build_object() tests' # at t/db_dependent/TestBuilder.t line 429. Can't locate object method "_new_from_dbic" via package "Koha::MessageAttribute" (perhaps you forgot to load "Koha::MessageAttribute"?) at /kohadevbox/koha/Koha/Objects.pm line 98. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Jonathan Druart changed:
What|Removed |Added
Keywords|release-notes-needed|additional_work_needed
--- Comment #188 from Jonathan Druart
---
Pushed but more work needed:
1. Fix the checkbox wording
2. $dbh->{mysql_insertid}; in the upgrade process should be replaced. It's a
MySQLism
3. t/db_dependent/Illrequests.t is passing but, only when run once:
$ prove t/db_dependent/Illrequests.t
OK
$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t
t/db_dependent/Illrequests.t
t/db_dependent/Circulation.t ... ok
t/db_dependent/Circulation/issue.t . ok
t/db_dependent/Illrequests.t ... 9/13
# Failed test 'Item creation fails on bad parameters'
# at t/db_dependent/Illrequests.t line 1008.
# found warning: DBD::mysql::st execute failed: Cannot add or update a
child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT
`items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`)
ON UPDATE CASCADE) [for Statement "INSERT INTO `items` ( `barcode`,
`biblioitemnumber`, `biblionumber`, `damaged_on`, `dateaccessioned`,
`datelastborrowed`, `datelastseen`, `holdingbranch`, `homebranch`,
`itemlost_on`, `itype`, `location`, `onloan`, `permanent_location`,
`replacementpricedate`, `timestamp`, `withdrawn_on`) VALUES ( ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with ParamValues:
0='ILL-26', 1=493, 2=497, 3=undef, 4='2020-11-11T15:06:34', 5=undef,
6='2020-11-11T15:06:34', 7='---', 8='---', 9=undef, 10='AfCJ5loFV', 11='---',
12=undef, 13='---', 14='2020-11-11T15:06:34', 15=undef] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
# found warning: DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or
update a child row: a foreign key constraint fails (`koha_kohadev`.`items`,
CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches`
(`branchcode`) ON UPDATE CASCADE) at /kohadevbox/koha/Koha/Object.pm line 169
# expected to find warning: (?^u:DBD::mysql::st execute failed: Cannot add
or update a child row: a foreign key constraint fails)
Feel free to open a separate bug report if it's not directly related to this
change.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #187 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #186 from Katrin Fischer --- > > > > Ah! Suggestions: We change the wording on the log viewer to read: "ILL > > notice sent to patron" and create a new bug report for widening the support > > of this? > > I understood the same. Do we agree the notices codes could refer to ILL more > explicitly as well? No! Sorry, that was my fault. They all include ILL in their codes already nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #185 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #184) > > We prefer "library" over "branch" > > https://wiki.koha-community.org/wiki/Terminology > > > > > > 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it > > > > explicit on the interface to not cause confusion? > > > > > > Sorry, I don't understand, make it explicit where in the interface? It's > > > listed, and can be selected, along with all the other log actions in the > > > "Browse the system logs" page. Is this where you are talking about? > > > > On the log viewer, there is a checkbox "Send a notice to a patron" with a > > code "PATRON_NOTICE". Which implies you will see all the notices sent. But > > actually we only support 2 notices, the ones you have created. > > I think this should cover all notices and be moved to a separate bug report. > > Or we improve the wording... > > Ah! Suggestions: We change the wording on the log viewer to read: "ILL > notice sent to patron" and create a new bug report for widening the support > of this? I understood the same. Do we agree the notices codes could refer to ILL more explicitly as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #184 from Katrin Fischer --- > We prefer "library" over "branch" > https://wiki.koha-community.org/wiki/Terminology > > > > 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it > > > explicit on the interface to not cause confusion? > > > > Sorry, I don't understand, make it explicit where in the interface? It's > > listed, and can be selected, along with all the other log actions in the > > "Browse the system logs" page. Is this where you are talking about? > > On the log viewer, there is a checkbox "Send a notice to a patron" with a > code "PATRON_NOTICE". Which implies you will see all the notices sent. But > actually we only support 2 notices, the ones you have created. > I think this should cover all notices and be moved to a separate bug report. > Or we improve the wording... Ah! Suggestions: We change the wording on the log viewer to read: "ILL notice sent to patron" and create a new bug report for widening the support of this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #183 from Tomás Cohen Arazi --- Hi, I suggest the new column for branches is called 'ill_email', and please add it to the api/v1/definitions/library.json object definition. If you prefer to keep the current name for simplicity, please add a mapping in the to_api_mapping sub. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #182 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #180)
> (In reply to Jonathan Druart from comment #162)
> > Those changes are not expected:
> >
> > -my $library = Koha::Libraries->find($params->{current_branchcode})
> > +my $branch = Koha::Libraries->find($params->{current_branchcode})
>
> I'm afraid I don't understand. In this patch
> https://bugs.koha-community.org/bugzilla3/attachment.
> cgi?id=113409=diff I fixed a misnamed variable, from $library ->
> $branch, which is the change you've highlighted above. Why is this
> unexpected?
We prefer "library" over "branch"
https://wiki.koha-community.org/wiki/Terminology
> > 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it
> > explicit on the interface to not cause confusion?
>
> Sorry, I don't understand, make it explicit where in the interface? It's
> listed, and can be selected, along with all the other log actions in the
> "Browse the system logs" page. Is this where you are talking about?
On the log viewer, there is a checkbox "Send a notice to a patron" with a code
"PATRON_NOTICE". Which implies you will see all the notices sent. But actually
we only support 2 notices, the ones you have created.
I think this should cover all notices and be moved to a separate bug report.
Or we improve the wording...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #181 from Katrin Fischer ---
(In reply to Andrew Isherwood from comment #180)
> (In reply to Jonathan Druart from comment #162)
> > Those changes are not expected:
> >
> > -my $library = Koha::Libraries->find($params->{current_branchcode})
> > +my $branch = Koha::Libraries->find($params->{current_branchcode})
>
> I'm afraid I don't understand. In this patch
> https://bugs.koha-community.org/bugzilla3/attachment.
> cgi?id=113409=diff I fixed a misnamed variable, from $library ->
> $branch, which is the change you've highlighted above. Why is this
> unexpected?
>
> > 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it
> > explicit on the interface to not cause confusion?
>
> Sorry, I don't understand, make it explicit where in the interface? It's
> listed, and can be selected, along with all the other log actions in the
> "Browse the system logs" page. Is this where you are talking about?
I am not sure either, but wondering if it was meant to include ILL in the
notice code to make it more obvious what it is used for. I didn't consider that
in testing, as there is a new notice module for "Interlibrary loans" too for
grouping them.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #180 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #162)
> Those changes are not expected:
>
> -my $library = Koha::Libraries->find($params->{current_branchcode})
> +my $branch = Koha::Libraries->find($params->{current_branchcode})
I'm afraid I don't understand. In this patch
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113409=diff
I fixed a misnamed variable, from $library -> $branch, which is the change
you've highlighted above. Why is this unexpected?
> 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it
> explicit on the interface to not cause confusion?
Sorry, I don't understand, make it explicit where in the interface? It's
listed, and can be selected, along with all the other log actions in the
"Browse the system logs" page. Is this where you are talking about?
> 3.
> +use Koha::MessageAttributes;
> +use Koha::MessageAttribute;
>
> You only need to include the Koha::Object*s* class.
Good spot, thanks, now fixed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113411|0 |1 is obsolete|| --- Comment #176 from Andrew Isherwood --- Created attachment 113476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113476=edit Bug 22818: (QA follow-up) Add sample ILL notices to it-IT installer Run: prove xt/sample_notices.t de-DE are missing on purpose because of bug 24972. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113413|0 |1 is obsolete|| --- Comment #178 from Andrew Isherwood --- Created attachment 113478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113478=edit Bug 22818: (QA follow-up) Add hint to new library ILL email setting Copies the hints on the other email fields highlighting the existing global pref. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #179 from Andrew Isherwood --- Created attachment 113479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113479=edit Bug 22818: (follow-up) "use" correct class Following up on the feedback from Jonathan in comment #162, this commit removes the use of Koha::MessageAttribute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #175 from Andrew Isherwood --- Created attachment 113475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113475=edit Bug 22818: (follow-up) Respond to feedback This commit implements the feedback from Katrin in comment #103 -> comment #108: - Fixed rebase issue mentioned in comment #103 - Fixed ILL notice display mentioned in comment #106 - Fixed bug with metadata display, though not the issue that was mentioned in comment #107 - Fixed buttons display mentioned in comment #107, in addition to some more buttons suffering the same issue Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113412|0 |1 is obsolete|| --- Comment #177 from Andrew Isherwood --- Created attachment 113477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113477=edit Bug 22818: (QA follow-up) Add some punctuation and terminology fixes to pref descriptions Just branch => library and some ending punctuation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113409|0 |1 is obsolete|| Attachment #113410|0 |1 is obsolete|| --- Comment #174 from Andrew Isherwood --- Created attachment 113474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113474=edit Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113408|0 |1 is obsolete|| --- Comment #173 from Andrew Isherwood --- Created attachment 113473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113473=edit Bug 22818: (QA follow-up) Add mandatory data at install time This patch adds the data from the update script into the mandatory sql files such that it is also populated at install time. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113407|0 |1 is obsolete|| --- Comment #172 from Andrew Isherwood --- Created attachment 113472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113472=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113404|0 |1 is obsolete|| --- Comment #169 from Andrew Isherwood --- Created attachment 113469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113469=edit Bug 22818: (QA follow-up) Licence and POD fixes Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113406|0 |1 is obsolete|| --- Comment #171 from Andrew Isherwood --- Created attachment 113471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113471=edit Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113405|0 |1 is obsolete|| --- Comment #170 from Andrew Isherwood --- Created attachment 113470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113470=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113403|0 |1 is obsolete|| --- Comment #168 from Andrew Isherwood --- Created attachment 113468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113468=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113402|0 |1 is obsolete|| --- Comment #167 from Andrew Isherwood --- Created attachment 113467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113467=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113400|0 |1 is obsolete|| --- Comment #165 from Andrew Isherwood --- Created attachment 113465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113465=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113401|0 |1
is obsolete||
--- Comment #166 from Andrew Isherwood ---
Created attachment 113466
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113466=edit
Bug 22818: Add MessageAttribut{e,es}.pm
We need to be able to access individual message attributes in tests, so
adding accessors for them
Sponsored-by: PTFS Europe
Signed-off-by: Niamh Walker-Headon
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113399|0 |1 is obsolete|| --- Comment #164 from Andrew Isherwood --- Created attachment 113464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113464=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #113398|0 |1 is obsolete|| --- Comment #163 from Andrew Isherwood --- Created attachment 113463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113463=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #162 from Jonathan Druart
---
Only found minor things so far.
1.
Those changes are not expected:
-my $library = Koha::Libraries->find($params->{current_branchcode})
+my $branch = Koha::Libraries->find($params->{current_branchcode})
2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it
explicit on the interface to not cause confusion?
3.
+use Koha::MessageAttributes;
+use Koha::MessageAttribute;
You only need to include the Koha::Object*s* class.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111912|0 |1 is obsolete|| --- Comment #159 from Andrew Isherwood --- Created attachment 113412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113412=edit Bug 22818: (QA follow-up) Add some punctuation and terminology fixes to pref descriptions Just branch => library and some ending punctuation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111913|0 |1 is obsolete|| --- Comment #160 from Andrew Isherwood --- Created attachment 113413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113413=edit Bug 22818: (QA follow-up) Add hint to new library ILL email setting Copies the hints on the other email fields highlighting the existing global pref. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #161 from Andrew Isherwood --- Hi Jonathan I experienced the conflicts you did, but didn't have any problem with the second "Respond to feedback" patch: Applying: Bug 22818: (follow-up) Respond to feedback Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc M koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc Anyway, I've just attached a new set of patches with the conflicts resolved, try again and see how it goes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111911|0 |1 is obsolete|| --- Comment #158 from Andrew Isherwood --- Created attachment 113411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113411=edit Bug 22818: (QA follow-up) Add sample ILL notices to it-IT installer Run: prove xt/sample_notices.t de-DE are missing on purpose because of bug 24972. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111908|0 |1 is obsolete|| --- Comment #155 from Andrew Isherwood --- Created attachment 113408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113408=edit Bug 22818: (QA follow-up) Add mandatory data at install time This patch adds the data from the update script into the mandatory sql files such that it is also populated at install time. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111909|0 |1 is obsolete|| Attachment #111910|0 |1 is obsolete|| --- Comment #156 from Andrew Isherwood --- Created attachment 113409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113409=edit Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #157 from Andrew Isherwood --- Created attachment 113410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113410=edit Bug 22818: (follow-up) Respond to feedback This commit implements the feedback from Katrin in comment #103 -> comment #108: - Fixed rebase issue mentioned in comment #103 - Fixed ILL notice display mentioned in comment #106 - Fixed bug with metadata display, though not the issue that was mentioned in comment #107 - Fixed buttons display mentioned in comment #107, in addition to some more buttons suffering the same issue Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111904|0 |1 is obsolete|| --- Comment #151 from Andrew Isherwood --- Created attachment 113404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113404=edit Bug 22818: (QA follow-up) Licence and POD fixes Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111907|0 |1 is obsolete|| --- Comment #154 from Andrew Isherwood --- Created attachment 113407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113407=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111906|0 |1 is obsolete|| --- Comment #153 from Andrew Isherwood --- Created attachment 113406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113406=edit Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111905|0 |1 is obsolete|| --- Comment #152 from Andrew Isherwood --- Created attachment 113405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113405=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111903|0 |1 is obsolete|| --- Comment #150 from Andrew Isherwood --- Created attachment 113403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113403=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111897|0 |1 is obsolete|| --- Comment #145 from Andrew Isherwood --- Created attachment 113398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113398=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111901|0 |1
is obsolete||
--- Comment #148 from Andrew Isherwood ---
Created attachment 113401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113401=edit
Bug 22818: Add MessageAttribut{e,es}.pm
We need to be able to access individual message attributes in tests, so
adding accessors for them
Sponsored-by: PTFS Europe
Signed-off-by: Niamh Walker-Headon
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111902|0 |1 is obsolete|| --- Comment #149 from Andrew Isherwood --- Created attachment 113402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113402=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111900|0 |1 is obsolete|| --- Comment #147 from Andrew Isherwood --- Created attachment 113400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113400=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111899|0 |1 is obsolete|| --- Comment #146 from Andrew Isherwood --- Created attachment 113399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113399=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #144 from Jonathan Druart --- Andrew, I resolved a first conflict on sample_notices_message_transports.sql but I cannot apply the second "Bug 22818: (follow-up) Respond to feedback" patch error: sha1 information is lacking or useless (installer/data/mysql/en/mandatory/sample_notices.yml). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #143 from Andrew Isherwood --- Hi Katrin Thanks for the follow ups, they look great. Sorry for missing the Italian file! Thanks for all your hard work on this, much appreciated! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #142 from Katrin Fischer --- Thx for the quick work and great test plan, Andrew. I threw in 3 tiny follow-ups at the end - hope they are agreeable :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #140 from Katrin Fischer --- Created attachment 111912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111912=edit Bug 22818: (QA follow-up) Add some punctuation and terminology fixes to pref descriptions Just branch => library and some ending punctuation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #141 from Katrin Fischer --- Created attachment 111913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111913=edit Bug 22818: (QA follow-up) Add hint to new library ILL email setting Copies the hints on the other email fields highlighting the existing global pref. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #139 from Katrin Fischer --- Created attachment 111911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111911=edit Bug 22818: (QA follow-up) Add sample ILL notices to it-IT installer Run: prove xt/sample_notices.t de-DE are missing on purpose because of bug 24972. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111890|0 |1 is obsolete|| --- Comment #135 from Katrin Fischer --- Created attachment 111907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111907=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111889|0 |1 is obsolete|| --- Comment #134 from Katrin Fischer --- Created attachment 111906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111906=edit Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111892|0 |1 is obsolete|| Attachment #111893|0 |1 is obsolete|| --- Comment #137 from Katrin Fischer --- Created attachment 111909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111909=edit Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111891|0 |1 is obsolete|| --- Comment #136 from Katrin Fischer --- Created attachment 111908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111908=edit Bug 22818: (QA follow-up) Add mandatory data at install time This patch adds the data from the update script into the mandatory sql files such that it is also populated at install time. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #138 from Katrin Fischer --- Created attachment 111910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111910=edit Bug 22818: (follow-up) Respond to feedback This commit implements the feedback from Katrin in comment #103 -> comment #108: - Fixed rebase issue mentioned in comment #103 - Fixed ILL notice display mentioned in comment #106 - Fixed bug with metadata display, though not the issue that was mentioned in comment #107 - Fixed buttons display mentioned in comment #107, in addition to some more buttons suffering the same issue Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111888|0 |1 is obsolete|| --- Comment #133 from Katrin Fischer --- Created attachment 111905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111905=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111887|0 |1 is obsolete|| --- Comment #132 from Katrin Fischer --- Created attachment 111904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111904=edit Bug 22818: (QA follow-up) Licence and POD fixes Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111885|0 |1 is obsolete|| --- Comment #130 from Katrin Fischer --- Created attachment 111902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111902=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111886|0 |1 is obsolete|| --- Comment #131 from Katrin Fischer --- Created attachment 111903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111903=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111884|0 |1
is obsolete||
--- Comment #129 from Katrin Fischer ---
Created attachment 111901
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111901=edit
Bug 22818: Add MessageAttribut{e,es}.pm
We need to be able to access individual message attributes in tests, so
adding accessors for them
Sponsored-by: PTFS Europe
Signed-off-by: Niamh Walker-Headon
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111880|0 |1 is obsolete|| --- Comment #126 from Katrin Fischer --- Created attachment 111897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111897=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111881|0 |1 is obsolete|| --- Comment #127 from Katrin Fischer --- Created attachment 111899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111899=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Attachment #111883|0 |1 is obsolete|| --- Comment #128 from Katrin Fischer --- Created attachment 111900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111900=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #125 from Katrin Fischer --- Hi Andrew, 5) is fixed for me now. All others look good too. I am working on some tiny follow-ups. Ready soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #124 from Katrin Fischer --- Back here :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111848|0 |1 is obsolete|| --- Comment #121 from Andrew Isherwood --- Created attachment 111892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111892=edit Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #122 from Andrew Isherwood --- Created attachment 111893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111893=edit Bug 22818: (follow-up) Respond to feedback This commit implements the feedback from Katrin in comment #103 -> comment #108: - Fixed rebase issue mentioned in comment #103 - Fixed ILL notice display mentioned in comment #106 - Fixed bug with metadata display, though not the issue that was mentioned in comment #107 - Fixed buttons display mentioned in comment #107, in addition to some more buttons suffering the same issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #123 from Andrew Isherwood --- Hi Katrin - Thanks for that. I've now addressed everything you've mentioned apart from the metadata not appearing with just a title, this seemed to work fine for me. There *was* a bug with metadata display, which I've now fixed, but I don't think it would have caused what you were seeing. Try these latest set of patches and see if you still have the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111845|0 |1 is obsolete|| --- Comment #118 from Andrew Isherwood --- Created attachment 111889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111889=edit Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111843|0 |1 is obsolete|| --- Comment #116 from Andrew Isherwood --- Created attachment 111887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111887=edit Bug 22818: (QA follow-up) Licence and POD fixes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111847|0 |1 is obsolete|| --- Comment #120 from Andrew Isherwood --- Created attachment 111891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111891=edit Bug 22818: (QA follow-up) Add mandatory data at install time This patch adds the data from the update script into the mandatory sql files such that it is also populated at install time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111846|0 |1 is obsolete|| --- Comment #119 from Andrew Isherwood --- Created attachment 111890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111890=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111844|0 |1 is obsolete|| --- Comment #117 from Andrew Isherwood --- Created attachment 111888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111888=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111842|0 |1 is obsolete|| --- Comment #115 from Andrew Isherwood --- Created attachment 111886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111886=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111841|0 |1 is obsolete|| --- Comment #114 from Andrew Isherwood --- Created attachment 111885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111885=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111839|0 |1 is obsolete|| --- Comment #112 from Andrew Isherwood --- Created attachment 111883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111883=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111840|0 |1
is obsolete||
--- Comment #113 from Andrew Isherwood ---
Created attachment 111884
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111884=edit
Bug 22818: Add MessageAttribut{e,es}.pm
We need to be able to access individual message attributes in tests, so
adding accessors for them
Sponsored-by: PTFS Europe
Signed-off-by: Niamh Walker-Headon
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111837|0 |1 is obsolete|| --- Comment #110 from Andrew Isherwood --- Created attachment 111880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111880=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #111838|0 |1 is obsolete|| --- Comment #111 from Andrew Isherwood --- Created attachment 111881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111881=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #109 from Katrin Fischer --- (In reply to Katrin Fischer from comment #108) > Created attachment 111874 [details] > ILL view in OPAC - button For 6) Checked with Owen: Since it's a submit button I'd change "btn-default" to "btn-primary," but it should be considered a general bug that input:submit.btn-default has black text. So we should change it in this template, but I also filed bug 26706. I'd be open to fix it here, but we can also move it to a separate bug as it's not strictly related. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #108 from Katrin Fischer --- Created attachment 111874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111874=edit ILL view in OPAC - button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #107 from Katrin Fischer --- 5) Metadata missing from text to partners Not sure if this should be a separate bug: - Enter a new ILL request, using Freeform - Type: Book, Title: something random - Edit request - Place with partner libraries - The title information is not showing up - Edit metadata, add year - same issue. - Add author - now it works and the notice shows the information. Note: the metadata field appear unordered, maybe something for later refinement in the TT notice. 6) Buttons (Bootstrap 4 issue) In the OPAC the "Submit modifications" button has bad contrast being dark grey with black writing. I think this could be a separate bug and is surely an issue with the Bootstrap 4 update as we had some other button bugs already. Everything else looks good! Please provide fixes as follow-ups - that will help to get them tested easier. I think all points found are not too severe and hope we can get that over finish line this time! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #106 from Katrin Fischer --- Ok, still testing! But it gets a little too much for me to fix myself, so I'll need follow-ups for: 1) Email issue noted in comment#103 2) Messaging preferences: Hide ILL notices if ILLModule is turned off. As this is visible to patrons in the OPAC I think we should really have it and the current approach breaks the table labels. 3) Log viewer: There is a new log action PATRON_NOTICE for ILL, that needs to show up on the log viewer search interface as a new checkbox (easy one :) ) 4) Translated installers. You can leave out de-DE (because of bug 24972), but we will need the others fixed. There is a test to help with that: prove xt/sample_notices.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #105 from Katrin Fischer --- Sadly the ILLModule check on the system preference doesn't work the intended way. It only removes the labels, the ILL notices still show up as "Unknown". I think a slightly different approach is needed. Not sure I see how to fix that myself right now, so putting it here while I continue testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
