[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #12 from Nick Clemens --- Bug 14419 adds the size parameter to all facets. Expanded facet is removed so this one is no longer needed *** This bug has been marked as a duplicate of bug 14419 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Michal Denar changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #11 from Michal Denar --- Can anybody rebase on master? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #10 from Bouzid Fergani --- HI, The patch of tests is not apply correctly. Bug 22924 - Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets 90665 - Bug 22924: Make elasticsearch honour FacetMaxCount system preference 90903 - Bug 22924: Unit tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22924: Make elasticsearch honour FacetMaxCount system preference Applying: Bug 22924: Unit tests Using index info to reconstruct a base tree... M t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t error: Failed to merge in the changes. Patch failed at 0001 Bug 22924: Unit tests The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22924-Unit-tests-N6uhfY.patch Bouzid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14419 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #9 from Nick Clemens --- Created attachment 90903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90903&action=edit Bug 22924: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What|Removed |Added Attachment #90341|0 |1 is obsolete|| --- Comment #8 from Alex Arnaud --- Created attachment 90665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90665&action=edit Bug 22924: Make elasticsearch honour FacetMaxCount system preference We have a line in QueryBuilder to respect the preference if a facet is expanded, it seems we forgot to pass the option to the querybuilder however To test: 1 - Enable Elasticsearch 2 - Set FacetMaxCount to 20 3 - Search in ES for '*' or something with a lot of results 4 - Expand some facets, note you get no more than 10 for any facet 5 - Apply patch 6 - Search again 7 - Expand facets, note they now go up to 20 8 - Try with various values of FacetMaxCount Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com Attachment #90053|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- I propose an alternate patch - QueryBuilder should already respect the preference, as long as we pass an expanded facet It should have unit tests regardless of which patch we use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #6 from Nick Clemens --- Created attachment 90341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90341&action=edit Bug 22924: [alternate] Make elasticsearch honour FacetMaxCount system preference We have a line in QueryBuilder to respect the preference if a facet is expanded, it seems we forgot to pass the option to the querybuilder however To test: 1 - Enable Elasticsearch 2 - Set FacetMaxCount to 20 3 - Search in ES for '*' or something with a lot of results 4 - Expand some facets, note you get no more than 10 for any facet 5 - Apply patch 6 - Search again 7 - Expand facets, note they now go up to 20 8 - Try with various values of FacetMaxCount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #5 from Michal Denar --- Hi, in kohadevbox? Did you aplly restart_all after patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Bouzid Fergani changed: What|Removed |Added CC||bouzid.ferg...@inlibro.com --- Comment #4 from Bouzid Fergani --- Hi, I have problem when applying this patch. Without the patch, when i search "a", i have results but with this patch nothing. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Michal Denar changed: What|Removed |Added Attachment #89852|0 |1 is obsolete|| --- Comment #3 from Michal Denar --- Created attachment 90053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90053&action=edit Bug 22924: Elasticsearch, show more than 10 facets To test: Without the patch: - check if you have your SysPref SearchEngine with Elasticsearch as value, - put your SysPref FacetMaxCount at 15, - make the search "a" in the catalog, - in Refine your search click on show more for authors, - make sure there is no more than 10 facets dislpaying With the patch: - apply the patch, - make the same, - make sure there is exactly 15 facets for authors. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 e.betemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Fridolin SOMERS changed: What|Removed |Added Severity|enhancement |normal CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin SOMERS --- More a bug than enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 axel Amghar changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #1 from axel Amghar --- Created attachment 89852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89852&action=edit Bug 22924: Elasticsearch, show more than 10 facets To test: Without the patch: - check if you have your SysPref SearchEngine with Elasticsearch as value, - put your SysPref FacetMaxCount at 15, - make the search "a" in the catalog, - in Refine your search click on show more for authors, - make sure there is no more than 10 facets dislpaying With the patch: - apply the patch, - make the same, - make sure there is exactly 15 facets for authors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 axel Amghar changed: What|Removed |Added Blocks||22903 Depends on|22903 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 [Bug 22903] Elasticsearch, dynamic display when you refine your search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 axel Amghar changed: What|Removed |Added Depends on||22903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 [Bug 22903] Elasticsearch, dynamic display when you refine your search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 axel Amghar changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 axel Amghar changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |axel.amg...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/