[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #23 from Jessie Zairo --- Batch modifying the pickup location would be another good option to include in this tool. Often a patron will call and ask that all 10 holds be send to another location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|Needs Signoff |Failed QA --- Comment #22 from Séverine Queune --- Sorry Matthias, I fail this patch for it doesn't respect the availability of the item (tested with notforloan !=0, itype without holds allowed). I also agree with Kelly about the table displayed after the cancellation : biblio datas are missing, it could be useful to display them so it becomes possible to place an individual hold after cancelling (patrons can sometimes be hesitant...). Presence of the link "Show holds" makes me think it was the original purpose of this table, am I right ? Some things I wonder about : - when cancelling holds, don't know if a warning for an item with no hold for this patron could be useful or not - when cancelling the action on 'Confirm selection' page, maybe we could return to 'Batch holding' page instead of 'Circulation home' Several good points though ! : - warning on unknown barcode - warning when patron already has a hold on the item- good recalculation of priority if cancelled hold was not the last one - respect of the hold limitation set in circulation rules (tested total, daily and per record) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #21 from Kelly McElligott --- Created attachment 108630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108630=edit link to a blank record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #20 from Kelly McElligott --- Created attachment 108628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108628=edit cancelling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #19 from Kelly McElligott --- I was successful in adding a barcode file and entering barcodes in to the text box to add holds to a patron's account. When I attempted to cancel the holds, the holds did cancel, however after confirming the cancel, the screen that showed the Cancelled holds. In this matrix, the title and Item was blank, the holds column had clickable links that said "show holds". These links brought up a hold screen for a title called "No Title). The bib didn't exist. See screenshots: http://staff-holds.sb1.sandboxes.bywatersolutions.com/cgi-bin/koha/circ/batch_holding.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #18 from Matthias Meusburger --- Also done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Attachment #106091|0 |1 is obsolete|| Attachment #106598|0 |1 is obsolete|| Attachment #107408|0 |1 is obsolete|| Attachment #108498|0 |1 is obsolete|| --- Comment #17 from Matthias Meusburger --- Created attachment 108504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108504=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Circulation -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #16 from Jonathan Druart --- Nothing is signed off already, I'd suggest to squash everything :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #14 from Matthias Meusburger --- Created attachment 108498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108498=edit Bug 23258: (follow-up) QA fixes: perltidy the script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #15 from Matthias Meusburger --- Salut Joubu, it's done :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #13 from Jonathan Druart --- Salut Matts, please perltidy the script :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #12 from Matthias Meusburger --- Created attachment 107408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107408=edit Bug 23258: (follow-up) QA fixes This patch adds relevant informations to the confirmation and results pages: - Patron name (with link) - Pickup location - Biblio title and item barcode (with link) - Link to the holds for the title on the result screen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #11 from Matthias Meusburger --- Thank you for the feedback and improvements, Owen. You're absolutely right, the result screen lacks relevant information. I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard --- This looks like it's working pretty well but I'd like to see a couple of improvements to the information provided to the user during the process. Can we add title information to the lists of submitted barcodes? Both on the screen with the checkboxes and on the confirmation page after submission. I think it would also be good to show the patron and pickup branch information on these screens. The final result screen should provide links to both the bibliographic record detail page and the holds page for that title. At the very least the result screen needs to have more useful information. Right now it has something like: The following items have been placed on hold: itemnumber 816, reserve_id 168 The itemnumber and reserve_id numbers are not useful to the librarian. Not a QA problem but a suggestion: How hard would it be to offer the option of placing or cancelling title-level holds instead of item-level holds? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258
--- Comment #9 from Owen Leonard ---
Created attachment 106598
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106598=edit
Bug 23258: (follow-up) Batch holds template followup
This patch revises the batch holds template to bring it up to date with
current guidelines including corrected indentation, Bootstrap grid,
terminology fixes ("hold" instead of "reserve") and JavaScript in the
footer.
Also changed:
- Add specificity to page title and breadcrumbs
- Add "Select all" and "Clear all" links to confirmation page
- Add jQuery validation of the form, enforcing barcode and patron entry
- Swith from "Batch holding" to "Batch place and cancel holds."
- Made suggested change to avoid errors in the log:
my $op = $input->param('op') // '';
- Fixed some other QA tool errors
To test, apply the patch and test the process of placing and cancelling
holds in batches:
- By uploading a file of barcodes
- By submitting barcodes in the textarea
- Confirm that holds are placed and cancelled
At each step of the process confirm that everything looks good and
works properly.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258
didier changed:
What|Removed |Added
CC||didier.gautheron@biblibre.c
||om
--- Comment #8 from didier ---
Hi
should be
my $op = $input->param('op') // '';
remove an 'op is undefined' warning in plack.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Matthias Meusburger --- Thanks for the feedback Owen. The patch has been rebased and fixed to work again on master. All QA fails have been corrected, except for this one: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) ...which cannot be fixed until Bug 24663 is pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Attachment #106077|0 |1 is obsolete|| --- Comment #6 from Matthias Meusburger --- Created attachment 106091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106091=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Circulation -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Attachment #106055|0 |1 is obsolete|| --- Comment #5 from Matthias Meusburger --- Created attachment 106077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106077=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Attachment #91230|0 |1 is obsolete|| --- Comment #4 from Matthias Meusburger --- Created attachment 106055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106055=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #3 from Owen Leonard --- This needs some follow-up work to fix QA tool warnings too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I can't seem to get this to work... Every time I submit a set of barcodes it tells me none of them can be placed on hold. I can place an item-level hold for the same patron using the regular method, so I assume it's not a problem with my circulation rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #1 from Matthias Meusburger --- Created attachment 91230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91230=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
