[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #1 from Nick Clemens --- Created attachment 91539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91539&action=edit Bug 23320 - Removed unused close parameter in neworderempty To test: 1 - Add to basket 2 - Note the options on the page 3 - Add &close=1 to the url 4 - Note some inputs are disabled 5 - Save anyway, note it is a regular order 6 - Add another order to basket 7 - Save it 8 - Modify 9 - Add close to the url again 10 - Save changes 11 - No functional change 12 - Apply patch 13 - Note close parameter has no effect now 14 - Confirm you can place and confirm orders as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #2 from Maryse Simard --- Created attachment 91674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91674&action=edit Implement blocking errors for neworderbiblio and basket.pl To test: 1 - Hit neworderbiblio with a query and no vendor http://localhost:8081/cgi-bin/koha/acqui/neworderbiblio.pl?q=cat Or, add to basket from existing record with a search Refresh the page (url has no parameters) 2 - Get an internal server error 3 - Add bookseller http://localhost:8081/cgi-bin/koha/acqui/neworderbiblio.pl?q=cat&booksellerid=1 4 - Click 'Order' on a result 5 - Internal server error 6 - Apply patch 7 - Repeat 1-4, you get 'Vendor not found' or 'Basket not found' https://bugs.koha-community.org/show_bug.cgi?id=23319 Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Attachment #91674|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Comment on attachment 91674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91674 Implement blocking errors for neworderbiblio and basket.pl Oups... wrong bug number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Maryse Simard --- After applying the patch, the selects for the fund and the currency look weird. The options are outside of the select and the checkbox to "show inactive" is repeated for each option. I think it is due to some [% END %] tags removed at the wrong place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added Attachment #91539|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 93110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93110&action=edit Bug 23320 - Removed unused close parameter in neworderempty To test: 1 - Add to basket 2 - Note the options on the page 3 - Add &close=1 to the url 4 - Note some inputs are disabled 5 - Save anyway, note it is a regular order 6 - Add another order to basket 7 - Save it 8 - Modify 9 - Add close to the url again 10 - Save changes 11 - No functional change 12 - Apply patch 13 - Note close parameter has no effect now 14 - Confirm you can place and confirm orders as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #6 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93110|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #7 from sandbo...@biblibre.com --- Created attachment 93508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93508&action=edit Bug 23320 - Removed unused close parameter in neworderempty To test: 1 - Add to basket 2 - Note the options on the page 3 - Add &close=1 to the url 4 - Note some inputs are disabled 5 - Save anyway, note it is a regular order 6 - Add another order to basket 7 - Save it 8 - Modify 9 - Add close to the url again 10 - Save changes 11 - No functional change 12 - Apply patch 13 - Note close parameter has no effect now 14 - Confirm you can place and confirm orders as before Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- There is a QA script fail here, can you please check? FAIL acqui/neworderempty.pl FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #9 from Katrin Fischer --- Also please fix the commit message! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added Attachment #93508|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 93545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93545&action=edit Bug 23320: Removed unused close parameter in neworderempty To test: 1 - Add to basket 2 - Note the options on the page 3 - Add &close=1 to the url 4 - Note some inputs are disabled 5 - Save anyway, note it is a regular order 6 - Add another order to basket 7 - Save it 8 - Modify 9 - Add close to the url again 10 - Save changes 11 - No functional change 12 - Apply patch 13 - Note close parameter has no effect now 14 - Confirm you can place and confirm orders as before Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #11 from Nick Clemens --- Created attachment 93546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93546&action=edit Bug 23320: (follow-up) Remove unused budget_name variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
