[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable Version(s)|19.11.00|19.11.00,19.05.04 released in|| --- Comment #11 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Martin Renvoize changed: What|Removed |Added Blocks||23468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23468 [Bug 23468] C4::Koha::NormalizeISBN should be moved to Koha::Normalize::ISBN -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #92116|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 --- Comment #9 from Marcel de Rooy --- Created attachment 92255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92255&action=edit Bug 23324: (QA follow-up) Typo and remove unneeded use statement Two typos in POD typo for routine name. Remove "use Business::ISBN" from Normalize.pm. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Marcel de Rooy changed: What|Removed |Added Attachment #91557|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 92253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92253&action=edit Bug 23324: Add an ISBN normalization routine To test: 1 - Set SearchEngine to ElasticSearch 2 - Stage the sample file (import it if it doesn't already exist in your catalog and then stage again) 3 - Set matching rule to ISBN 4 - No matches found 5 - Apply patch 6 - Apply no matchign rule 7 - Change the ISBN matching rule to use ISBN normalizer 8 - Apply matching rule for ISBN 9 - It matches! Signed-off-by: Ron Houk Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 --- Comment #8 from Marcel de Rooy --- Created attachment 92254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92254&action=edit Bug 23324: (QA follow-up) Use existing NormalizeISBN function Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 --- Comment #6 from Nick Clemens --- (In reply to Marcel de Rooy from comment #4) > What about NormalizeISBN in C4/Koha ? I didn't know about that! I altered these patches to use it. I think eventually the whole routine should be moved here, but I elected to keep this smaller as it affects stable (using ES) and prevents matching imports on ISBN - I added a FIXME -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 --- Comment #5 from Nick Clemens --- Created attachment 92116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92116&action=edit Bug 23324:(QA follow-up) Use existing NormalizeISBN function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy --- What about NormalizeISBN in C4/Koha ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Nick Clemens changed: What|Removed |Added Attachment #91551|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 91557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91557&action=edit Bug 23324: Add an ISBN normalization routine To test: 1 - Set SearchEngine to ElasticSearch 2 - Stage the sample file (import it if it doesn't already exist in your catalog and then stage again) 3 - Set matching rule to ISBN 4 - No matches found 5 - Apply patch 6 - Apply no matchign rule 7 - Change the ISBN matching rule to use ISBN normalizer 8 - Apply matching rule for ISBN 9 - It matches! Signed-off-by: Ron Houk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Nick Clemens changed: What|Removed |Added Depends on||23322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 --- Comment #2 from Nick Clemens --- Created attachment 91551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91551&action=edit Bug 23324: Add an ISBN normalization routine To test: 1 - Set SearchEngine to ElasticSearch 2 - Stage the sample file (import it if it doesn't already exist in your catalog and then stage again) 3 - Set matching rule to ISBN 4 - No matches found 5 - Apply patch 6 - Apply no matchign rule 7 - Change the ISBN matching rule to use ISBN normalizer 8 - Apply matching rule for ISBN 9 - It matches! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 --- Comment #1 from Nick Clemens --- Created attachment 91550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91550&action=edit Sample import file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23324] Need an ISBN normalization routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
