[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added CC||andreas.jons...@kreablo.se --- Comment #16 from Martin Renvoize --- *** Bug 23586 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
Status|Needs Signoff |Failed QA
--- Comment #15 from Kyle M Hall ---
root@2620803d2f65:koha(bug23382-qa)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 43/45
# Failed test 'Hourly rental charge calculated correctly'
# at t/db_dependent/Circulation.t line 3357.
# got: '7.50'
# expected: '10.00'
# Looks like you failed 1 test of 16.
# Failed test 'Incremented fee tests'
# at t/db_dependent/Circulation.t line 3368.
# Failed test 'Item needs rentalcharge confirmation to be issued'
# at t/db_dependent/Circulation.t line 3419.
# Structures begin differing at:
# $got->{RENTALCHARGE} = '1.00'
# $expected->{RENTALCHARGE} = '1'
# Looks like you failed 1 test of 2.
t/db_dependent/Circulation.t .. 45/45
# Failed test 'CanBookBeIssued & RentalFeesCheckoutConfirmation'
# at t/db_dependent/Circulation.t line 3425.
# Looks like you failed 2 tests of 45.
t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/45 subtests
Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 512 Tests: 45 Failed: 2)
Failed tests: 44-45
Non-zero exit status: 2
Files=1, Tests=45, 23 wallclock secs ( 0.03 usr 0.03 sys + 16.31 cusr 3.22
csys = 19.59 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #14 from Martin Renvoize --- Pretty sure the last patch resolves the issue reported here.. but I've not added tests to cover that fix yet so that'll have to come in a followup. (CanBookBeIssued seems to be entirely untested with regards to these charges) The increased test coverage does still seem to highlight an issue with DateTime maths but I'm not entirely sure if it's a test suit issue or if it'll result in weird fees for end-users as yet. Either way.. some feedback as to whether this resolves the original issue reported would be great so setting to NSO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #13 from Martin Renvoize --- Created attachment 92276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92276&action=edit Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued It looks like over progressive rebases of bug 20912 a clause was lost within CanBookBeIssued such that a fatal error may be triggered if an item with no corresponding itemtype was passed into the routine. Additionally the we were passing a Koha::Library object to CalcDateDue rather than a branchcode which resulted in a different duedate being used in 'CanBookBeIssued' when compared to 'AddIssue'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92238|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 92275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92275&action=edit Bug 23382: Add hourly tests for Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92237|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 92274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92274&action=edit Bug 23382: Add tests for hourly calculations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92236|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 92273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92273&action=edit Bug 23382: Improve test coverage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #9 from Martin Renvoize --- OK, it's not that either... :( I have however found some annoying flaws in our DateTime maths which are highlighted by the hourly tests.. I have no idea how to resolve them.. In short.. according to DateTime: `DateTime->now()->delta_ms(DateTime->now()->add( hours => 4 ) = DateTime::Duration->new( hours => 3, minutes => 59, seconds => 15 );` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #8 from Martin Renvoize --- oooh.. RentalFeesCheckoutConfirmation plays into it.. I missed that.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #7 from Martin Renvoize --- Hmm.. Well, I've greatly increased the test coverage.. but I've not yet managed to replicate the issue :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92221|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 92236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92236&action=edit Bug 23382: Improve test coverage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #6 from Martin Renvoize --- Created attachment 92238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92238&action=edit Bug 23382: Add hourly tests for Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #9|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 92237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92237&action=edit Bug 23382: Add tests for hourly calculations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #2 from Martin Renvoize --- Created attachment 92221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92221&action=edit Bug 23382: Improve test coverage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #3 from Martin Renvoize --- Created attachment 9 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9&action=edit Bug 23382: Add tests for hourly calculations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Depends on||20912 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 [Bug 20912] Rental fees based on time period -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Hourly rental fees are not charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #1 from Nick Clemens --- I believe the issue is two calls to accumulate_rentalcharge() that do not pass current date and due date - so there is no time difference to calculate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
