[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #14 from Jonathan Druart --- Created attachment 94722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94722&action=edit Bug 23413: Fix tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #13 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Nick Clemens changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #12 from Nick Clemens --- Created attachment 94686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94686&action=edit Bug 23413: Remove wrong return -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #11 from Jonathan Druart --- Also, we should not need the following return statement: 336 return unless $transfer_rs->count; We need it for ->checkout for instance, because it could be undef. But we should not return undef for ->holds, otherwise it will explode on $items->holds->count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- Martin, the follow-ups are not pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Nick Clemens changed: What|Removed |Added Attachment #92543|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 92544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92544&action=edit Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #8 from Nick Clemens --- Created attachment 92543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92543&action=edit Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #7 from Nick Clemens --- Created attachment 92542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92542&action=edit Bug 23413: (follow-up) Rename variables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Fix terminology corrects POD, but vars are still incorrect : my $transfer_rs = $self->_result->reserves->search($params); Should be my $holds_rs ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #4 from Katrin Fischer --- Created attachment 92129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92129&action=edit Bug 23413: (QA follow-up) Fix terminology Changed the POD of the new method to use holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Katrin Fischer changed: What|Removed |Added Attachment #92123|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 92128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92128&action=edit Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Maryse Simard changed: What|Removed |Added Attachment #91912|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 92123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92123&action=edit Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #1 from Nick Clemens --- Created attachment 91912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91912&action=edit Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
