[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in||19.05.09 --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.04 released in|| Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #8 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #6 from Katrin Fischer --- Hi David, just a tiny thing - the subject line of the patch always needs to start with : - fixed it during my QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer changed: What|Removed |Added Attachment #98950|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #5 from Katrin Fischer --- Created attachment 99127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99127=edit Bug 23527: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard changed: What|Removed |Added Attachment #92516|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 98950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98950=edit Bug 23527 - BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |techservs...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #3 from David Kuhn --- Created attachment 92516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92516=edit Bug 23527 - BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 David Kuhn changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #2 from David Kuhn --- Sorry, I mean opac-results.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #1 from David Kuhn --- This also occurs in opac-search.tt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 David Kuhn changed: What|Removed |Added CC||techservs...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
