[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks||26398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 [Bug 26398] Credit type on creating a manual credit is not translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks||25478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 [Bug 25478] Inconsistent naming of account_credit_type for lost and returned items [19.11 Version] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Katrin Fischer changed: What|Removed |Added Blocks||25389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 [Bug 25389] Inconsistent naming of account_credit_type for lost and returned items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks|23894 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks||17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account credit types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Bug 23805 depends on bug 23049, which changed state. Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Jonathan Druart changed: What|Removed |Added Blocks||24177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 [Bug 24177] Internal Server error when clicking cash register (Report) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Text to go in the|This patchset moves the |This patchset moves the release notes|remaining accounttypes, all |remaining accounttypes, all |of which should be credits |of which should be credits |after bug 23049, into their |after bug 23049, into their |own table. |own table. | | |This serves as |This serves as |the foundation for |the foundation for |enhancing the accounts |enhancing the accounts |system and leads to clearer |system and leads to clearer |code and more consistent|code and more consistent |data via database-level |data via database-level |constraints. |constraints. | | |Note: Reports |**Reports |will need to be updated to |note**: Reports will need |look in the new |to be updated to look in |credit_type_code field for |the new credit_type_code |accountlines of type|field for accountlines of |'credit' and use the|type 'credit' and use the |updated coded values. |updated coded values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks|23354 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks||24080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23181 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #58 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #56) > I've plain removed the check constraints from both this bug and 23049 too.. > Clearly people are generally not interested in data integrity [..] Surely people are. Too bad that you had to remove it for now. But couldnt we add a check on the about: System information ? > and it's > causing too many headaches attempting to pretend MariaDB and MySQL are the > same. On the DBMS part, since a default mysql-server install now means MariaDB in Debian, we should imo try to keep the sql stuff in mysql folder running under MariaDB and MySQL as long as practically feasible. Making another sql folder like we did for PostgreSQL was no success. Removed in 2013. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #57 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #53) > As a final note, there has been a check constraint in Koha since 2012-09-12 > when one was added as part of bug 5911 +CREATE TABLE transport_cost ( + frombranch varchar(10) NOT NULL, + tobranch varchar(10) NOT NULL, + cost decimal(6,2) NOT NULL, + disable_transfer tinyint(1) NOT NULL DEFAULT 0, + CHECK ( frombranch <> tobranch ), -- a dud check, mysql does not support that + PRIMARY KEY (frombranch, tobranch), + CONSTRAINT transport_cost_ibfk_1 FOREIGN KEY (frombranch) REFERENCES branches (branchcode) ON DELETE CASCADE ON UPDATE CASCADE, + CONSTRAINT transport_cost_ibfk_2 FOREIGN KEY (tobranch) REFERENCES branches (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE +) ENGINE=InnoDB DEFAULT CHARSET=utf8; a dud check? Interestingly, MySQL 5.5, 5.7 allows you to define CHECK constraints, but with the note that they are parsed, but ignored by all storage engines. I am having the impression that this explained why I saw it and you did not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #56 from Martin Renvoize --- I've plain removed the check constraints from both this bug and 23049 too.. Clearly people are generally not interested in data integrity and it's causing too many headaches attempting to pretend MariaDB and MySQL are the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #55 from Katrin Fischer --- The update fails on the MariaDB version in my kohadevbox: Server version: 10.1.38-MariaDB-0+deb9u1 Debian 9.8 See discussion on IRC: http://irc.koha-community.org/koha/2019-11-01#i_2186242 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #54 from Julian Maurice --- (In reply to Martin Renvoize from comment #52) > Check constraints are not a mysqlism and have been in mariadb since 4 Jul > 2016, postgres since before 2001-08-15.. they're not be thing. > > I will remove the constraint if people are really that anti having > consistent data. It really is a "do no harm" feature, I don't see why > people are getting so sound up about it. The database update threw a > warning but carried on and didn't break anything.. you just ended up without > the constraint. > > If we bring this silly about supported systems we should be removing the > entire restful API in my mmm opinion as mojolicious is far less easily > packaged, faster moving and unstable. > > I've said my piece. Just to be clear, I am all for consistent data, but I'm also all for consistent behaviour. That's why I think Koha shouldn't use a database feature that is not supported by all database systems supported by Koha (btw, does the list of supported databases - with versions - exist somewhere ?). With a CHECK constraint, someone with MySQL 8.0.16+ will have different database constraints than someone with MySQL 5.7. So, possibly different behaviours, bugs that are hard to reproduce, ... And that, IMO, should be avoided if possible. That particular problem could be solved if we decide that Koha now requires at least MySQL 8.0.16 (which is 6 months old) or MariaDB 10.2 (first 10.2 stable version is more than 2 years old). But there's still the problem of the error message shown during updatedatabase.pl (because of different syntax) that need to be solved (maybe in a new bug ?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #53 from Martin Renvoize --- As a final note, there has been a check constraint in Koha since 2012-09-12 when one was added as part of bug 5911 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #52 from Martin Renvoize --- Check constraints are not a mysqlism and have been in mariadb since 4 Jul 2016, postgres since before 2001-08-15.. they're not be thing. I will remove the constraint if people are really that anti having consistent data. It really is a "do no harm" feature, I don't see why people are getting so sound up about it. The database update threw a warning but carried on and didn't break anything.. you just ended up without the constraint. If we bring this silly about supported systems we should be removing the entire restful API in my mmm opinion as mojolicious is far less easily packaged, faster moving and unstable. I've said my piece. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #51 from Katrin Fischer --- I am really unhappy about this tbh - we are introducing database specific things. Pretty new to the RDBMS too if I under understand Julian's comment on bug 23914 correctly and with different syntax already for the 2 RDBMS we support atm. We had agreed on not using MysqlIsms as a community and we should have discussed this... Is it really worth it? Do we need this check so urgently and can't solve this in another way? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94815|0 |1 is obsolete|| --- Comment #50 from Martin Renvoize --- Created attachment 94895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94895=edit Bug 23805: (RM follow-up) updatedatabase.pl mariadb support MySQL and MariaDB have different syntax when it comes to dropping a CHECK constraint. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #49 from Martin Renvoize --- (In reply to Julian Maurice from comment #45) > > Instead we can do: > 1. credit_type_code = NEW_CODE(accounttype) > 2. Drop accounttype > > This way, no need to drop the check constraint first (because accounttype is > not changed), and it is dropped automatically when the column is removed. I'm not sure that's true actually.. this is a table-level check constraint... I think auto drop is only supported at column level checks, though I may be wrong. I've uploaded an alternative patch that attempts to do as you suggest but don't have a simple way to test it's effectiveness myself :(. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #48 from Katrin Fischer --- (In reply to Jonathan Druart from comment #47) > (In reply to Martin Renvoize from comment #43) > > Created attachment 94815 [details] [review] [review] > > Bug 23805: (RM follow-up) updatedatabase.pl mariadb support > > > > MySQL and MariaDB have different syntax when it comes to dropping a > > CHECK constraint. > > > > Signed-off-by: Martin Renvoize > > That's what I would do, even if dirty. Maybe we should reverse the 2 > queries: first try the MariaDB syntax, to highlight that it's our first > choice. Have you seen the comments on bug 23914 about DBMS versions and support of check constraints? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #47 from Jonathan Druart --- (In reply to Martin Renvoize from comment #43) > Created attachment 94815 [details] [review] > Bug 23805: (RM follow-up) updatedatabase.pl mariadb support > > MySQL and MariaDB have different syntax when it comes to dropping a > CHECK constraint. > > Signed-off-by: Martin Renvoize That's what I would do, even if dirty. Maybe we should reverse the 2 queries: first try the MariaDB syntax, to highlight that it's our first choice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #46 from Martin Renvoize --- Created attachment 94832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94832=edit Bug 23805: (follow-up) [alternative] Re-order check constraint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #45 from Julian Maurice --- It looks like it doesn't work. I get the same error message, and I added a warn below `# MariaDB specific drop` and it is not displayed. DBI is not dying (RaiseError is set to 0 at the beginning of updatedatabase.pl) Maybe the problem could be avoided by changing the other queries. Currently the order is: 1. Drop check constraint 2. accounttype = NEW_CODE(accounttype) 3. credit_type_code = accounttype 4. Drop accounttype Instead we can do: 1. credit_type_code = NEW_CODE(accounttype) 2. Drop accounttype This way, no need to drop the check constraint first (because accounttype is not changed), and it is dropped automatically when the column is removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #44 from Martin Renvoize --- I tried a few solutions but this one seemed to be the most reliable.. any chance you could test this for me Julian? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #43 from Martin Renvoize --- Created attachment 94815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94815=edit Bug 23805: (RM follow-up) updatedatabase.pl mariadb support MySQL and MariaDB have different syntax when it comes to dropping a CHECK constraint. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #42 from Martin Renvoize --- Good spot Julian, thanks.. I'll look into it now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #41 from Julian Maurice --- I think there's still a problem with the DB update: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'CHECK `accountlines_check_type`' at line 1 [for Statement " ALTER TABLE accountlines DROP CHECK `accountlines_check_type` "] at installer/data/mysql/updatedatabase.pl line 20015. "DROP CHECK" seems to have been added in MySQL 8.0 and is not available in MariaDB https://mariadb.com/kb/en/library/alter-table/ https://dev.mysql.com/doc/refman/5.7/en/alter-table.html https://dev.mysql.com/doc/refman/8.0/en/alter-table.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #40 from Martin Renvoize --- DB update corrections pushed. Need to get into the habit of running tests using recent versions of mysql/mariadb as that would have caught this issue. I've submitted improvements to koha-testing-docker to facilitate this. Thanks for spotting this and raising it Marcel. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #39 from Martin Renvoize --- Created attachment 94801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94801=edit Bug 23805: (follow-up) Database update corrections Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #38 from Tomás Cohen Arazi --- All the tests passed when I tested, expect from the API ones for which I submitted a fix. I think doing it outside bugzilla (branch on github and pull request) might have leaded to confusion? The branch contained more than one bug/patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #37 from Marcel de Rooy --- Couldnt let go yet ;) [FAIL] t/db_dependent/Accounts.t | 50 ++--- [FAIL] t/db_dependent/Circulation.t | 18 +- [OK] t/db_dependent/ILSDI_Services.t| 1 - [FAIL] t/db_dependent/Koha/Account.t | 20 +- [FAIL] t/db_dependent/Koha/Account/Lines.t| 2 +- [FAIL] t/db_dependent/api/v1/patrons_accounts.t | 2 +- I installed a fresh database with optional data, and ran the tests.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #36 from Marcel de Rooy --- I will not reQA a pushed patch set, but am a bit disappointed to see these things in view of the time spent on report 23049. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #35 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #34) > `accounttype` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `credit_type_code` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `debit_type_code` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > Why does accounttype still exist ? > > kohastructure > - `accounttype` varchar(80) default NULL, > + `credit_type_code` varchar(80) default NULL, > but no dropping accounttype in the dbrev This should be an elementary check during QA imo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #34 from Marcel de Rooy --- `accounttype` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `credit_type_code` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `debit_type_code` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, Why does accounttype still exist ? kohastructure - `accounttype` varchar(80) default NULL, + `credit_type_code` varchar(80) default NULL, but no dropping accounttype in the dbrev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #33 from Marcel de Rooy --- ALTER TABLE table DROP CHECK constraint; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
--- Comment #32 from Marcel de Rooy ---
ALTER TABLE accountlines ADD CONSTRAINT `accountlines_check_type` CHECK
(accounttype IS NOT NULL OR debit_type_code IS NOT NULL)
# Dropping the check constraint in accountlines
ALTER TABLE
accountlines
ADD CONSTRAINT
`accountlines_check_type`
CHECK (credit_type_code IS NOT NULL OR debit_type_code IS NOT NULL)
[...]
# Adding a check constraints to accountlines
$dbh->do(
qq{
ALTER TABLE accountlines ADD CONSTRAINT `accountlines_check_type` CHECK
(accounttype IS NOT NULL OR credit_type_code IS NOT NULL)
}
);
=> Come on, ADD is not dropping a constraint !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #31 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #28) > All good. Tests coverage, and QA tools do great. Hmm. Bit fast? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #30 from Marcel de Rooy --- Upgrade to 19.06.00.043 done (Bug 23049 - Add account debit_types) DBD::mysql::db do failed: Duplicate CHECK constraint name 'accountlines_check_type' [for Statement " ALTER TABLE accountlines ADD CONSTRAINT `accountlines_check_type` CHECK (credit_type_code IS NOT NULL OR debit_type_code IS NOT NULL) "] at installer/data/mysql/updatedatabase.pl line 20015. DBD::mysql::db do failed: Duplicate CHECK constraint name 'accountlines_check_type' [for Statement " ALTER TABLE accountlines ADD CONSTRAINT `accountlines_check_type` CHECK (accounttype IS NOT NULL OR credit_type_code IS NOT NULL) "] at installer/data/mysql/updatedatabase.pl line 20081. Upgrade to 19.06.00.044 done (Bug 23049 - Add account credit_types) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks||23894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks||23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Text to go in the||This patchset moves the release notes||remaining accounttypes, all ||of which should be credits ||after bug 23049, into their ||own table. || ||This serves as ||the foundation for ||enhancing the accounts ||system and leads to clearer ||code and more consistent ||data via database-level ||constraints. || ||Note: Reports ||will need to be updated to ||look in the new ||credit_type_code field for ||accountlines of type ||'credit' and use the ||updated coded values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #29 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #28 from Tomás Cohen Arazi --- All good. Tests coverage, and QA tools do great. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #27 from Kyle M Hall --- Testing looks good! Unit tests all pass as well for me. QA script passes with flying colors. Signing off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #26 from Martin Renvoize --- I've moved this into a github branch (to keep the rebasing tidy): https://github.com/PTFS-Europe/koha/tree/bug_23805_credit Ready for signoff. Test plan: 1) Checkout branch 2) Run all accounts related tests (They should all pass) 3) Check the 'manual invoice' functionality still works as expected. 4) Check the 'cash register stats' report Signoff Tests t/db_dependent/Circulation.t t/db_dependent/ILSDI_Services.t t/db_dependent/Koha/Account.t t/db_dependent/Koha/Account/Lines.t t/db_dependent/api/v1/patrons_accounts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94178|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94176|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94177|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94175|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94174|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94172|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94173|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94171|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94170|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94166|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94169|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94167|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94168|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added URL||https://github.com/PTFS-Eur ||ope/koha/tree/bug_23805_cre ||dit Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #25 from Martin Renvoize --- Created attachment 94178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94178=edit Bug 23049: (follow-up) Handle unexpected types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94164|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 94177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94177=edit Bug 23805: Update mancredit to use the new credit types Test plan Ensure the manual credit page continues to work as it did before this patchset. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94163|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 94176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94176=edit Bug 23805: (follow-up) Lowercase credit type for UpdateStats -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94161|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 94174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94174=edit Bug 23805: Update 'W' to 'WRITEOFF' for consistency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94162|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 94175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94175=edit Bug 23805: Drop type lookup as it's now a foreign key -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94157|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 94170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94170=edit Bug 23805: Update 'C' to 'CREDIT' for consistency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94160|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 94173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94173=edit Bug 23805: Update 'Pay' to 'PAYMENT' for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94158|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 94171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94171=edit Bug 23805: Update 'FOR' to 'FORGIVEN' for consistency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94159|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 94172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94172=edit Bug 23805: Update 'lost_item_return' to 'LOST_RETURN' for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94156|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 94169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94169=edit Bug 23805: Update accounttype references in tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94153|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 94166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94166=edit Bug 23805: Add account_credit_types tables -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94154|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 94167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94167=edit Bug 23805: DBIC Classes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Attachment #94155|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 94168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94168=edit Bug 23805: Update references to accounttype to credit_type_code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added CC||josef.mora...@gmail.com, ||k...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #10 from Martin Renvoize --- Created attachment 94162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94162=edit Bug 23805: Drop type lookup as it's now a foreign key -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #9 from Martin Renvoize --- Created attachment 94161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94161=edit Bug 23805: Update 'W' to 'WRITEOFF' for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #8 from Martin Renvoize --- Created attachment 94160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94160=edit Bug 23805: Update 'Pay' to 'PAYMENT' for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #12 from Martin Renvoize --- Created attachment 94164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94164=edit Bug 23805: Update mancredit to use the new credit types Test plan Ensure the manual credit page continues to work as it did before this patchset. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #11 from Martin Renvoize --- Created attachment 94163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94163=edit Bug 23805: (follow-up) Lowercase credit type for UpdateStats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #5 from Martin Renvoize --- Created attachment 94157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94157=edit Bug 23805: Update 'C' to 'CREDIT' for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #7 from Martin Renvoize --- Created attachment 94159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94159=edit Bug 23805: Update 'lost_item_return' to 'LOST_RETURN' for consistency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #6 from Martin Renvoize --- Created attachment 94158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94158=edit Bug 23805: Update 'FOR' to 'FORGIVEN' for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #4 from Martin Renvoize --- Created attachment 94156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94156=edit Bug 23805: Update accounttype references in tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #3 from Martin Renvoize --- Created attachment 94155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94155=edit Bug 23805: Update references to accounttype to credit_type_code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #2 from Martin Renvoize --- Created attachment 94154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94154=edit Bug 23805: DBIC Classes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #1 from Martin Renvoize --- Created attachment 94153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94153=edit Bug 23805: Add account_credit_types tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Depends on||23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What|Removed |Added Blocks||17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
