[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Victor Grousset/tuxayo changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m, ||victor.grous...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com --- Comment #1 from Jonathan Druart --- This statement: my $charges = $patron->account->non_issues_charges; will return -15 on master and 0 on 19.05.X Tomas, Martin, what is the expected behavior? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #2 from Martin Renvoize --- (In reply to Jonathan Druart from comment #1) > This statement: > my $charges = $patron->account->non_issues_charges; > will return -15 on master and 0 on 19.05.X > > Tomas, Martin, what is the expected behavior? Well.. non_issuing_charges should only return debts, so I'd say master has developed a bug. (The query should include a `AND debit_type_code IS NOT NULL` I believe.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #3 from Martin Renvoize --- I think this actually exposes some wider questions regarding that routine.. see bug 23293 for example.. it doesn't use the non_issuing_charges method when it probably should (again, my bad :( ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #4 from Jonathan Druart --- Created attachment 95254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95254&action=edit Bug 23822: Fix deletion of patrons with credit There are bugs in both master and 19.05, but different. Anyway we should have this check to make sure a negative value will have the same behavior: trigger the confirmation message (instead of a blank page). If we want to reject the deletion of a patron with credit we should handle it on a separate bug report (behavior change) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org --- Comment #5 from Jonathan Druart --- I would suggest to push this patch into master even if this specific bug does not exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24007 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize changed: What|Removed |Added Blocks||24008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 [Bug 24008] No warning is produced when trying to delete a patron with credit (patron is not deleted) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
