[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #8 from Fridolin SOMERS --- (In reply to Pedro Amorim from comment #7) > Created attachment 96146 [details] [review] > Bug 24121 - Item types icons in intra search results are requesting icons > from opac images path if item-level_itypes syspref is set to biblio > > Please let me know if this looks good, Owen. Thank you. Not yet, commit message must start with : "Bug 24121: " And message is too long, I propose you remove "if item-level_itypes syspref is set to biblio" it is in description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Jonathan Druart --- *** Bug 24198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #7 from Pedro Amorim --- Created attachment 96146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96146&action=edit Bug 24121 - Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio Please let me know if this looks good, Owen. Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- Pedro this patch looks good and I'm ready so sign off on it, but it needs a good commit message. Please look at the guidelines here: https://wiki.koha-community.org/wiki/Commit_messages Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart changed: What|Removed |Added Depends on||14385 --- Comment #4 from Jonathan Druart --- Caused by commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff Version|19.05 |master CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |pjamori...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #3 from Pedro Amorim --- Edited original title of "Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio" to something more accurate. The original reason it was not showing for my installation is something specific (IP and port access - instead of url) but the fix still remains relevant, I believe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim changed: What|Removed |Added Summary|Item types icons not|Item types icons in intra |showing in intra search |search results are |results if |requesting icons from opac |item-level_itypes syspref |images path if |is set to biblio|item-level_itypes syspref ||is set to biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
