[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Katrin Fischer changed: What|Removed |Added Attachment #106847|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 106890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106890=edit Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #17 from Katrin Fischer --- I wondered if we should have a statement for changing the NULL to 0 on existing patrons, but it seems to automatically happen in my testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Lucas Gass changed: What|Removed |Added Attachment #106846|0 |1 is obsolete|| --- Comment #16 from Lucas Gass --- Created attachment 106847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106847=edit Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What|Removed |Added Attachment #97058|0 |1 is obsolete|| Attachment #97073|0 |1 is obsolete|| Attachment #105522|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 106846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106846=edit Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 David Cook changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #14 from David Cook --- Sorry, Nick, but can't apply the patch: error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor Patch failed at 0001 Bug 24379: Make login_attempts not nullable The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24379-Make-loginattempts-not-nullable-I8ewqG.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #13 from David Cook --- At a glance, these patches look good. They're a bit of a pain to test though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #12 from David Cook --- No change to login_attempts between 19.11.05 and 19.11.07... No change to login_attempts between 19.11.05 and origin/19.11.x... Ah, but this is an upgraded database. I see in kohastructure.sql that login_attempts has "default 0" but in my actual upgraded database it has "default null". In 16.12.00.037, there is the following (for Bug 18314 - Add FailedLoginAttempts and borrowers.login_attempts): ALTER TABLE borrowers ADD COLUMN login_attempts INT(4) DEFAULT 0 AFTER lastseen In 17.06.00.009, the DEFAULT 0 was removed (for Bug 19344 - Reorder lang and login_attempts in the [deleted]borrowers tables): ALTER TABLE borrowers MODIFY COLUMN login_attempts int(4) AFTER lang; So that explains that. New databases will be fine, but upgraded databases will not be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- (In reply to Jonathan Druart from comment #9) > I have tried on both master and 19.11.x and login_attempts contains "0" I have tried on 19.11.05 and login_attempts is null. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Katrin Fischer changed: What|Removed |Added Summary|Borrowers Login Attempts|Borrowers login attempts |happen to be NULL instead |happen to be NULL instead |of 0|of 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Jonathan Druart changed: What|Removed |Added Summary|Borrowers Login Attempts is |Borrowers Login Attempts |NULL|happen to be NULL instead ||of 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/