[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #52 from Martin Renvoize --- (In reply to Nicolas Legrand from comment #51) > (In reply to Martin Renvoize from comment #50) > > Works well, Signing off. > > ^^ thanks! > > > One minor query, would you ever need to alter which desk the item is located > > at.. either at return time or via another method? > > I don't understand? I hadn't thought about a second checkin, but I'm glad that works as expected. I suppose I was wondering about whether there was a need to expose the desks as a selectable option at checkin should you want to pass the book to another desk there and then.. but actually I'm not sure there's really a use case for that. > Unfortunately, while I was looking at this, I found two bugs : (1) if you > check in a book waiting at another library, it makes a server internal > error. (2) When changing libraries, the menu proposes only one desk and not > the entire set. > > I'll look at (1) here and (2) in a separate bugzilla... Good catches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #51 from Nicolas Legrand --- (In reply to Martin Renvoize from comment #50) > Works well, Signing off. ^^ thanks! > One minor query, would you ever need to alter which desk the item is located > at.. either at return time or via another method? I don't understand? The behaviour right now is : if you re-check-in a waiting item with another desk in your session, it changes the desk where the reserved item is waiting. This is not a usecase for us, but I find this useful : it's easy to move the book internally. Unfortunately, while I was looking at this, I found two bugs : (1) if you check in a book waiting at another library, it makes a server internal error. (2) When changing libraries, the menu proposes only one desk and not the entire set. I'll look at (1) here and (2) in a separate bugzilla... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #50 from Martin Renvoize --- Works well, Signing off. One minor query, would you ever need to alter which desk the item is located at.. either at return time or via another method? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #110455|0 |1 is obsolete|| --- Comment #49 from Martin Renvoize --- Created attachment 110586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110586=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #110453|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize --- Created attachment 110584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110584=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #110454|0 |1 is obsolete|| --- Comment #48 from Martin Renvoize --- Created attachment 110585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110585=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #110452|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 110583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110583=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #110451|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 110582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110582=edit Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #44 from Nicolas Legrand --- Created attachment 110455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110455=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110068|0 |1 is obsolete|| --- Comment #41 from Nicolas Legrand --- Created attachment 110452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110452=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110067|0 |1 is obsolete|| --- Comment #40 from Nicolas Legrand --- Created attachment 110451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110451=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110450|0 |1 is obsolete|| --- Comment #42 from Nicolas Legrand --- Created attachment 110453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110453=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110070|0 |1 is obsolete|| --- Comment #43 from Nicolas Legrand --- Created attachment 110454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110454=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110069|0 |1 is obsolete|| --- Comment #39 from Nicolas Legrand --- Created attachment 110450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110450=edit Bug 24412: (follow-up) QA useless change. Maybe it was a relic of something usefull... anyway not anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #38 from Nicolas Legrand --- Ho. I feel uncomfortable. When I saw it I thought “how peculiar... But maybe there is a reason anyway...” And I let it... I feel a bit ashamed. I'm going to revert this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #37 from Martin Renvoize --- Comment on attachment 110068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110068 Bug 24412: Attach waiting reserve to desk Review of attachment 110068: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24412=110068) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ +462,4 @@ > name="cancel_reserve" value="0" /> > name="barcode" value="[% barcode | html %]" /> > > +class="btn btn-default approve" [% IF ( Desks.ListForLibrary ) > %]data-dismiss="modal" [% END %]> Could you explain this change.. I'm not sure I understand it's purpose? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #36 from Nicolas Legrand --- Rebased! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101956|0 |1 is obsolete|| --- Comment #32 from Nicolas Legrand --- Created attachment 110067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110067=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #106648|0 |1 is obsolete|| --- Comment #34 from Nicolas Legrand --- Created attachment 110069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110069=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #106586|0 |1 is obsolete|| --- Comment #33 from Nicolas Legrand --- Created attachment 110068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110068=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #35 from Nicolas Legrand --- Created attachment 110070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110070=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101955|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #31 from Nicolas Legrand --- Created attachment 106648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106648=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #30 from Nicolas Legrand --- This is just a rebase of the failed version :D. Corrected one coming soonishly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101957|0 |1 is obsolete|| --- Comment #29 from Nicolas Legrand --- Created attachment 106586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106586=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #28 from Josef Moravec ---
Comment on attachment 101957
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101957
Bug 24412: Attach waiting reserve to desk
Review of attachment 101957:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24412=101957)
-
::: Koha/Hold.pm
@@ +173,3 @@
> };
>
> +if (defined $desk_id) { $values->{'desk_id'} = $desk_id };
the desk_id => $desk_id, setting in values above should be omitted, only the
one in if should stay
@@ +323,5 @@
> +my ($self) = @_;
> +
> +$self->{_desk} ||= Koha::Desks->find( $self->desk_id() );
> +
> +return $self->{_desk};
You should use relation and _new_from_dbic here, see
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriented_code_and_the_Koha::_namespace_.5BPROPOSAL_FOR_CHANGE_dev_meeting_2.2F2020.5D
::: Koha/Template/Plugin/Desks.pm
@@ +47,5 @@
> +
> +sub GetName {
> +my ( $self, $desk_id ) = @_;
> +my $d = Koha::Desks->find( $desk_id );
> +return (defined $d) ? $d->unblessed->{'desk_name'} : q{};
should be something like:
return $d ? $d->desk_name : q{};
::: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
@@ +120,4 @@
> [% IF ( hold.found ) %]
> [% IF ( hold.atdestination ) %]
> [% IF ( hold.found ) %]
> +Item waiting at [% hold.wbrname | html
> %][% IF hold.desk_name %], [% hold.desk_name | html %],[% END %] type="hidden" name="pickup" value="[% hold.wbrcode | html %]" /> since [%
> hold.waiting_date | $KohaDates %]
Looks like you don't need to use Desks template plugin.
::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ +381,4 @@
> [% SET hold = item.first_hold %]
> [% IF hold %]
> [% IF hold.waitingdate %]
> +Waiting at [% Branches.GetName(
> hold.branchcode ) | html %][% IF ( hold.desk_id ) %], [% Desks.GetName (
> hold.desk_id ) | html %][% END %] since [% hold.waitingdate | $KohaDates %].
you don't new Desks template plugin, just use hold.desk.desk_name
::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +468,4 @@
>
>
> name="cancel_reserve" value="0" />
> +class="btn btn-default approve" [% IF (Desks.defined) %]data-dismiss="modal"
> [% END %]>
Will need update as Desks.defined was removed in previous patches on bug 24201
::: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
@@ +106,4 @@
>
> [% IF ( HOLD.is_at_destination ) %]
> [% IF ( HOLD.found ) %]
> +Item waiting at [%
> HOLD.branch.branchname | html %][% IF ( HOLD.desk_id ) %], [%
> Desks.GetName ( HOLD.desk_id ) | html %],[% END %]
you don't new Desks template plugin, just use hold.desk.desk_name
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #27 from Josef Moravec ---
Comment on attachment 101956
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101956
Bug 24412: kohastructure and atomic update
Review of attachment 101956:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24412=101956)
-
:::
installer/data/mysql/atomicupdate/bug_24412_Attach_waiting_reserve_to_desk.perl
@@ +1,4 @@
> +$DBversion = 'XXX'; # will be replaced by the RM
> +if( CheckVersion( $DBversion ) ) {
> +# you can use $dbh here like:
> +$dbh->do(q{
there should be check for column existance before adding it, something like:
if ( !column_exists( 'reserves', 'desk_id' ) ) {
$dbh->do(...);
}
@@ +5,5 @@
> +ALTER TABLE reserves ADD COLUMN desk_id INT(11) DEFAULT NULL AFTER
> branchcode,
> + ADD KEY desk_id (`desk_id`),
> + ADD CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`desk_id`) REFERENCES
> `desks` (`desk_id`) ON DELETE CASCADE ON UPDATE CASCADE ;
> + });
> +$dbh->do(q{
there should be check for column existance too
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #26 from Martin Renvoize --- (In reply to Martin Renvoize from comment #22) > Fixed up the schema change and kohastructure change. Now it's really fixed.. doh! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #101900|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 101957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101957=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #101899|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 101956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101956=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #101898|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 101955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101955=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #101885|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 101899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101899=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #101886|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 101900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101900=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #22 from Martin Renvoize --- Fixed up the schema change and kohastructure change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #101884|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 101898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101898=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101825|0 |1 is obsolete|| --- Comment #18 from Nicolas Legrand --- Created attachment 101886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101886=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101721|0 |1 is obsolete|| --- Comment #16 from Nicolas Legrand --- Created attachment 101884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101884=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101722|0 |1 is obsolete|| --- Comment #17 from Nicolas Legrand --- Created attachment 101885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101885=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101723|0 |1 is obsolete|| --- Comment #14 from Nicolas Legrand --- Created attachment 101825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101825=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #15 from Nicolas Legrand ---
(In reply to Fridolin SOMERS from comment #13)
> Small typo :
>
> =head2 ModReserveAffect
>
> -
> ($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id);
> +
> ($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id,
> $desk);
>
> sub ModReserveAffect {
> -my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id ) = @_;
> +my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id, $desk_id
> ) = @_;
>
> Doc line should say $desk_id instead of $desk right ?
right, thank you Frido!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #13 from Fridolin SOMERS ---
Small typo :
=head2 ModReserveAffect
- ($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id);
+ ($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id,
$desk);
sub ModReserveAffect {
-my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id ) = @_;
+my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id, $desk_id )
= @_;
Doc line should say $desk_id instead of $desk right ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101630|0 |1 is obsolete|| --- Comment #12 from Nicolas Legrand --- Created attachment 101723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101723=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101629|0 |1 is obsolete|| --- Comment #11 from Nicolas Legrand --- Created attachment 101722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101722=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101628|0 |1 is obsolete|| --- Comment #10 from Nicolas Legrand --- Created attachment 101721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101721=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101627|0 |1 is obsolete|| --- Comment #9 from Nicolas Legrand --- Created attachment 101630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101630=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101625|0 |1 is obsolete|| --- Comment #7 from Nicolas Legrand --- Created attachment 101628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101628=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #101626|0 |1 is obsolete|| --- Comment #8 from Nicolas Legrand --- Created attachment 101629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101629=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #97330|0 |1 is obsolete|| --- Comment #6 from Nicolas Legrand --- Created attachment 101627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101627=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #97329|0 |1 is obsolete|| --- Comment #5 from Nicolas Legrand --- Created attachment 101626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101626=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #97328|0 |1 is obsolete|| --- Comment #4 from Nicolas Legrand --- Created attachment 101625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101625=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |nicolas.legr...@bulac.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #2 from Nicolas Legrand --- Created attachment 97329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97329=edit Bug 24412: kohastructure and atomic update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #1 from Nicolas Legrand --- Created attachment 97328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97328=edit Bug 24412: Schema file DO NOT PUSH! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #3 from Nicolas Legrand --- Created attachment 97330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97330=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 13881 and then Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
