[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21507 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #12 from Katrin Fischer --- Does the bug description still fit with what the patch does? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- Can the DB update be formatted a bit nicer please? Use installer/data/mysql/atomicupdate/skeleton.pl as an example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21507 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #147412|0 |1 is obsolete|| --- Comment #10 from Victor Grousset/tuxayo --- Created attachment 147413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147413=edit Bug 24499: (QA follow-up) fix spelling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #9 from Victor Grousset/tuxayo --- Hi :) Thibaud: - fixed commit message not having the ticket number has prefix - fixed spelling in syspref text Marius: added back the rest of the commit message (description & test plan) that was lost. When signing off, one must amend the commit to add the Signed-off-by line after the existing stuff. Or some equivalent method. That's all from me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 147412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147412=edit Bug 24499: (QA follow-up) fix spelling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Attachment #145356|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 147411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147411=edit Bug 24499: New syspref EnhancedMessaging for clearer functionality Actually there is EnhancedMessagingPreferences that can be set on "Allow" or "Don't allow" to show or not show messaging preferences for patrons. But this syspref does not prevent notifications from being sent. From your comments, I decide to create a new syspref which show dialog alert on patron details (Patron messaging preferences section) but prevent misc/cronjobs/advance_notices.pl script. EnhancedMessagingPreferences keep the same behavior I just took over preferences descriptions to make clearer context (on EnhancedMessagingPreferencesOPAC too). Test plan : 1 - Be sure to have a patron with a loan 2 - Also be sure to have a model on your library in "Notices & slips" 3 - Set max days for advance_notices on patron details table 4 - Then set EnhancedMessagingPreferences to "Allow" 5 - On Patron details you will see the table for settings notifications 6 - Run the misc/cronjobs/advance_notices.pl script manually 7 - The script find a notice and add a message in message_queue table 8 - Set now EnhancedMessagingPreferences to "Don't allow" 9 - Repeat the step 5, you don't see the table right now 10 - Repeat the step 6, same behavior, a message is created and stored 11 - Now apply this patch and launch updatedatabase.pl 12 - You will see the new syspref "EnhanceMessaging" 13 - If you want you can repeat steps 4 to 10 - same behavior again 14 - But now, you can set to "Don't send" on EnhancedMessaging 15 - See on patron details page, there is a dialog alert to inform 16 - Run again the step 6, normally it will send you a warn and no message was created or stored. Signed-off-by: Marius Mandrescu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Marius changed: What|Removed |Added Attachment #129834|0 |1 is obsolete|| --- Comment #6 from Marius --- Created attachment 145356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145356=edit New syspref EnhancedMessaging for clearer functionality Everything is fine in this pache. https://bugs.koha-community.org/show_bug.cgi?id=24499 Signed-off-by: Marius Mandrescu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Marius changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff CC||thibaud.guil...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #5 from Thibaud Guillot --- Created attachment 129834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129834=edit New syspref EnhancedMessaging for clearer functionality Actually there is EnhancedMessagingPreferences that can be set on "Allow" or "Don't allow" to show or not show messaging preferences for patrons. But this syspref does not prevent notifications from being sent. From your comments, I decide to create a new syspref which show dialog alert on patron details (Patron messaging preferences section) but prevent misc/cronjobs/advance_notices.pl script. EnhancedMessagingPreferences keep the same behavior I just took over preferences descriptions to make clearer context (on EnhancedMessagingPreferencesOPAC too). Test plan : 1 - Be sure to have a patron with a loan 2 - Also be sure to have a model on your library in "Notices & slips" 3 - Set max days for advance_notices on patron details table 4 - Then set EnhancedMessagingPreferences to "Allow" 5 - On Patron details you will see the table for settings notifications 6 - Run the misc/cronjobs/advance_notices.pl script manually 7 - The script find a notice and add a message in message_queue table 8 - Set now EnhancedMessagingPreferences to "Don't allow" 9 - Repeat the step 5, you don't see the table right now 10 - Repeat the step 6, same behavior, a message is created and stored 11 - Now apply this patch and launch updatedatabase.pl 12 - You will see the new syspref "EnhanceMessaging" 13 - If you want you can repeat steps 4 to 10 - same behavior again 14 - But now, you can set to "Don't send" on EnhancedMessaging 15 - See on patron details page, there is a dialog alert to inform 16 - Run again the step 6, normally it will send you a warn and no message was created or stored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Sophie MEYNIEUX changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m --- Comment #4 from Sophie MEYNIEUX --- I think there is two distinct points : 1/ The ability to define preferences 2/ Central activation/desactivation of notifications 1/ Should always be on (see bug 20405) 2/ Could be a preference system. Scripts that send notices must check if on before sending, whatever preferences are. This will allow to suspend temporarily notifications without changing parameters. At the moment, when preferences are set, if you disable EnhancedMessagingPreferences, you can't see how preferences are configured in admin interface, but notices are still sent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer changed: What|Removed |Added Summary|sys pref|System preference |EnhancedMessagingPreference |EnhancedMessagingPreference |s if set to Don't Allow |s if set to 'Don't allow' |does not even show within |doesn't even show within |Patron Categories |patron categories Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/