[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2024-03-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #19 from David Gustafsson  ---
Now rebased.

@solene.nga...@inlibro.com It's still reproducible for me, there could be
issues if the mappings for title have sort enabled for more fields than 245, in
which case the sort order will be unpredictable as some other field might be
the one actually sorted on. Had that same issue myself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2024-03-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson  changed:

   What|Removed |Added

 Attachment #125210|0   |1
is obsolete||

--- Comment #18 from David Gustafsson  ---
Created attachment 162674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162674=edit
Bug 24720: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2023-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||lu...@bywatersolutions.com

--- Comment #17 from Lucas Gass  ---
Very simple rebase need here in Elasticsearch.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2023-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26472

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2023-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

solene.nga...@inlibro.com changed:

   What|Removed |Added

 CC||solene.nga...@inlibro.com

--- Comment #16 from solene.nga...@inlibro.com ---
I was not able to repeat the bug. 

The message expected in step 8 is already present in step 4. The libraries are
already sorted no matter if there's a "[" or not before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2021-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

--- Comment #15 from David Gustafsson  ---
Rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2021-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson  changed:

   What|Removed |Added

 Attachment #124760|0   |1
is obsolete||

--- Comment #14 from David Gustafsson  ---
Created attachment 125210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125210=edit
Bug 24720: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2021-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson  changed:

   What|Removed |Added

 Attachment #124759|0   |1
is obsolete||

--- Comment #13 from David Gustafsson  ---
Created attachment 125209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125209=edit
Bug 24720: Strip special chars from sort fields

Strip all non alphanumerical characters from beginning
of sort field values so that sorting is performed on
the first alphanumeric character and not special characters
like "-" or "[".

To test:

1. Prepend "[" to the title of a biblio and save
2. Perform a search that matches this biblio and at least one
   more biblio.
3. Sort alphabetically a-z.
4. The biblio with "[" should appear first
5. Apply the patch
6. Perform a full reindexing
7. Perform steps 2-3 again
8. The result should now be alphabetically sorted,
   ignoring the initial bracket in the title.
9. Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2021-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

--- Comment #12 from David Gustafsson  ---
(In reply to Nick Clemens from comment #7)
> ...
> Additionally, I think this should be optional in search field configs:
> 1 - Title already has options for 'non-filing' characters - so if you want
> to ignore a leading '[' you can
> ...

I forgot to address this. You are right that ideally marc-posts with initial
characters that should not be considered when sorting should have a proper
value for non-filing characters. In practice though when either have a large
collection of biblios, or do not have complete control over imported records
this becomes very cumbersome to handle since this value has to be correctly set
on each record. Also some fields which you might want to sort on don't have
this indicator available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields

2021-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson  changed:

   What|Removed |Added

Summary|Remove special characters   |Remove special characters
   |from beginning of search|from beginning of sort
   |fields  |fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/