[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Aleisha Amohia changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in||19.11.08 CC||alei...@catalyst.net.nz --- Comment #10 from Aleisha Amohia --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Lucas Gass --- I don't see how the QA script failure could be a problem, I am backporting this anyway since it improves accessibility. backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- This patch fails the QA script for me: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 105) Which I do not understand because that line does include the aria-hidden attribute. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Katrin Fischer changed: What|Removed |Added Attachment #105770|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 106122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106122=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard changed: What|Removed |Added Attachment #105768|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 105770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105770=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #4 from Martin Renvoize --- Good catch.. new patch uploaded. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #3 from Martin Renvoize --- Created attachment 105768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105768=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Attachment #105743|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I don't think we want to add the "maincontent" class to the . I think we should try to keep that class for container s. Anyway, it's already added to the right above the "[% IF ( searchdesc ) %]" block -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added CC||bolsh...@parliament.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #1 from Martin Renvoize --- Created attachment 105743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105743=edit Bug 25254: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Blocks|25241 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25241 [Bug 25241] Accessibility: 1.4.4 Resize text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Blocks||25241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25241 [Bug 25241] Accessibility: 1.4.4 Resize text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Blocks|25240 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240 [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Blocks||25240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240 [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What|Removed |Added Blocks|23003 |25153 Depends on|25153 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25153 [Bug 25153] Accessibility: 1.3.1 Info and Relationships -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
