[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||25527


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25527
[Bug 25527] Package does not build because of missing log4perl.conf
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #32 from Joy Nelson  ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||25284

--- Comment #31 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #30)
> Could bug 25284 be related to this?

Testing strongly suggest it does... linking.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284
[Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #30 from Katrin Fischer  ---
Could bug 25284 be related to this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #29 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #28 from Jonathan Druart  
---
Created attachment 103485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103485&action=edit
Bug 25172: Fix Auth_with_ldap.t

#   Failed test 'checkpw_ldap tests'
  #   at t/db_dependent/Auth_with_ldap.t line 324.
  {UNKNOWN}: Configuration not defined at
/usr/share/perl5/Log/Log4perl/Config.pm line 579. at
/kohadevbox/koha/Koha/Patron.pm line 395

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #27 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15253


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253
[Bug 15253] Add Koha::Logger based logging for SIP2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #26 from Kyle M Hall  ---
Created attachment 103395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103395&action=edit
Bug 25172: Add missing filter

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #103304|0   |1
is obsolete||
 Attachment #103305|0   |1
is obsolete||
 Attachment #103306|0   |1
is obsolete||
 Attachment #103307|0   |1
is obsolete||
 Attachment #103310|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 103391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103391&action=edit
Bug 25172: Make Koha::Logger explode if init went wrong

We do not want to fail silently for the logger.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #23 from Kyle M Hall  ---
Created attachment 103392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103392&action=edit
Bug 25172: Remove _recheck_logfile

I don't understand how that could be useful. We do not want to test if
the logfile is writable every time we log something!

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #24 from Kyle M Hall  ---
Created attachment 103393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103393&action=edit
Bug 25172: Adjust tests

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #25 from Kyle M Hall  ---
Created attachment 103394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103394&action=edit
Bug 25172: Identify and display possible problems on the about page

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #21 from Kyle M Hall  ---
(In reply to Martin Renvoize from comment #20)
> Hmm, I can't get the test to fail either.

Thanks for the confirmations. It's probably something odd with my setup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #20 from Martin Renvoize  ---
Hmm, I can't get the test to fail either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #19 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #17)
> I love everything about this patch set, but I'm getting one unit test
> failure:
> 
> root@6b3a1a3db7b8:koha(bug25172-qa)$ prove t/Logger.t 
> t/Logger.t .. 
> #   Failed test 'Logger did not init correctly without permission'
> #   at t/Logger.t line 52.
> # Looks like you failed 1 test of 6.
> t/Logger.t .. 1/1 
> #   Failed test 'Test01 -- Simple tests for Koha::Logger'
> #   at t/Logger.t line 63.
> # Looks like you failed 1 test of 1.
> t/Logger.t .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/1 subtests 
> 
> Test Summary Report
> ---
> t/Logger.t (Wstat: 256 Tests: 1 Failed: 1)
>   Failed test:  1
>   Non-zero exit status: 1
> Files=1, Tests=1,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.36 cusr  0.06
> csys =  0.44 CPU)
> Result: FAIL
> 
> 
> Jonathan, does this test fail for you as well?

Thanks for testing Kyle.
No, it passes for me. But I have a weird behavior with this permission test, I
had to move it up before the other test (when the log file is 700).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #18 from Kyle M Hall  ---
Created attachment 103310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103310&action=edit
Bug 25172: Add missing filter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #17 from Kyle M Hall  ---
I love everything about this patch set, but I'm getting one unit test failure:

root@6b3a1a3db7b8:koha(bug25172-qa)$ prove t/Logger.t 
t/Logger.t .. 
#   Failed test 'Logger did not init correctly without permission'
#   at t/Logger.t line 52.
# Looks like you failed 1 test of 6.
t/Logger.t .. 1/1 
#   Failed test 'Test01 -- Simple tests for Koha::Logger'
#   at t/Logger.t line 63.
# Looks like you failed 1 test of 1.
t/Logger.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
---
t/Logger.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.36 cusr  0.06
csys =  0.44 CPU)
Result: FAIL


Jonathan, does this test fail for you as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #16 from Kyle M Hall  ---
(In reply to Martin Renvoize from comment #15)
> This all appears to work as expected for me.. and offers a genuine
> improvement.. I didn't like that we just carried on regardless either.. I'm
> sure Kyle has also done similar changes in a SIP bug at some point?

The SIP logging bug uses Koha::Logger so its' behavior should be fixed by this
as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #15 from Martin Renvoize  ---
This all appears to work as expected for me.. and offers a genuine
improvement.. I didn't like that we just carried on regardless either.. I'm
sure Kyle has also done similar changes in a SIP bug at some point?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #103303|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 103307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103307&action=edit
Bug 25172: Identify and display possible problems on the about page

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #103302|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 103306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103306&action=edit
Bug 25172: Adjust tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #103301|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 103305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103305&action=edit
Bug 25172: Remove _recheck_logfile

I don't understand how that could be useful. We do not want to test if
the logfile is writable every time we log something!

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #103300|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 103304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103304&action=edit
Bug 25172: Make Koha::Logger explode if init went wrong

We do not want to fail silently for the logger.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Martin Renvoize  changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #10 from Martin Renvoize  ---
Patches apply now, taking a look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #8 from Jonathan Druart  
---
Created attachment 103302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103302&action=edit
Bug 25172: Adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #9 from Jonathan Druart  
---
Created attachment 103303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103303&action=edit
Bug 25172: Identify and display possible problems on the about page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #7 from Jonathan Druart  
---
Created attachment 103301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103301&action=edit
Bug 25172: Remove _recheck_logfile

I don't understand how that could be useful. We do not want to test if
the logfile is writable every time we log something!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #103088|0   |1
is obsolete||
 Attachment #103089|0   |1
is obsolete||
 Attachment #103090|0   |1
is obsolete||
 Attachment #103091|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 103300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103300&action=edit
Bug 25172: Make Koha::Logger explode if init went wrong

We do not want to fail silently for the logger.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Patch doesn't apply

--- Comment #5 from Kyle M Hall  ---
Applying: Bug 25172: Make Koha::Logger explode if init went wrong
error: sha1 information is lacking or useless (Koha/Logger.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 25172: Make Koha::Logger explode if init went wrong

I think this patch set needs a rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #4 from Jonathan Druart  
---
Created attachment 103091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103091&action=edit
Bug 25172: Identify and display possible problems on the about page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #3 from Jonathan Druart  
---
Created attachment 103090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103090&action=edit
Bug 25172: Adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion
 CC||k...@bywatersolutions.com,
   ||m.de.r...@rijksmuseum.nl,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #1 from Jonathan Druart  
---
Created attachment 103088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103088&action=edit
Bug 25172: Make Koha::Logger explode if init went wrong

We do not want to fail silently for the logger.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

--- Comment #2 from Jonathan Druart  
---
Created attachment 103089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103089&action=edit
Bug 25172: Remove _recheck_logfile

I don't understand how that could be useful. We do not want to test if
the logfile is writable every time we log something!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14167


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167
[Bug 14167] Add Koha::Logger based on Log4perl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15253

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/