[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Katrin Fischer changed: What|Removed |Added Summary|Accessibility: The 'Confirm |Accessibility: The 'Confirm |reservation page' contains |hold page' contains |semantically incorrect |semantically incorrect |headings|headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #105741|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 105758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105758&action=edit Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #3 from Sally --- Works great - just a note for future testers, to make H3 (Hold levels) appear, do the following: 1/ Perform a search which yields some results in the OPAC 2/ Place a hold on an item 3/ Go back to the same record and attempt to place a second hold 4/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 5/ Apply this patch and reload the page 6/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 7/ Note the appearance of the box is still reasonable 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Katrin Fischer changed: What|Removed |Added Attachment #105758|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 106116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106116&action=edit Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.02 released in|| --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #7 from Aleisha Amohia --- There are no headings on this page in 19.11.x. I'd like to backport this for accessibility, but need someone to write a patch that fixes the Confirm holds for: for 19.11.x only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Aleisha Amohia changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in||19.11.08 --- Comment #8 from Aleisha Amohia --- decided to rebase myself :) backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 --- Comment #9 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
