[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #25 from Victor Grousset/tuxayo --- Doesn't seem to affect 19.05.x not backporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00, 20.05.05 |20.11.00, 20.05.05, released in||19.11.12 CC||alei...@catalyst.net.nz Status|Pushed to stable|Pushed to oldstable --- Comment #24 from Aleisha Amohia --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.05 released in|| --- Comment #23 from Lucas Gass --- accessibility enhancement, choosing to backport backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #22 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Katrin Fischer changed: What|Removed |Added Attachment #109663|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 109994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109994=edit Bug 25242: Improve column wrapping for holdingst This patch attempts to improve the column wrapping for the holdingst datatable and sets the tabel to fixed width to prevent overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to an item with holdings visible in the OPAC 3/ 'Play' with various window sizes and zoom levels. 4/ The table should not overlap with right navigation content 5/ Signoff NOTE: This is an alternative patch to those pushed and reverted that attempted to provide a global fix to overlap issues. This patch specifically targets just the holdings table in the opac detail view. Signed-off-by: Timothy Alexis Vass Signed-off-by: Alexis Ripetti Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Alexis Ripetti changed: What|Removed |Added Attachment #109654|0 |1 is obsolete|| --- Comment #20 from Alexis Ripetti --- Created attachment 109663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109663=edit Bug 25242: Improve column wrapping for holdingst This patch attempts to improve the column wrapping for the holdingst datatable and sets the tabel to fixed width to prevent overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to an item with holdings visible in the OPAC 3/ 'Play' with various window sizes and zoom levels. 4/ The table should not overlap with right navigation content 5/ Signoff NOTE: This is an alternative patch to those pushed and reverted that attempted to provide a global fix to overlap issues. This patch specifically targets just the holdings table in the opac detail view. Signed-off-by: Timothy Alexis Vass Signed-off-by: Alexis Ripetti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Timothy Alexis Vass changed: What|Removed |Added Attachment #109444|0 |1 is obsolete|| --- Comment #19 from Timothy Alexis Vass --- Created attachment 109654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109654=edit Bug 25242: Improve column wrapping for holdingst This patch attempts to improve the column wrapping for the holdingst datatable and sets the tabel to fixed width to prevent overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to an item with holdings visible in the OPAC 3/ 'Play' with various window sizes and zoom levels. 4/ The table should not overlap with right navigation content 5/ Signoff NOTE: This is an alternative patch to those pushed and reverted that attempted to provide a global fix to overlap issues. This patch specifically targets just the holdings table in the opac detail view. Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #18 from Martin Renvoize --- Here we go again.. Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Attachment #108439|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Attachment #108574|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Attachment #108438|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #17 from Martin Renvoize --- Created attachment 109444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109444=edit Bug 25242: Improve column wrapping for holdingst This patch attempts to improve the column wrapping for the holdingst datatable and sets the tabel to fixed width to prevent overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to an item with holdings visible in the OPAC 3/ 'Play' with various window sizes and zoom levels. 4/ The table should not overlap with right navigation content 5/ Signoff NOTE: This is an alternative patch to those pushed and reverted that attempted to provide a global fix to overlap issues. This patch specifically targets just the holdings table in the opac detail view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What|Removed |Added Status|Pushed to master|ASSIGNED Version(s)|20.11.00| released in|| --- Comment #16 from Jonathan Druart --- Patches have been reverted from master. commit 4009bb04ad857ef042bba9a4d690dd21d84ac3dd Revert "Bug 25242: Improve column wrapping and overflow for tables" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #15 from Katrin Fischer --- I suspect that this setting is too radical: +table-layout: fixed; fixed Sets a fixed table layout algorithm. The table and column widths are set by the widths of table and col or by the width of the first row of cells. Cells in other rows do not affect column widths. If no widths are present on the first row, the column widths are divided equally across the table, regardless of content inside the cells So that's why I said we should maybe reconsider and start over, trying to fix the initial issue differently than trying to work on all other tables - I think that could be easier after all. See also Owen's comment on bug 26263. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #14 from Martin Renvoize --- We could target just this table, but personally I'd rather work through fixing issues and keep with OPAC wide accessibility and responsive design fix provided here. We have the time left in the cycle, I'm happy to commit to providing fixes if you bring my attention to them. I did mention in the test plan to check various tables rather that just focus on the one I was targeting fixing. Problem is, we have lots of tables that display differently with varying settings. We clearly missed some combinations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #13 from Katrin Fischer --- I suggest to revert and start fresh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #12 from Katrin Fischer --- I feel like this has too many side effects, some have been filed, but I am seeing more. For example the course reserves tables no longer "squashes" nicely on smaller screens - the columns contents run into each other. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What|Removed |Added Blocks||26263 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26263 [Bug 26263] Style error on OPAC search results when item-level_itypes is set to bibliographic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #10 from Martin Renvoize --- Created attachment 108574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108574=edit Bug 25242: (QA follow-up) Remove deprecated break-word It appears break-word is now deprecated in Firefox and instead all browsers now support break-all as the definitive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #9 from Martin Renvoize --- Sounds like perhaps we no longer do.. break-all appears ot be the modern equivilent on all browsers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- On https://developer.mozilla.org/en-US/docs/Web/CSS/word-break word-break: break-word; is marked as deprecated Do we really need it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #7 from Martin Renvoize --- Oops, this one slipped through QA without the results table being checked properly.. This table is NOT a datatable like the others and thus didn't have authwidth being calculated. The followup corrects the display of this table.. I have tried to catch all other tables during my own testing, and am happy to provide further followups if we spot anything post push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #6 from Martin Renvoize --- Created attachment 108439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108439=edit Bug 25242: (QA follow-up) Colwidth on results table Prior to this patch, the column width on the opac-results table were not fixed or calculated by a datatable; As such when we introduced the 'table-layout: fixed' property all columns were given equal share of the table, which resulted in most cases in a three way split between a checkbox, an empty cell and the actual content. This patch sets the width for the selectcol to '1ch' for the single character checkbox and updates the second columns class to 'numcol' as it is not used for selection but rather result numbering and sets a fixed width of '4ch' allowing for results upto 3 digits (plus the period) to display correctly without wrapping. Test plan 1/ Apply the patches and run the yarn build process to update the .css 2/ Perform a search and varify that the results table looks reasonable 3/ Disable OPACHiddenItems and perform a search again. 4/ Confirm the table looks reasonable still 5/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Attachment #108348|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 108438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108438=edit Bug 25242: Improve column wrapping and overflow for tables This patch attempts to improve the column wrapping and prevent datatabels from overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to various tables in the OPAC (Holds table is a good one) and 'play' with various window sizes and zoom levels. 3/ The table should not overlap with right navigation content 4/ Signoff Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Katrin Fischer changed: What|Removed |Added Attachment #107897|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 108348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108348=edit Bug 25242: Improve column wrapping and overflow for tables This patch attempts to improve the column wrapping and prevent datatabels from overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to various tables in the OPAC (Holds table is a good one) and 'play' with various window sizes and zoom levels. 3/ The table should not overlap with right navigation content 4/ Signoff Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Owen Leonard changed: What|Removed |Added Attachment #107884|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 107897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107897=edit Bug 25242: Improve column wrapping and overflow for tables This patch attempts to improve the column wrapping and prevent datatabels from overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to various tables in the OPAC (Holds table is a good one) and 'play' with various window sizes and zoom levels. 3/ The table should not overlap with right navigation content 4/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #2 from Martin Renvoize --- Sources: * https://stackoverflow.com/questions/19571017/how-do-i-fix-long-column-value-issue-which-breaks-table-outside-of-container-us * https://stackoverflow.com/questions/38635412/how-to-fix-jquery-datatables-from-overflowing-outside-parent-div-in-internet-exp/38921912 * https://datatables.net/forums/discussion/21110 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12580 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #1 from Martin Renvoize --- Created attachment 107884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107884=edit Bug 25242: Improve column wrapping and overflow for tables This patch attempts to improve the column wrapping and prevent datatabels from overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to various tables in the OPAC (Holds table is a good one) and 'play' with various window sizes and zoom levels. 3/ The table should not overlap with right navigation content 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Henry Bolshaw changed: What|Removed |Added CC||bolsh...@parliament.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Blocks|25243 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Blocks||25243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What|Removed |Added Blocks|23003 |25241 Depends on|25241 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25241 [Bug 25241] Accessibility: 1.4.4 Resize text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/