[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #15 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #13 from Katrin Fischer --- (In reply to Nick Clemens from comment #12) > (In reply to Katrin Fischer from comment #11) > >if you add any line breaks just for > > making the HTML more readable, they will also all create a line break. > > Should we not do either/or? > > We had calls that already did this - if we want either or, we need a flag to > determine whether the field is HTML or not, otherwise we need to test with > regex? > > I don't think the additional breaks for HTML cause a problem, but I'll > follow your viewpoint. Maybe a new bug - so we can make a decision and be > consistent on all the calls? I think mostly people will probably use bold, italic etc and not do whole paragraphs here, so we are probably OK with the line breaks. You are right, we should discuss separately when needed, but I feel we can wait and see if it actually turns out to be an issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #12 from Nick Clemens --- (In reply to Katrin Fischer from comment #11) >if you add any line breaks just for > making the HTML more readable, they will also all create a line break. > Should we not do either/or? We had calls that already did this - if we want either or, we need a flag to determine whether the field is HTML or not, otherwise we need to test with regex? I don't think the additional breaks for HTML cause a problem, but I'll follow your viewpoint. Maybe a new bug - so we can make a decision and be consistent on all the calls? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #11 from Katrin Fischer --- Thanks, Nick! I am not sure really about allowing HTML and then also meddling with line breaks. It creates a somewhat weird combination. html_line_break This filter replaces any newlines with HTML tags, thus preserving the line breaks of the original text in the HTML output. So you can do now without , but if you add any line breaks just for making the HTML more readable, they will also all create a line break. Should we not do either/or? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Minor followups, RM can veirfy, PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #9 from Nick Clemens --- Created attachment 150396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150396=edit Bug 25379: (QA follow-up) Adjust other occurrences and add line break This updates the other occurrences and adds html_line_break to all except the edit page - it seems html or raw doesn't affect the value of the textarea, but moved to raw for consistency To test: 1 - Add an HTML note to a patron, make sure to add a line break: Testing Newline 2 - Checkout to patron and return 3 - Confirm note shows correctly 4 - Add patron to a list 5 - Confirm note displays correctly 6 - Edit patron, confirm note field is correct 7 - Batch modify borrower 8 - Confirm note displays correctly in batch list Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens changed: What|Removed |Added Attachment #148496|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 150395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150395=edit Bug 25379: Add raw filter to circulation note on checkin page This is a consistency patch: we already allow adding HTML tags to the patron circulation note and the contents display correctly in the patron account and in the patron search results in the staff interface. But the HTML tags are printed on the checkins page. To test: * Add a circulation note including HTML tags to a patron Example: This patron is great! * Check an item out to this patron * Verify that the note displays formatted in patron search results * Verify that the note displays formatted in the patron record * Return the item * Verify the note shows the printed tags * Apply patch * Check item out again and check it in again * Verify the note now displays correctly in list of checkins Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33637 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #7 from Jonathan Druart --- Shouldn't we use html_linebreak as well? We do in moremember: [% patron.borrowernotes | $raw | html_line_break %] Also, why are we only dealing with the checkin page? There are other places where it's displayed escaped (`git grep 'borrowernotes | html'`) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 David Nind changed: What|Removed |Added Attachment #148387|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 148496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148496=edit Bug 25379: Add raw filter to circulation note on checkin page This is a consistency patch: we already allow adding HTML tags to the patron circulation note and the contents display correctly in the patron account and in the patron search results in the staff interface. But the HTML tags are printed on the checkins page. To test: * Add a circulation note including HTML tags to a patron Example: This patron is great! * Check an item out to this patron * Verify that the note displays formatted in patron search results * Verify that the note displays formatted in the patron record * Return the item * Verify the note shows the printed tags * Apply patch * Check item out again and check it in again * Verify the note now displays correctly in list of checkins Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #5 from Katrin Fischer --- Created attachment 148387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148387=edit Bug 25379: Add raw filter to circulation note on checkin page This is a consistency patch: we already allow adding HTML tags to the patron circulation note and the contents display correctly in the patron account and in the patron search results in the staff interface. But the HTML tags are printed on the checkins page. To test: * Add a circulation note including HTML tags to a patron Example: This patron is great! * Check an item out to this patron * Verify that the note displays formatted in patron search results * Verify that the note displays formatted in the patron record * Return the item * Verify the note shows the printed tags * Apply patch * Check item out again and check it in again * Verify the note now displays correctly in list of checkins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Katrin Fischer changed: What|Removed |Added Version|19.11 |master Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Summary|HTML tags visible in|HTML in circulation notes |Returns.pl |doesn't show correctly on ||checkin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
