[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #28 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master --- Comment #27 from Jonathan Druart --- Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Version(s)||20.05 released in|| Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #26 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > > Maps (Books) > > Fiction (Reference) > > Unchanged => WRONG Should be Unchanged (General Stacks) > > Riverside (Fairview) > > Unchanged (Fairview) > > I thought you said we would be dealing with this here: > > >Will be fixed by the follow-up I have just attached to bug 22630: > >Bug 22630: Display correct "in storage" value It was a problem with the homebranch only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Blocks||25609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 [Bug 25609] Use of permanent location instead of location -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #25 from Jonathan Druart --- (In reply to Kyle M Hall from comment #20) > (In reply to Kyle M Hall from comment #18) > > (In reply to Jonathan Druart from comment #15) > > > The template is displaying permanent_location, is that correct? > > > In C4::CourseReserves we always play with items.location. > > > I have, in DB: > > > homebranch: RPL > > > holdingbranch: FPL > > > location: GEN > > > permanent_location: NULL > > > > > > I guess that's why I don't see the "location". > > > What is the expected behaviour here? > > > > That was a change made on bug 21446, which doesn't really justify the > > change. In my original code, everything operates on the 'location' column. > > The code has never touch permanent location. I would suggest reverting the > > behavior of 21446. > > I think we should also move this particular visual issue to a new bug. The > description of this bug is "Course reserve settings are not saved on edit", > and these patches fix that issue. This discussion relates to a visual bug > and seems out of scope for this bug report. Agreed, I opened bug 25609. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #23 from Jonathan Druart --- Created attachment 105385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105385=edit Bug 25444: Simplify the code using a loop In order to prevent typos or further regressions it is better (I think) to have this code into a loop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #24 from Jonathan Druart --- Created attachment 105386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105386=edit Bug 25444: More minor improvements to simplified loop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Attachment #105370|0 |1 is obsolete|| Attachment #105371|0 |1 is obsolete|| Attachment #105378|0 |1 is obsolete|| Attachment #105379|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 105383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105383=edit Bug 25444: Add unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #22 from Jonathan Druart --- Created attachment 105384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105384=edit Bug 25444: Backup/restore course items fields correctly This patch makes the code set the *_storage fields when adding new fields to an existing course item. And reverts those fields correctly when removing the item from the course. If a new field is enabled on an existing course reserve, the storage field is not given a value, so when the item goes off reserve, the item field will always be updated to NULL. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/CourseReserves/CourseItems.t => FAIL: Tests fail, data is not reverted correctly 3. Apply this patch and repeat 2 => SUCCESS: Tests pass! Data is correctly reverted 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #20 from Kyle M Hall --- (In reply to Kyle M Hall from comment #18) > (In reply to Jonathan Druart from comment #15) > > The template is displaying permanent_location, is that correct? > > In C4::CourseReserves we always play with items.location. > > I have, in DB: > > homebranch: RPL > > holdingbranch: FPL > > location: GEN > > permanent_location: NULL > > > > I guess that's why I don't see the "location". > > What is the expected behaviour here? > > That was a change made on bug 21446, which doesn't really justify the > change. In my original code, everything operates on the 'location' column. > The code has never touch permanent location. I would suggest reverting the > behavior of 21446. I think we should also move this particular visual issue to a new bug. The description of this bug is "Course reserve settings are not saved on edit", and these patches fix that issue. This discussion relates to a visual bug and seems out of scope for this bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #19 from Kyle M Hall --- Created attachment 105379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105379=edit Bug 25444: More minor improvements to simplified loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #18 from Kyle M Hall --- (In reply to Jonathan Druart from comment #15) > The template is displaying permanent_location, is that correct? > In C4::CourseReserves we always play with items.location. > I have, in DB: > homebranch: RPL > holdingbranch: FPL > location: GEN > permanent_location: NULL > > I guess that's why I don't see the "location". > What is the expected behaviour here? That was a change made on bug 21446, which doesn't really justify the change. In my original code, everything operates on the 'location' column. The code has never touch permanent location. I would suggest reverting the behavior of 21446. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #17 from Katrin Fischer --- (In reply to Katrin Fischer from comment #16) > > Maps (Books) > > Fiction (Reference) > > Unchanged => WRONG Should be Unchanged (General Stacks) > > Riverside (Fairview) > > Unchanged (Fairview) > > I thought you said we would be dealing with this here: > > >Will be fixed by the follow-up I have just attached to bug 22630: > >Bug 22630: Display correct "in storage" value (In reply to Jonathan Druart from comment #15) > The template is displaying permanent_location, is that correct? > In C4::CourseReserves we always play with items.location. > I have, in DB: > homebranch: RPL > holdingbranch: FPL > location: GEN > permanent_location: NULL > > I guess that's why I don't see the "location". > What is the expected behaviour here? It's a good question. I am not sure about the mechanics - if permanent_location should be automatically pre-populated or will onyl be if you use the CART feature. I checked or oldest database and permanent_location is almost always empty. I think we should better use location here or have a fallback to it if permanent_location is empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #16 from Katrin Fischer --- > Maps (Books) > Fiction (Reference) > Unchanged => WRONG Should be Unchanged (General Stacks) > Riverside (Fairview) > Unchanged (Fairview) I thought you said we would be dealing with this here: >Will be fixed by the follow-up I have just attached to bug 22630: >Bug 22630: Display correct "in storage" value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #15 from Jonathan Druart --- The template is displaying permanent_location, is that correct? In C4::CourseReserves we always play with items.location. I have, in DB: homebranch: RPL holdingbranch: FPL location: GEN permanent_location: NULL I guess that's why I don't see the "location". What is the expected behaviour here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > Retesting with some more details: > > 1) Item used, original values: > > Item type: Books > Holding library: Fairview > Home library: Fairview > Location: General Stacks > Collection: Reference > Barcode: 300399 (from sample data) > > 2) Added to an active course reserve, using "Add reserves": > > Item type: Maps (changed) > Holding library: Fairview > Home library: Riverside (changed) > Location: General Stacks > Collection: Fiction (changed) > > 3) Display on course reserves table in staff: => https://snipboard.io/e59AiY.jpg Maps (Books) Fiction (Reference) Unchanged => WRONG Should be Unchanged (General Stacks) Riverside (Fairview) Unchanged (Fairview) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #13 from Jonathan Druart --- Created attachment 105378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105378=edit Bug 25444: Simplify the code using a loop In order to prevent typos or further regressions it is better (I think) to have this code into a loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Summary|Before and course reserve |Course reserve settings are |values are not correctly|not saved on edit |shown and data is lost | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
