[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #39 from Katrin Fischer ---
Doing a first review here:
1) QA script:
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
FAIL filters
missing_filter at line 36 ()
missing_filter at line 38 ()
missing_filter at line 39 ()
2) Unit tests
There are changes on the ModReserveCancelAll and Hold:cancel methods. Can we
please get some tests for the new behavior?
3) Docs
Maybe it would be worth mentioning that this allows to store a cancellation
reason in the documentation? (Bug title + description for release notes).
Currently only the email functionality is mentioned, but we also have an
interesting db change.
4) Constants for translation?
+var REASON_LABEL = _("Reason: ");
I believe this is not really needed here as the Javascript code is in a tt file
and not js. Not a blocker, but was wondering.
5) Sample notice
Could we please create a nice sample notice for this? I think it would make
using the feature easier on new installations especially since the TT syntax is
still a little hard to figure out. As an existing notice also triggers
activation, we can't add for existing installations.
6) Authorised value
We should add the authorised value to ease use of the feature. I believe this
would be save for existing and new installations? Please also add a nice
description to the template on what the category is used for (See:
/cgi-bin/koha/admin/authorised_values.pl)
7) GUI
reserve.pl
I think it would be nice if the cancellation reason only activated once a "del"
was selected. Otherwise people might expect it to do something without that or
expect it to also work when they cancel using "X".
moremember.pl/circulation.pl
I think for context we should add "Cancellation reason:" here before the pull
down too.
Why pendingreserves, but not holds queue?
pendingreserves: I'd remove the bold and add : (only one string to translate
for translators :) )
8) Possible enhancements
I wonder if it would be nice to move the pull downs to a modal dialog later. So
it will always show when you decide to cancel something. It would add an
additional click, but libraries can opt-in to use the feature and might like
the 'confirmation' step that reminds of setting the reason?
It also might be nice to haven option to 'not send an email' in some cases. At
the moment I think it's always or never? A checkbox for 'send email' might do
the job and could be selected/preselected depending on library choice.
Overall no big issues - works well!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #38 from Kyle M Hall --- Created attachment 108481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108481&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #37 from Kyle M Hall --- Created attachment 108480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108480&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #36 from Kyle M Hall --- Created attachment 108479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108479&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #35 from Kyle M Hall --- Created attachment 108478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108478&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Attachment #108476|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall --- Created attachment 108477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108477&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Attachment #105147|0 |1 is obsolete|| Attachment #105148|0 |1 is obsolete|| Attachment #105149|0 |1 is obsolete|| Attachment #105150|0 |1 is obsolete|| Attachment #105151|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall --- Created attachment 108476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108476&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #32 from Katrin Fischer --- Patches no longer apply cleanly, please rebase! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes changed: What|Removed |Added Attachment #105122|0 |1 is obsolete|| --- Comment #31 from ByWater Sandboxes --- Created attachment 105151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105151&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes changed: What|Removed |Added Attachment #105119|0 |1 is obsolete|| --- Comment #28 from ByWater Sandboxes --- Created attachment 105148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105148&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes changed: What|Removed |Added Attachment #105121|0 |1 is obsolete|| --- Comment #30 from ByWater Sandboxes --- Created attachment 105150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105150&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes changed: What|Removed |Added Attachment #105120|0 |1 is obsolete|| --- Comment #29 from ByWater Sandboxes --- Created attachment 105149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105149&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 ByWater Sandboxes changed: What|Removed |Added Attachment #105118|0 |1 is obsolete|| --- Comment #27 from ByWater Sandboxes --- Created attachment 105147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105147&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105115|0 |1 is obsolete|| --- Comment #24 from Andrew Fuerste-Henry --- Created attachment 105120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105120&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105117|0 |1 is obsolete|| --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 105122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105122&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105116|0 |1 is obsolete|| --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 105121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105121&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105113|0 |1 is obsolete|| --- Comment #22 from Andrew Fuerste-Henry --- Created attachment 105118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105118&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105114|0 |1 is obsolete|| --- Comment #23 from Andrew Fuerste-Henry --- Created attachment 105119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105119&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #19 from Kyle M Hall --- Created attachment 105115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105115&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #20 from Kyle M Hall --- Created attachment 105116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105116&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #21 from Kyle M Hall --- Created attachment 105117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105117&action=edit Bug 25534: Add reason to pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #18 from Kyle M Hall --- Created attachment 105114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105114&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Attachment #105108|0 |1 is obsolete|| Attachment #105109|0 |1 is obsolete|| Attachment #105110|0 |1 is obsolete|| Attachment #105111|0 |1 is obsolete|| Attachment #105112|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 105113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105113&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #13 from Kyle M Hall --- Created attachment 105109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105109&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', [% hold.cancellation_reason %], 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #14 from Kyle M Hall --- Created attachment 105110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105110&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #16 from Kyle M Hall --- Created attachment 105112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105112&action=edit Bug 25534: Add reason to pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #15 from Kyle M Hall --- Created attachment 105111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105111&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Attachment #105077|0 |1 is obsolete|| Attachment #105078|0 |1 is obsolete|| Attachment #105079|0 |1 is obsolete|| Attachment #105105|0 |1 is obsolete|| Attachment #105106|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 105108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105108&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #11 from Kyle M Hall --- Created attachment 105106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105106&action=edit Bug 25534: Add reason to pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #10 from Kyle M Hall --- Created attachment 105105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105105&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #9 from Kyle M Hall --- (In reply to Andrew Fuerste-Henry from comment #7) > On request.pl, the notice doesn't send if you cancel the hold using the big > red X button. This is the more obvious way to cancel a hold, so if it > doesn't send a notice then folks are going to get confused. Will fix. > Additionally, I've got "<>" in my notice and > it's putting in the authorised value code rather than the description, which > is no good. I should have specified a TT sample notice in the test plan. Will fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #8 from Andrew Fuerste-Henry --- Also need to account for cancelation via pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||and...@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- On request.pl, the notice doesn't send if you cancel the hold using the big red X button. This is the more obvious way to cancel a hold, so if it doesn't send a notice then folks are going to get confused. Additionally, I've got "<>" in my notice and it's putting in the authorised value code rather than the description, which is no good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #6 from Kyle M Hall --- Created attachment 105079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105079&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Attachment #105034|0 |1 is obsolete|| Attachment #105035|0 |1 is obsolete|| Attachment #105036|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 105077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105077&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #5 from Kyle M Hall --- Created attachment 105078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105078&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #2 from Kyle M Hall --- Created attachment 105035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105035&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold, not the reason pulldown appears. 8) Select a reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete you authorised values, not the feature is disabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #3 from Kyle M Hall --- Created attachment 105036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105036&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #1 from Kyle M Hall --- Created attachment 105034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105034&action=edit Bug 25534: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
