[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #42 from Martin Renvoize --- All works in testing for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #154453|0 |1 is obsolete|| --- Comment #41 from Martin Renvoize --- Created attachment 154455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154455&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #40 from Martin Renvoize --- Good catch, I've fixed that inline in the latest patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #154427|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 154453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154453&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672
--- Comment #38 from David Cook ---
Comment on attachment 154427
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154427
Bug 25672: Convert to restricting to listed repositories only
Review of attachment 154427:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25672&attachment=154427)
-
::: plugins/plugins-upload.pl
@@ +48,5 @@
> +$template->param( plugins_restricted => $plugins_restricted );
> +}
> +
> +# Exit early if uploads are not enabled
> +if ( !$ ) {
You've got a little typo here with the variable name.
But I'm not sure how this would work with the current implementation of
"plugins_restricted"?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153925|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #37 from Martin Renvoize --- Created attachment 154427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154427&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153827|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 154426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154426&action=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload is disabled, also prevent plugin browser uninstall. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153826|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 154425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154425&action=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153825|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 154424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154424&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153824|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 154423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154423&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload 7) Install a plugin from the CLI using koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" 8) Note that the Uninstall option for the plugin does not appear 9) Enable Koha plugin git repos and search for "coverflow" 10) Note that you can find the plugin but you cannot install it 11) Change enable_plugin_browser_upload back to 1 and "restart_all" 12) Note that you can not upload plugins, uninstall plugins, and install plugins from Git repos Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #32 from Martin Renvoize --- Some work towards what I was suggesting.. let me know what you think.. it's all a bit crude, but until we get some more of the Plugins foundations solid I think it may be the middle ground we can take. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #31 from Martin Renvoize --- Created attachment 153925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153925&action=edit Bug 25672: WIP - Convert to restricting to repo only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #30 from Martin Renvoize --- Mind if I amend this from 'enable_plugin_browser_upload' to 'restrict_to_plugin_repos'. My thinking is, instead of a simple on/off switch for uploads we set it to only allow uploads from those repositories listed in plugin_repos. Then if none are listed we disable upload entirely, if some are listed the search and install button works nicely or you can just not restrict and get any uploads. I think we could fairly trivially achieve this be looking at the uploadlocation parameter and checking it's content against the organisation part of the plug_repos config variable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34348 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34347 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #29 from David Cook --- Due to the amount of time that's passed, I'm resetting this one to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #28 from David Cook --- Created attachment 153827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153827&action=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload is disabled, also prevent plugin browser uninstall. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #107174|0 |1 is obsolete|| --- Comment #27 from David Cook --- Created attachment 153826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153826&action=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #107173|0 |1 is obsolete|| --- Comment #26 from David Cook --- Created attachment 153825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153825&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #107172|0 |1 is obsolete|| --- Comment #25 from David Cook --- Created attachment 153824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153824&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload 7) Install a plugin from the CLI using koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" 8) Note that the Uninstall option for the plugin does not appear 9) Enable Koha plugin git repos and search for "coverflow" 10) Note that you can find the plugin but you cannot install it 11) Change enable_plugin_browser_upload back to 1 and "restart_all" 12) Note that you can not upload plugins, uninstall plugins, and install plugins from Git repos Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #24 from David Cook --- (In reply to Martin Renvoize from comment #16) > Ah, if that was your intentention, I don't believe it worked. I'm sure I > tested it during QA and as expected, it failed at the plugin upload stage so > I disabled the button as a follow-up. Hmm, maybe this needs a minor revisit > then to clarify the case. I've changed my mind on this one. I agree with your QA follow-up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #23 from David Cook --- This one has been in the back of my mind for a long time, and I thought it was about time it was revisited. (In reply to Martin Renvoize from comment #17) > (In reply to Jonathan Druart from comment #15) > > We cannot upload but uninstall, is that ok? > > Good catch, we should probably disallow that too here. I agree about preventing uninstall as well. I'll add a patch for that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28499 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org --- Comment #22 from David Cook --- (In reply to Joonas Kylmälä from comment #21) > David, any updates on this? :) Ooops. Missed the email notification. While I still have an interest in plugins, we just don't use them enough to justify me working on them during my job hours. And outside my job I have so few hours available and those I'm putting towards authentication/Mojolicious controller things. So I'll abdicate as assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #21 from Joonas Kylmälä --- David, any updates on this? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #20 from David Cook --- (In reply to Martin Renvoize from comment #16) > Ah, if that was your intentention, I don't believe it worked. I'm sure I > tested it during QA and as expected, it failed at the plugin upload stage so > I disabled the button as a follow-up. Hmm, maybe this needs a minor revisit > then to clarify the case. That's good to know! I thought that I'd tested it, but I was working pretty fast and furious at one stage. I'll have to review it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #19 from David Cook --- (In reply to Jonathan Druart from comment #15) > We cannot upload but uninstall, is that ok? That's a good question. I was thinking that it was OK for them to uninstall them, but I suppose that could be annoying for vendors/administrators... But then plugins installed via Github should be able to be deleted. We don't want to remove the "uninstall" option for all plugins just because we're not letting them upload plugins via the browser. But then if we also block Github installs as well as browser upload/install, then that would be a bit of a moot point. (Although at some point I'm planning to create a plugin for managing plugins from external sources. Prosentient could have a plugin for downloading/installing Prosentient approved plugins, Bywater could have a plugin for downloading/installing Bywater approved plugins, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #18 from Jonathan Druart --- Removing from the PQA queue regarding the last comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #17 from Martin Renvoize --- (In reply to Jonathan Druart from comment #15) > We cannot upload but uninstall, is that ok? Good catch, we should probably disallow that too here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #16 from Martin Renvoize --- (In reply to David Cook from comment #14) > (In reply to Martin Renvoize from comment #13) > > Oops. forgot to attach my QA follow-up first time around.. it just hides the > > install button if you happen to have your system configured for no uploads > > but still allow searching for plugins via the UI. > > Firstly, thanks so much for QAing this, Martin! Really appreciated! > > Secondly, that's an interesting follow-up! > > I actually intended to let people install plugins from configured Git repos > but just disable plugin file upload via their local browser. Ah, if that was your intentention, I don't believe it worked. I'm sure I tested it during QA and as expected, it failed at the plugin upload stage so I disabled the button as a follow-up. Hmm, maybe this needs a minor revisit then to clarify the case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- We cannot upload but uninstall, is that ok? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #14 from David Cook --- (In reply to Martin Renvoize from comment #13) > Oops. forgot to attach my QA follow-up first time around.. it just hides the > install button if you happen to have your system configured for no uploads > but still allow searching for plugins via the UI. Firstly, thanks so much for QAing this, Martin! Really appreciated! Secondly, that's an interesting follow-up! I actually intended to let people install plugins from configured Git repos but just disable plugin file upload via their local browser. If I read your patch correctly, they wouldn't be able to do that with the follow-up, right? I don't mind either way, but I wonder if people should be able to search Git repos but not upload files via the browser? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #8 from David Cook --- (In reply to Fridolin SOMERS from comment #7) > I like this. > > We at biblibre have our CLI script one can find there : > https://git.biblibre.com/biblibre/tools/src/branch/master/koha/plugin.sh > That's cool! You should check out Bug 25671 where I'm writing a CLI tool for Koha. It's actually mostly done I think but I haven't uploaded the code yet, and I've had too many other tasks lately taking my attention. > Note that you must flush memcached then reload starman : reload config and > then recompile perl Mmm I forgot about that. I haven't had to that in my dev environment, but I think Starman might auto redeploy in dev...I should keep that in mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #12 from Martin Renvoize --- Created attachment 107174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107174&action=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #13 from Martin Renvoize --- Oops. forgot to attach my QA follow-up first time around.. it just hides the install button if you happen to have your system configured for no uploads but still allow searching for plugins via the UI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #106673|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 107172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107172&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #106674|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 107173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107173&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- Works well and adds to plugin system security.. no regressions found, passes the QA scripts and no obvious code issues. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #7 from Fridolin SOMERS --- I like this. We at biblibre have our CLI script one can find there : https://git.biblibre.com/biblibre/tools/src/branch/master/koha/plugin.sh Note that you must flush memcached then reload starman : reload config and then recompile perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Nicolas Legrand changed: What|Removed |Added Attachment #106651|0 |1 is obsolete|| --- Comment #5 from Nicolas Legrand --- Created attachment 106673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106673&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Nicolas Legrand changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Nicolas Legrand changed: What|Removed |Added Attachment #106671|0 |1 is obsolete|| --- Comment #6 from Nicolas Legrand --- Created attachment 106674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106674&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #4 from David Cook --- Created attachment 106671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106671&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #3 from David Cook --- (In reply to Kyle M Hall from comment #2) > Looks good, but the default should be to allow plugin uploads to keep in > line with current behavior. Agreed. I was thinking about that late last night and early this morning. While enable_plugins is 0 by default, all the in-Koha documentation says they just need to change it to enable_plugins 1. If they did that, and enable_plugin_browser_upload is 0, they won't even know they need to enable it. So I'll do a follow-up to enable it by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Kyle M Hall --- Looks good, but the default should be to allow plugin uploads to keep in line with current behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #1 from David Cook --- Created attachment 106651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106651&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23975 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Summary|Administrators should be|Administrators should be |able to disable client-side |able to disable client-side |and enable server-side |plugin upload |plugin management | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
