[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106625|0   |1
is obsolete||

--- Comment #13 from Owen Leonard  ---
Created attachment 106632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106632=edit
Bug 25709: Rename systempreference to NotesToHide

To test:
1 - Apply patch and updatedatabase
2 - git grep NotesBlacklist
3 - Note all remaining occurrences are translations, db updates, and release
notes
4 - Add a field (e.g. '520' ) to the NotesToHide systempreference
5 - View a record with a 520 field on the opac
6 - Confirm the field does not show in the 'Title notes' tab

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106601|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 106625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106625=edit
Bug 25709: Rename systempreference to NotesToHide

To test:
1 - Apply patch and updatedatabase
2 - git grep NotesBlacklist
3 - Note all remaining occurrences are translations, db updates, and release
notes
4 - Add a field (e.g. '520' ) to the NotesToHide systempreference
5 - View a record with a 520 field on the opac
6 - Confirm the field does not show in the 'Title notes' tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

--- Comment #11 from Julian Maurice  ---
(In reply to Nick Clemens from comment #10)
> Renamed to OpacHiddenNotes (like OpacHiddenItems)

Is this only for OPAC ? Syspref description mentions staff interface too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

--- Comment #10 from Nick Clemens  ---
Removed old update and release note changes

Renamed to OpacHiddenNotes (like OpacHiddenItems)

There is an atomic update to change existing installs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Nick Clemens  changed:

   What|Removed |Added

 Attachment #105702|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 106601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106601=edit
Bug 25709: Rename systemprefrence to OpacHiddenNotes

To test:
1 - Apply patch and updatedatabase
2 - git grep NotesBlacklist
3 - Note all remaining occurrences are translations, db updates, and release
notes
4 - Add a field (e.g. '520' ) to the OpacHiddenNotes systempreference
5 - View a record with a 520 field on the opac
6 - Confirm the field does not show in the 'Title notes' tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

--- Comment #8 from Katrin Fischer  ---
This has a different purpose than the frameworks visibility - we use it to hide
notes that also appear in the normal view so they are not doubled up. By
default  all 5xx display in the description tab, but some can be in the XSLT
too. So I'd like to keep the functionality with a new name :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #7 from David Cook  ---
Note that this patch doesn't actually rename the system preference. The
updatedatabase.pl change is for version 3.12. It needs an UPDATE statement for
the present.

I also agree with Katrin. I don't think that NotesDenylist is very intuitive.
Perhaps NotesExcludeList or HideNotesList. (I don't think we can use
OpacNotesToHide since NotesBlacklist currently works for both the Intranet and
OPAC I believe?)

I also agree that rewriting release notes doesn't make sense. It would be
better to just say that we're renaming it now.

Alternatively, we could also deprecate this system preference, since the
framework visibility is working better now, although perhaps it's not quite
comprehensive enough yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Julian Maurice  changed:

   What|Removed |Added

Summary|Rename systempreference to  |Rename systempreference
   |NotesDenylist   |from NotesBlacklist to
   ||NotesDenylist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Julian Maurice  ---
Changing status to Failed QA as there are things to fix (comment 4)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/