[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Lucas Gass changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.04 |20.11.00, 20.05.04, released in||19.11.10 --- Comment #10 from Aleisha Amohia --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Katrin Fischer changed: What|Removed |Added Attachment #107860|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 108947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108947=edit Bug 25791: Remove win.print() Test plan: 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Click 'Print receipt and end session' 5) Notice two print dialog boxes right on top of each other 6) Apply patch 7) Repeat steps 1 - 4 8) Should only get a single print dialog. 9) Test in FF/Chrome and make sure behavior is consistent Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 ByWater Sandboxes changed: What|Removed |Added Attachment #106941|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 107860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107860=edit Bug 25791: Remove win.print() Test plan: 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Click 'Print receipt and end session' 5) Notice two print dialog boxes right on top of each other 6) Apply patch 7) Repeat steps 1 - 4 8) Should only get a single print dialog. 9) Test in FF/Chrome and make sure behavior is consistent Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 --- Comment #5 from David Cook --- I've made a note to check this out later. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 --- Comment #4 from Lucas Gass --- Created attachment 106941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106941=edit Bug 25791: Remove win.print() Test plan: 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Click 'Print receipt and end session' 5) Notice two print dialog boxes right on top of each other 6) Apply patch 7) Repeat steps 1 - 4 8) Should only get a single print dialog. 9) Test in FF/Chrome and make sure behavior is consistent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791
--- Comment #3 from Lucas Gass ---
I believe this is because of some duplication of code in sco-main.tt:
var win = window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[%
borrowernumber | html %]print=qslip");
win.print();
If we use window.open, which opens a print dialog then we do not need to also
have win.print()
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 --- Comment #2 from Lucas Gass --- Hey David, This only happens to me in FF. Chrome seems to work just fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- What browser are you using and on which OS? I don't think that I've experienced this, but happy to re-test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25597 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Lucas Gass changed: What|Removed |Added Depends on|25597 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal Depends on||25597, 21565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 [Bug 21565] SCO checkout confirm should be modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
