[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #23 from Lucas Gass  ---
enhancement will not be backported to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #22 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #21 from Marcel de Rooy  ---
> > We will be using something like https://id.rijksmuseum.nl/3012345
> > Our institutional PID resolver knows (as a partial or meta resolver) how to
> > pass library PIDs to the library PID resolver. Which would use opac-detail
> > for HTML in case of a biblio or item.
> 
> Could you explain this part a bit more? Is the idea that you'll mint
> institution level PIDs (like https://id.rijksmuseum.nl/3012345) and those
> will resolve to Koha PIDs/URLs?

Our discussion goes out of scope here? :)

What we currently do: The main resolver (WIP) passes all 3xxx to the library
resolver. That one knows how to resolve them depending on accept header.
Similarly, we do not have one minter. The library pid generator mints PIDs in
the id.rijksmuseum.nl domain but only starting with a 3 as a hidden designator
for library domain.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #20 from David Cook  ---
(In reply to Marcel de Rooy from comment #19)
> Yes, the landing page of the item persistent identifier (URL) is not that
> important, but I do want to be able to dereference it. Including an HTML
> representation when that would be the result of content negotiation. But
> surely the main thing is a unique resource identifier in the form of a URL. 
> 

Cool. That sounds good to me.

> We will be using something like https://id.rijksmuseum.nl/3012345
> Our institutional PID resolver knows (as a partial or meta resolver) how to
> pass library PIDs to the library PID resolver. Which would use opac-detail
> for HTML in case of a biblio or item.

Could you explain this part a bit more? Is the idea that you'll mint
institution level PIDs (like https://id.rijksmuseum.nl/3012345) and those will
resolve to Koha PIDs/URLs?

That would be cool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #19 from Marcel de Rooy  ---
(In reply to David Cook from comment #18)
> RDF subjects was my first thought, although reading more about RPC and REST
> APIs and thinking that having a canonical item URL (or PID) could be useful
> for a REST API (better to return a URL rather than an itemnumber for
> instance).
> I was wondering if you had a particular use case that you plan to use this
> for in the short term is all. Like is the HTML representation important in
> your use case? Or is it just to uniquely identify the resource (say for a
> RDF subject or REST API)?

Yes, the landing page of the item persistent identifier (URL) is not that
important, but I do want to be able to dereference it. Including an HTML
representation when that would be the result of content negotiation. But surely
the main thing is a unique resource identifier in the form of a URL. 

We will be using something like https://id.rijksmuseum.nl/3012345
Our institutional PID resolver knows (as a partial or meta resolver) how to
pass library PIDs to the library PID resolver. Which would use opac-detail for
HTML in case of a biblio or item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #18 from David Cook  ---
(In reply to Marcel de Rooy from comment #17)
> See also comment1. This is a first attempt to quickly have an item landing
> page (hacking just a few lines). And yes, the item persistent identifier to
> be used in RDF subjects should be resolved by the opac-detail item page when
> content negotiation comes down to HTML.

I don't see a use case in Comment 1. 

RDF subjects was my first thought, although reading more about RPC and REST
APIs and thinking that having a canonical item URL (or PID) could be useful for
a REST API (better to return a URL rather than an itemnumber for instance).

I was wondering if you had a particular use case that you plan to use this for
in the short term is all. Like is the HTML representation important in your use
case? Or is it just to uniquely identify the resource (say for a RDF subject or
REST API)?

I think it's a great idea, but I'm just curious about the implementation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #17 from Marcel de Rooy  ---
(In reply to David Cook from comment #16)
> I like the idea of having a web page to show for an item (whether it's for a
> persistent identifier or just for doing manual updates to an item without
> needing a bib number).
> 
> However, I can understand Katrin's concerns. It seems like we're
> hacking/shoehorning the opac-detail.pl page to serve a purpose it's not
> meant to serve.
> 
> What's the practical use case for this? Is this to be used for a RDF
> subject? Or some other purpose?

Hi David,
See also comment1. This is a first attempt to quickly have an item landing page
(hacking just a few lines). And yes, the item persistent identifier to be used
in RDF subjects should be resolved by the opac-detail item page when content
negotiation comes down to HTML.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #16 from David Cook  ---
I like the idea of having a web page to show for an item (whether it's for a
persistent identifier or just for doing manual updates to an item without
needing a bib number).

However, I can understand Katrin's concerns. It seems like we're
hacking/shoehorning the opac-detail.pl page to serve a purpose it's not meant
to serve.

What's the practical use case for this? Is this to be used for a RDF subject?
Or some other purpose?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24544

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #15 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #14)

Thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106323|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 106368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106368=edit
Bug 25801: (follow-up) Fix indentation level of else block

Just fixing the indentation here with a substitution cmd.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106322|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 106367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106367=edit
Bug 25801: (follow-up) Add Show all items-link on opac-detail

As requested by Katrin in QA, it might be helpful to provide a
link to return to the regular view with all items.

The information about acquisition and holds refers to all items,
so I moved it inside the else branch of this block.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106321|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 106366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106366=edit
Bug 25801: Add itemnumber parameter to opac-detail

Note: The GetItemsInfo call is now suboptimal. Leaving it as-is
for now in the hope that item refactoring picks it up ;)

Test plan:
Test opac-detail via biblionumber (regular use).
Test opac-detail by passing an itemnumber in the URL:
/cgi-bin/koha/opac-detail?itemnumber=999

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #11 from Marcel de Rooy  ---
Created attachment 106323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106323=edit
Bug 25801: (follow-up) Fix indentation level of else block

Just fixing the indentation here with a substitution cmd.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #10 from Marcel de Rooy  ---
Created attachment 106322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106322=edit
Bug 25801: (follow-up) Add Show all items-link on opac-detail

As requested by Katrin in QA, it might be helpful to provide a
link to return to the regular view with all items.

The information about acquisition and holds refers to all items,
so I moved it inside the else branch of this block.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch
 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #106004|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 106321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106321=edit
Bug 25801: Add itemnumber parameter to opac-detail

Note: The GetItemsInfo call is now suboptimal. Leaving it as-is
for now in the hope that item refactoring picks it up ;)

Test plan:
Test opac-detail via biblionumber (regular use).
Test opac-detail by passing an itemnumber in the URL:
/cgi-bin/koha/opac-detail?itemnumber=999

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #8 from Katrin Fischer  ---
Hi Marcel, I think a link to he 'full' display would really make me feel more
confident about this. And we could make to so it can be easily hidden if
needed.
Thx for taking my comments into consideration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #7 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #4)
> The thing that is irritating for me is the hiding of the other items with no
> way to make them visible (like a link to switch to the 'full holdings' or
> something like that?) Another option could be highlighting the item in the
> URL param visually in the table instead of hiding all others.

I would prefer to list the item only. But we could add a link to go back to the
normal view? Show all items?

> Also the test plan was lacking a bit, I guessed:
> /cgi-bin/koha/opac-detail.pl?itemnumber=605
> 
> That works and it will ignore the biblionumber, if also supplied?
OK I will adjust the test plan.

Thanks for your feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #6 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #4)
> This works well, but I am wondering about the use case - can you share your
> idea behind this?

The idea is that if I would have an item persistent identifier for say item 345
(belonging to biblio 234) like e.g. mylibrary.com/item/345, how will this be
resolved in OPAC? We have no landing page for items. If I resolve to biblio
234, I see all items.
This is not meant to be the perfect solution but a first attempt to have a
landing page for items.
See also bug 24544 (still in progress).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
Failing QA as a way to alert Marcel of the questions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #4 from Katrin Fischer  ---
This works well, but I am wondering about the use case - can you share your
idea behind this?

The thing that is irritating for me is the hiding of the other items with no
way to make them visible (like a link to switch to the 'full holdings' or
something like that?) Another option could be highlighting the item in the URL
param visually in the table instead of hiding all others.

Also the test plan was lacking a bit, I guessed:
/cgi-bin/koha/opac-detail.pl?itemnumber=605

That works and it will ignore the biblionumber, if also supplied?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #3 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #2)
> Created attachment 106004 [details] [review]
> Bug 25801: Add itemnumber parameter to opac-detail
> 
> Note: The GetItemsInfo call is now suboptimal. Leaving it as-is
> for now in the hope that item refactoring picks it up ;)
> 
> Test plan:
> Test opac-detail via biblionumber (regular use).
> Test opac-detail by passing an itemnumber in the URL.
> 
> Signed-off-by: Marcel de Rooy 
> 
> Signed-off-by: Owen Leonard 

Thx Owen. So fast ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106003|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 106004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106004=edit
Bug 25801: Add itemnumber parameter to opac-detail

Note: The GetItemsInfo call is now suboptimal. Leaving it as-is
for now in the hope that item refactoring picks it up ;)

Test plan:
Test opac-detail via biblionumber (regular use).
Test opac-detail by passing an itemnumber in the URL.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #1 from Marcel de Rooy  ---
Created attachment 106003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106003=edit
Bug 25801: Add itemnumber parameter to opac-detail

Note: The GetItemsInfo call is now suboptimal. Leaving it as-is
for now in the hope that item refactoring picks it up ;)

Test plan:
Test opac-detail via biblionumber (regular use).
Test opac-detail by passing an itemnumber in the URL.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/