[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #16 from Caroline Cyr La Rose --- I don't think there is anything to add/edit in the Koha manual for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Needs documenting CC||fridolin.som...@biblibre.co ||m --- Comment #15 from Fridolin Somers --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 --- Comment #14 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 --- Comment #13 from Katrin Fischer --- Maybe I am going a bit far today, but not as far as asking you to rename the pref at least :) I mostly meant the code comments as it also can get confusing to new devs with our all-over mix of things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 --- Comment #12 from Matthias Meusburger --- Hi Katrin, I agree with you about having consistent terminology. However, NotifyBorrowerDeparture is a pre-existing system preference and is used in other places in Koha. Renaming it to NotifyPatronDeparture should be done in a separate BZ in my opinion. As for Debarred/Restricted, it is only code comments and a log line, it is never displayed to the user. I tried to be consistent with the Patron object method, which is $patron->is_debarred (and not $patron->is_restricted). That being said, I would happily change code comments (borrower -> patron, debarred -> restricted) and the log line if you think it's better this way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Le Gac changed: What|Removed |Added CC|matthias.le-...@inlibro.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 --- Comment #11 from Katrin Fischer --- I'll push this, but I'd love a follow-up doing some terminology clean-up: * Debarred = Restricted * Borrower = Patron I know we have tons of each, but we decided to move one direction, so let's not move backwards :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- All working as described, code is tidy, covered by tests and passes QA scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813
Martin Renvoize changed:
What|Removed |Added
Attachment #160794|0 |1
is obsolete||
--- Comment #9 from Martin Renvoize ---
Created attachment 161084
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161084&action=edit
Bug 25813: Enhance patron expiration in SIP display
Currently, the patron information returned by SIP only shows
"PATRON EXPIRED" when the patron card has expired.
This patch makes the display more consistant with the Opac display
and also complies with the NotifyBorrowerDeparture system preference.
Test plan:
- apply the patch
- set NotifyBorrowerDeparture to 0
- check that nothing is ever displayed about the card expiration
- set NotifyBorrowerDeparture to a value greater than 0
- check that the following message will be displayed for a card that will
expire within NotifyBorrowerDeparture days:
"Your card will expire on {correctly formatted date}"
- check that the following message will be displayed for a card that has
expired:
"Your account has expired as of {correctly formatted date}"
You can use src/C4/SIP/interactive_patron_dump.pl for easier testing.
Signed-off-by: Lucas Gass
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813
Lucas Gass changed:
What|Removed |Added
Attachment #160730|0 |1
is obsolete||
--- Comment #8 from Lucas Gass ---
Created attachment 160794
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160794&action=edit
Bug 25813: Enhance patron expiration in SIP display
Currently, the patron information returned by SIP only shows
"PATRON EXPIRED" when the patron card has expired.
This patch makes the display more consistant with the Opac display
and also complies with the NotifyBorrowerDeparture system preference.
Test plan:
- apply the patch
- set NotifyBorrowerDeparture to 0
- check that nothing is ever displayed about the card expiration
- set NotifyBorrowerDeparture to a value greater than 0
- check that the following message will be displayed for a card that will
expire within NotifyBorrowerDeparture days:
"Your card will expire on {correctly formatted date}"
- check that the following message will be displayed for a card that has
expired:
"Your account has expired as of {correctly formatted date}"
You can use src/C4/SIP/interactive_patron_dump.pl for easier testing.
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 --- Comment #7 from Lucas Gass --- Works well, using sip_cli_emulator.pl to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Meusburger changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Matthias Meusburger --- The patch has been rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813
Matthias Meusburger changed:
What|Removed |Added
Attachment #154697|0 |1
is obsolete||
--- Comment #5 from Matthias Meusburger ---
Created attachment 160730
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160730&action=edit
Bug 25813: Enhance patron expiration in SIP display
Currently, the patron information returned by SIP only shows
"PATRON EXPIRED" when the patron card has expired.
This patch makes the display more consistant with the Opac display
and also complies with the NotifyBorrowerDeparture system preference.
Test plan:
- apply the patch
- set NotifyBorrowerDeparture to 0
- check that nothing is ever displayed about the card expiration
- set NotifyBorrowerDeparture to a value greater than 0
- check that the following message will be displayed for a card that will
expire within NotifyBorrowerDeparture days:
"Your card will expire on {correctly formatted date}"
- check that the following message will be displayed for a card that has
expired:
"Your account has expired as of {correctly formatted date}"
You can use src/C4/SIP/interactive_patron_dump.pl for easier testing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Matthias Le Gac --- I can't apply le patch Applying: Bug 25813: Enhance patron expiration in SIP display Using index info to reconstruct a base tree... M C4/SIP/ILS/Patron.pm M t/db_dependent/SIP/Patron.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/SIP/Patron.t Auto-merging C4/SIP/ILS/Patron.pm CONFLICT (content): Merge conflict in C4/SIP/ILS/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 25813: Enhance patron expiration in SIP display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Meusburger changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Matthias Meusburger --- The patch has been rebased, and unit tests have been added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813
Matthias Meusburger changed:
What|Removed |Added
Attachment #106057|0 |1
is obsolete||
--- Comment #2 from Matthias Meusburger ---
Created attachment 154697
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154697&action=edit
Bug 25813: Enhance patron expiration in SIP display
Currently, the patron information returned by SIP only shows
"PATRON EXPIRED" when the patron card has expired.
This patch makes the display more consistant with the Opac display
and also complies with the NotifyBorrowerDeparture system preference.
Test plan:
- apply the patch
- set NotifyBorrowerDeparture to 0
- check that nothing is ever displayed about the card expiration
- set NotifyBorrowerDeparture to a value greater than 0
- check that the following message will be displayed for a card that will
expire within NotifyBorrowerDeparture days:
"Your card will expire on {correctly formatted date}"
- check that the following message will be displayed for a card that has
expired:
"Your account has expired as of {correctly formatted date}"
You can use src/C4/SIP/interactive_patron_dump.pl for easier testing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813
--- Comment #1 from Matthias Meusburger ---
Created attachment 106057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106057&action=edit
Bug 25813: Enhance patron expiration in SIP display
Currently, the patron information returned by SIP only shows
"PATRON EXPIRED" when the patron card has expired.
This patch makes the display more consistant with the Opac display
and also complies with the NotifyBorrowerDeparture system preference.
Test plan:
- apply the patch
- set NotifyBorrowerDeparture to 0
- check that nothing is ever displayed about the card expiration
- set NotifyBorrowerDeparture to a value greater than 0
- check that the following message will be displayed for a card that will
expire within NotifyBorrowerDeparture days:
"Your card will expire on {correctly formatted date}"
- check that the following message will be displayed for a card that has
expired:
"Your account has expired as of {correctly formatted date}"
You can use src/C4/SIP/interactive_patron_dump.pl for easier testing.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
