[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 --- Comment #11 from Kyle M Hall --- Created attachment 155593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155593=edit Bug 25815: (QA follow-up) Add system preference Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Fridolin Somers changed: What|Removed |Added Blocks||25812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 [Bug 25812] Fines can be displayed on SIP checkin/checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||k...@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- Issues raised by Nick all fixed and patch all works as expected here. QA scripts are happy, and we have Unit tests.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #133215|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 --- Comment #8 from Martin Renvoize --- Created attachment 133397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133397=edit Bug 25815: SIP Checkout: add more information on why the patron is blocked. Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. This patch adds more specific informations, with the following messages: - "Patron expired" - "Patron debarred" - "Patron has fines" (see system preference "noissuescharge") - "Patron blocked" (see system preference "OverduesBlockCirc") Test plan: - Try to do a SIP checkout with a patron that is in one of the above situations. - Check that the displayed message matches the patron's situation. Signed-off-by: Sonia Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Matthias Meusburger changed: What|Removed |Added Attachment #132652|0 |1 is obsolete|| --- Comment #7 from Matthias Meusburger --- Created attachment 133215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133215=edit updated patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 --- Comment #6 from Matthias Meusburger --- Thanks for your feedback, Nick. The following patch restores the correct order and adds unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 --- Comment #5 from Nick Clemens --- Also, charge ok order is debarred, expired, fines, blocked - you move expired first - we should be consistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Unit tests, please -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 sandbo...@biblibre.com changed: What|Removed |Added Attachment #106059|0 |1 is obsolete|| --- Comment #3 from sandbo...@biblibre.com --- Created attachment 132652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132652=edit Bug 25815: SIP Checkout: add more information on why the patron is blocked. Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. This patch adds more specific informations, with the following messages: - "Patron expired" - "Patron debarred" - "Patron has fines" (see system preference "noissuescharge") - "Patron blocked" (see system preference "OverduesBlockCirc") Test plan: - Try to do a SIP checkout with a patron that is in one of the above situations. - Check that the displayed message matches the patron's situation. Signed-off-by: Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Koha Team University Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@univ-lyon3.fr --- Comment #2 from Koha Team University Lyon 3 --- I tested on my kohadevbox, with the different cases and the SIP responses are the one expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Katrin Fischer changed: What|Removed |Added Summary|SIP Checkout: add more |SIP Checkout: add more |information on why the |information on why the |patron is blocked. |patron is blocked -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 --- Comment #1 from Matthias Meusburger --- Created attachment 106059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106059=edit Bug 25815: SIP Checkout: add more information on why the patron is blocked. Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. This patch adds more specific informations, with the following messages: - "Patron expired" - "Patron debarred" - "Patron has fines" (see system preference "noissuescharge") - "Patron blocked" (see system preference "OverduesBlockCirc") Test plan: - Try to do a SIP checkout with a patron that is in one of the above situations. - Check that the displayed message matches the patron's situation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
