[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 --- Comment #1 from Fridolin SOMERS --- Created attachment 106256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106256&action=edit Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Created attachment 106360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106360&action=edit Bug 25868 - Screenshots of behavour Hi Fridolin. This change now works as expected. However, if you do two transfers (one after the other for different items) the list of transfers shows: - the last transfer entered, and - the previous transfers show as "No title" and the link doesn't go anywhere See before and after screenshots. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 --- Comment #3 from Fridolin SOMERS --- (In reply to David Nind from comment #2) > Created attachment 106360 [details] > Bug 25868 - Screenshots of behavour > > Hi Fridolin. > > This change now works as expected. > > However, if you do two transfers (one after the other for different items) > the list of transfers shows: > - the last transfer entered, and > - the previous transfers show as "No title" and the link doesn't go anywhere > > See before and after screenshots. > > David Thanks a lot for testing, i'got a fix ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS changed: What|Removed |Added Attachment #106256|0 |1 is obsolete|| --- Comment #4 from Fridolin SOMERS --- Created attachment 106380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106380&action=edit Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind changed: What|Removed |Added Attachment #106380|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 106385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106385&action=edit Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfers 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 --- Comment #6 from Katrin Fischer --- Created attachment 106529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106529&action=edit Bug 25868: Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Attachment #106385|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 --- Comment #9 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/