[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 --- Comment #14 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Katrin Fischer changed: What|Removed |Added Attachment #112375|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 112430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112430=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Katrin Fischer changed: What|Removed |Added Attachment #112374|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 112429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112429=edit Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Attachment #112003|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 112374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112374=edit Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Attachment #112004|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 112375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112375=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 --- Comment #9 from Owen Leonard --- Created attachment 112004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112004=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Owen Leonard changed: What|Removed |Added Attachment #110447|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 112003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112003=edit Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #7 from Katrin Fischer --- Hi Owen, missing the first patch - git bz attach fail? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Owen Leonard changed: What|Removed |Added Attachment #110310|0 |1 is obsolete|| Attachment #110311|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 110447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110447=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #5 from Katrin Fischer --- Hi Owen, I am bit confused by the conflict - could you please take care of it and rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Attachment #106603|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 110310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110310=edit Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Attachment #106604|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 110311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110311=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 --- Comment #2 from Owen Leonard --- Created attachment 106604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106604=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 --- Comment #1 from Owen Leonard --- Created attachment 106603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106603=edit Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
