[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Anni Rajala changed: What|Removed |Added CC||anni.raj...@turku.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #99 from Katrin Fischer ---
(In reply to Kyle M Hall from comment #98)
> Until we find such time as to resurrect this, I just wanted to suggest that
> one could create one or more "SOMETYPE_NONOTICE" and wrap your notice in
> something like:
>
> [%- UNLESS reserves.cancellation_reason.match("NONOTICE") %]
>
> [%- END %]
>
> That cancelation notice type will end up being blank and thus won't get sent!
Thx for the workaround :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #98 from Kyle M Hall ---
Until we find such time as to resurrect this, I just wanted to suggest that one
could create one or more "SOMETYPE_NONOTICE" and wrap your notice in something
like:
[%- UNLESS reserves.cancellation_reason.match("NONOTICE") %]
[%- END %]
That cancelation notice type will end up being blank and thus won't get sent!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #97 from Katrin Fischer --- (In reply to Katrin Fischer from comment #96) > I tried testing this, but have run into 2 dead ends: > > * Manually added a HOLD_CANCELLATION notice > * Added email address to my patron, created a bunch of holds > * Verified the AV exists and has values > * Verified my patron has a primary email set > > 1) From the patron account > * Switch No to Yes for cancelling a hold > * Choose reason, leave notify patron checked > * Cancelled hold > * Hold was cancelled, but: No notice was created > > 2) Record detail page, holds tab: > * Click on "garbage can" - modal comes up without cancellation reason pull > down or notify option I'd love to see this moving. We initially wanted to fix it right away after introducing the feature... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #96 from Katrin Fischer --- I tried testing this, but have run into 2 dead ends: * Manually added a HOLD_CANCELLATION notice * Added email address to my patron, created a bunch of holds * Verified the AV exists and has values * Verified my patron has a primary email set 1) From the patron account * Switch No to Yes for cancelling a hold * Choose reason, leave notify patron checked * Cancelled hold * Hold was cancelled, but: No notice was created 2) Record detail page, holds tab: * Click on "garbage can" - modal comes up without cancellation reason pull down or notify option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #95 from Katrin Fischer --- Created attachment 141210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141210=edit Bug 26282: (QA follow-up) Fix typo recieve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer changed: What|Removed |Added QA Contact|tomasco...@gmail.com|katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #94 from Kyle M Hall --- Created attachment 138469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138469=edit Bug 26282: (QA follow-up) Remove invalid test A cancellation reason is not required, making this test invalid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122456|0 |1 is obsolete|| --- Comment #91 from Victor Grousset/tuxayo --- Created attachment 138418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138418=edit Bug 26282: Show reason only if notice exists Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122455|0 |1 is obsolete|| --- Comment #90 from Victor Grousset/tuxayo --- Created attachment 138417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138417=edit Bug 26282: (QA follow-up) Restore default notice Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Failed QA --- Comment #93 from Victor Grousset/tuxayo --- Happy birthday, here is a rebase ^o^ I compared the old and new patches to double check that I didn't change anything unknowingly. However failed QA because a test is failing and it's also failing when rebasing on an old(2021-08) master. So it's not from the rebase. #notmyjoblol root@kohadevbox:koha((e781542349...))$ prove t/db_dependent/Koha/Hold.t t/db_dependent/Koha/Hold.t .. 3/4 # Failed test 'GetPreparedLetter not called if notify_patron passed and no cancellation_reason passed' # at t/db_dependent/Koha/Hold.t line 290. # got: '1' # expected: '0' # Looks like you failed 1 test of 12. t/db_dependent/Koha/Hold.t .. 4/4 # Failed test 'cancel() tests' # at t/db_dependent/Koha/Hold.t line 297. # Looks like you failed 1 test of 4. t/db_dependent/Koha/Hold.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests Test Summary Report --- t/db_dependent/Koha/Hold.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=4, 10 wallclock secs ( 0.04 usr 0.00 sys + 7.23 cusr 1.52 csys = 8.79 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122453|0 |1 is obsolete|| --- Comment #88 from Victor Grousset/tuxayo --- Created attachment 138415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138415=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122450|0 |1 is obsolete|| --- Comment #82 from Victor Grousset/tuxayo --- Created attachment 138409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138409=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122550|0 |1 is obsolete|| --- Comment #92 from Victor Grousset/tuxayo --- Created attachment 138419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138419=edit Bug 26282: Update Holds to pull Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122448|0 |1 is obsolete|| --- Comment #80 from Victor Grousset/tuxayo --- Created attachment 138407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138407=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122452|0 |1 is obsolete|| --- Comment #87 from Victor Grousset/tuxayo --- Created attachment 138414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138414=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138408|0 |1 is obsolete|| --- Comment #84 from Victor Grousset/tuxayo --- Created attachment 138411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138411=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138409|0 |1 is obsolete|| --- Comment #85 from Victor Grousset/tuxayo --- Created attachment 138412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138412=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122451|0 |1 is obsolete|| --- Comment #86 from Victor Grousset/tuxayo --- Created attachment 138413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138413=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138407|0 |1 is obsolete|| --- Comment #83 from Victor Grousset/tuxayo --- Created attachment 138410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138410=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122449|0 |1 is obsolete|| --- Comment #81 from Victor Grousset/tuxayo --- Created attachment 138408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138408=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122454|0 |1 is obsolete|| --- Comment #89 from Victor Grousset/tuxayo --- Created attachment 138416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138416=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_20_11_candidate |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Signed Off |Patch doesn't apply --- Comment #79 from Joonas Kylmälä --- Doesn't apply anymore :| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #78 from Kyle M Hall --- Created attachment 122550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122550=edit Bug 26282: Update Holds to pull -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #77 from Kyle M Hall --- Created attachment 122456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122456=edit Bug 26282: Show reason only if notice exists -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #76 from Kyle M Hall --- Created attachment 122455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122455=edit Bug 26282: (QA follow-up) Restore default notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #75 from Kyle M Hall --- Created attachment 122454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122454=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #74 from Kyle M Hall --- Created attachment 122453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122453=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #73 from Kyle M Hall --- Created attachment 122452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122452=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #72 from Kyle M Hall --- Created attachment 122451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122451=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #71 from Kyle M Hall --- Created attachment 122450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122450=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #70 from Kyle M Hall --- Created attachment 122449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122449=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What|Removed |Added Attachment #115193|0 |1 is obsolete|| Attachment #115194|0 |1 is obsolete|| Attachment #115195|0 |1 is obsolete|| Attachment #115196|0 |1 is obsolete|| Attachment #115197|0 |1 is obsolete|| Attachment #115198|0 |1 is obsolete|| Attachment #115199|0 |1 is obsolete|| Attachment #115200|0 |1 is obsolete|| Attachment #115201|0 |1 is obsolete|| --- Comment #69 from Kyle M Hall --- Created attachment 122448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122448=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #68 from Jonathan Druart --- (In reply to Kyle M Hall from comment #67) > (In reply to Martin Renvoize from comment #64) > > Work to date uploaded.. still needs more followups but I wanted to make sure > > BZ was in sync with my gitlab before stepping away again > > What is still on the todo list? I guess it's coming from comments 51-53. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #67 from Kyle M Hall --- (In reply to Martin Renvoize from comment #64) > Work to date uploaded.. still needs more followups but I wanted to make sure > BZ was in sync with my gitlab before stepping away again What is still on the todo list? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #66 from Jonathan Druart --- Wasn't this a "have to" for 20.11.01?... Looks like we completely forgot about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #65 from Martin Renvoize --- Kyle.. do you think you might have a chance to get back to this.. I'm not sure I will any time soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #64 from Martin Renvoize --- Work to date uploaded.. still needs more followups but I wanted to make sure BZ was in sync with my gitlab before stepping away again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #63 from Martin Renvoize --- Created attachment 115201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115201=edit Bug 26282: Update pendingreserves to use buttons This patch updates circ/pendingreserves to use two buttons; "Cancel hold" and "Cancel hold and notify" for the pending reserves page. It will only display the notify option when a notice template exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114259|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 115200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115200=edit Bug 26282: (QA follow-up) Restore default notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114253|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 115199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115199=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114252|0 |1 is obsolete|| --- Comment #60 from Martin Renvoize --- Created attachment 115198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115198=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114251|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 115197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115197=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114250|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 115196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115196=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114249|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 115195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115195=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114248|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 115194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115194=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114247|0 |1 is obsolete|| --- Comment #55 from Martin Renvoize --- Created attachment 115193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115193=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #54 from Martin Renvoize --- Slowly working on this here: https://gitlab.com/mrenvoize/Koha/-/commits/bug_26282 It's slow going working through the various locations one can cancel a reservation from and updating the checkbox to optionally display/hide based on the existence of a notice template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Bug 26282 depends on bug 27103, which changed state. Bug 27103 Summary: Adding a hold cancellation reason should not always send a notice https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27103 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #53 from Jonathan Druart --- It's how it works right now with the feature. It's disabled if the letter does not exist. And yes, behaviours being disabled if the letter template does not exist is what we are doing in other areas (claims, out of the top of my head). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #52 from Martin Renvoize --- Good call.. seems I missed some bits from that final commit.. I'll dig them out tomorrow.. As for bit displaying the checkbox.. are there precidents for that elsewhere? I'm happy to do it, but am also keen to have consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114255|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114254|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Blocks||27262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #51 from Jonathan Druart --- (In reply to Martin Renvoize from comment #50) > OK, I don't think I'll manage to get to switching the checkbox > implementation to a double button one.. > > Perhaps we can do that in a distinct bug along with cleaning up some of the > forms. > > So.. I reckon this is read for SO/QA again The checkbox is displayed even if the letter template does not exist. Should not we hide it? Should not we insert the template for new installs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #50 from Martin Renvoize --- OK, I don't think I'll manage to get to switching the checkbox implementation to a double button one.. Perhaps we can do that in a distinct bug along with cleaning up some of the forms. So.. I reckon this is read for SO/QA again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #49 from Martin Renvoize --- Created attachment 114259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114259=edit Bug 26282: (QA follow-up) Restore default notice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |koha-b...@lists.koha-commun |.com|ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #48 from Martin Renvoize --- Two more followups to come.. one to restore the notices we nuked with bug 27103 and one to convert from a checkbox to a button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #47 from Martin Renvoize --- Created attachment 114255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114255=edit Checkbox aproach -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #46 from Martin Renvoize --- Created attachment 114254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114254=edit Button approach -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114030|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114034|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 114253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114253=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #44 from Martin Renvoize --- Created attachment 114252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114252=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114016|0 |1 is obsolete|| --- Comment #43 from Martin Renvoize --- Created attachment 114251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114251=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114015|0 |1 is obsolete|| --- Comment #42 from Martin Renvoize --- Created attachment 114250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114250=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #41 from Martin Renvoize --- Created attachment 114249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114249=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114032|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize --- Created attachment 114248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114248=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114031|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 114247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114247=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114015|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114033|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114016|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Depends on||27103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27103 [Bug 27103] Adding a hold cancellation reason should not always send a notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Depends on|12656, 25534| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Assignee|k...@bywatersolutions.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What|Removed |Added Attachment #114035|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #38 from Josef Moravec --- (In reply to Martin Renvoize from comment #37) > I think this final alternative is the best approach given the release > timing... > > If we all agree, I will happily transplant the other patches here to a new > bug for 20.11.01 and go back and update the release note text for the two > affected bugs now. I do agree thanks Martin and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #37 from Martin Renvoize --- I think this final alternative is the best approach given the release timing... If we all agree, I will happily transplant the other patches here to a new bug for 20.11.01 and go back and update the release note text for the two affected bugs now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #36 from Martin Renvoize --- Created attachment 114035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114035=edit Bug 26282: (ALTERNATIVE) Remove HOLD_CANCELLATION notice We are really close to release, and the 'proper' fix to make the sending of hold cancellation notices optional will introduce string changes. This patch takes the alternative approach of removing the default notice template there by disabling the feature for 20.11.00 release and giving us time to properly impliment a solution and re-instate the default notice template for the 20.11.01 release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #35 from Jonathan Druart --- Hi Josef, I was in a chat with Martin. We were actually thinking about removing the notice template HOLD_CANCELLATION from the DB, for 20.11.00. That will disable the feature and let people create the notice template if needed. Then we will implement the real fix properly for 20.11.01. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #34 from Josef Moravec --- Created attachment 114034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114034=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec changed: What|Removed |Added Attachment #114028|0 |1 is obsolete|| --- Comment #33 from Josef Moravec --- Created attachment 114033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114033=edit Bug 26282: Disable the checkbox if no reason selected On this bug report we want to explicitly tell the librarian than a notice will be generate if a cancellation reason is selected. If the new checkbox we have a situation if the checkbox is selected and no reason selected => no notice will be generated This patch is not the optimal solution but answers the original need, without string changes (today is release day...) and without too many modifications in the code. Additional follow-up bug report must be opened to deal properly with this specific use case. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec changed: What|Removed |Added Attachment #114013|0 |1 is obsolete|| --- Comment #32 from Josef Moravec --- Created attachment 114032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114032=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec changed: What|Removed |Added Attachment #114012|0 |1 is obsolete|| --- Comment #31 from Josef Moravec --- Created attachment 114031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114031=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec changed: What|Removed |Added Attachment #114011|0 |1 is obsolete|| --- Comment #30 from Josef Moravec --- Created attachment 114030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114030=edit Bug 26282: Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
