[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506
Aleisha Amohia changed:
What|Removed |Added
CC||alei...@catalyst.net.nz
--- Comment #13 from Aleisha Amohia ---
tests fail on 19.11.x. not backported.
$ prove t/db_dependent/Koha/Account.t
t/db_dependent/Koha/Account.t .. 7/11 # Looks like you planned 5 tests but
ran 4.
# Failed test 'pay() tests'
# at t/db_dependent/Koha/Account.t line 724.
Can't use string ("71") as a HASH ref while "strict refs" in use at
t/db_dependent/Koha/Account.t line 720.
# Looks like your test exited with 255 just after 8.
t/db_dependent/Koha/Account.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 4/11 subtests
Test Summary Report
---
t/db_dependent/Koha/Account.t (Wstat: 65280 Tests: 8 Failed: 1)
Failed test: 8
Non-zero exit status: 255
Parse errors: Bad plan. You planned 11 tests but ran 8.
Files=1, Tests=8, 3 wallclock secs ( 0.02 usr 0.01 sys + 2.42 cusr 0.84
csys = 3.29 CPU)
Result: FAIL
if needed, please fix.
There also doesn't seem to be a test plan here so I'm not sure how to test
this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.06 released in|| CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #10 from Martin Renvoize --- Created attachment 111046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111046&action=edit Bug 26506: (QA follow-up) Add Unit Test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Martin Renvoize changed: What|Removed |Added Attachment #110581|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 111045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111045&action=edit Bug 26506: Fix Koha::Account::pay if called when no user is logged-in Currently, Koha::Account::pay will fail if no user is logged-in when it is called. In this case, this patch will use undef instead of 0 for $manager_id in order to comply with the foreign key constraint on manager_id. Signed-off-by: Magnus Enger Biblibre and Libriotech have created a OPAC payment plugin that was having problems because of this bug. Applying the fix in this patch to a live server solved the problem. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #8 from Martin Renvoize --- Good catch, it needs a unit test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- *** Bug 26332 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Don't forget to write a test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #5 from Martin Renvoize --- Whilst I agree with this patch and will PQA it once back at a computer, I do feel it perhaps highlight some issues with the plugin code in question (as I highlighted on my version of the bug and it prompted me to fix my own payments plugin). Lots of Koha functions still exist that expect a userenv to always be present so in general I feel developers should always attempt to set at least the minimum of branch code and interface in a skeleton userenv if they can't catch an existing environment. Just some food for though Matthias 😉. For an example of this see my commit on one of the payment plugins we maintain: https://github.com/PTFS-Europe/koha-plugin-wpm-online_payments/commit/0a0ee1ae7dd2477d1b55d40f974a2c0dcf4e621a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Martin Renvoize changed: What|Removed |Added Depends on||22008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #4 from Martin Renvoize --- Exactly the same patch as attached to bug 26332. As this one is signed off, I think I can safely QA this version even though I wrote the duplicate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #3 from Magnus Enger --- I have signed off the patch because I know it solves a problem. However, I have been involved in the work that Biblibre has done to uncover and fix the bug, so if my signoff is considered to be "not independent enough" please set the status back to NSO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Magnus Enger changed: What|Removed |Added Attachment #110552|0 |1 is obsolete|| --- Comment #2 from Magnus Enger --- Created attachment 110581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110581&action=edit Bug 26506: Fix Koha::Account::pay if called when no user is logged-in Currently, Koha::Account::pay will fail if no user is logged-in when it is called. In this case, this patch will use undef instead of 0 for $manager_id in order to comply with the foreign key constraint on manager_id. Signed-off-by: Magnus Enger Biblibre and Libriotech have created a OPAC payment plugin that was having problems because of this bug. Applying the fix in this patch to a live server solved the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #1 from Matthias Meusburger --- Created attachment 110552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110552&action=edit Bug 26506: Fix Koha::Account::pay if called when no user is logged-in Currently, Koha::Account::pay will fail if no user is logged-in when it is called. In this case, this patch will use undef instead of 0 for $manager_id in order to comply with the foreign key constraint on manager_id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
