[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #18 from Aleisha Amohia --- this didn't work for me on 19.11.x, the tests passed cleanly but i still so no restrictions on patron B after merging patron A into patron B. not backported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.06 released in|| --- Comment #17 from Lucas Gass --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #16 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #15 from Kyle M Hall --- Created attachment 113094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113094&action=edit Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > I am not convince by this patch, we should not call a private method. > Asking for a second QA POV. Kyle, can you confirm that you see this comment before you PQAed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #13 from Kyle M Hall --- Created attachment 112850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112850&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall changed: What|Removed |Added Attachment #111703|0 |1 is obsolete|| Attachment #111704|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 112849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112849&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Signed Off --- Comment #11 from Jonathan Druart --- I am not convince by this patch, we should not call a private method. Asking for a second QA POV. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer changed: What|Removed |Added Attachment #111702|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 111704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111704&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer changed: What|Removed |Added Attachment #97|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 111703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111703&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer changed: What|Removed |Added Attachment #98|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 111702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111702&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Koha Team University Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 David Nind changed: What|Removed |Added Attachment #111058|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 97 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 David Nind changed: What|Removed |Added Attachment #111059|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 98 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #5 from Fridolin SOMERS --- We should work on using Koha objects for debarments. And remove debarred from borrowers table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS changed: What|Removed |Added Attachment #111036|0 |1 is obsolete|| --- Comment #4 from Fridolin SOMERS --- Created attachment 111059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111059&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #3 from Fridolin SOMERS --- Created attachment 111058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111058&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #2 from Fridolin SOMERS --- I'm working on a unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #1 from Fridolin SOMERS --- Created attachment 111036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111036&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS changed: What|Removed |Added Depends on||9302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 [Bug 9302] Add ability to merge patron records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26594] Patrons merge problem with restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
