[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #13 from Aleisha Amohia --- *** Bug 35485 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611
--- Comment #12 from Katrin Fischer ---
(In reply to ryszard.d79 from comment #11)
> Hello.
> Solution to the problem in version 22.11 (it worked for me)
>
> /C4/Matcher.pm
>
> line ~~33
>
> remove_spaces
> upper_case
> );
> +use C4::AuthoritiesMarc qw( GetAuthority );
>
> =head1 NAME
>
> Line ~~703
>
> foreach my $result (@$authresults) {
> my $id = $result->{authid};
> - my $target_record = Koha::Authorities->find( $id )->record;
> + my $target_record = GetAuthority($id);
> $matches->{$id}->{score} += $matchpoint->{'score'};
> $matches->{$id}->{record} = $target_record;
> }
>
> my first comment, sorry for the syntax
Thanks for sharing. The bug will be fixed with the next release in 22.11 with
the patches from
Bug 35343 - record method, required for bug 26611, missing from Koha::Authority
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611
ryszard@gmail.com changed:
What|Removed |Added
CC||ryszard@gmail.com
--- Comment #11 from ryszard@gmail.com ---
Hello.
Solution to the problem in version 22.11 (it worked for me)
/C4/Matcher.pm
line ~~33
remove_spaces
upper_case
);
+use C4::AuthoritiesMarc qw( GetAuthority );
=head1 NAME
Line ~~703
foreach my $result (@$authresults) {
my $id = $result->{authid};
- my $target_record = Koha::Authorities->find( $id )->record;
+ my $target_record = GetAuthority($id);
$matches->{$id}->{score} += $matchpoint->{'score'};
$matches->{$id}->{record} = $target_record;
}
my first comment, sorry for the syntax
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Martin Renvoize changed: What|Removed |Added Blocks||35343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 [Bug 35343] record method, required for bug 26611, missing from Koha::Authority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #10 from Martin Renvoize --- As highlighed above, this is also an issue in 22.11.x.. this patch inadvertantly depends on bug 31794 which adds the record accessor into Koha::Authority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Martin Renvoize changed: What|Removed |Added Depends on||31794 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 [Bug 31794] Add GET endpoint for Authorities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|23.05.00,22.11.07 |23.05.00,22.11.07,22.05.17 released in|| --- Comment #9 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.17 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Katrin Fischer changed: What|Removed |Added Keywords||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #8 from Alex Buckley --- The client who sponsored this fix is currently running Koha 22.05. As Koha 22.05 cannot use 'Koha::Authorities->find( $id )->record;' we have just attached another patch using C4::AuthoritiesMarc->GetAuthorities() instead so this fix can be backported to 22.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #7 from Alex Buckley --- Created attachment 153236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153236=edit Bug 26611: [22.05] Make authority record matching use required match checks This patch fixes record matching for authorities to correctly apply required match checks. To test on Koha 22.05: 1) Create a record matching rule: Threshold: 100 Record type: Authority record Match point 1 Search index: subject-topical Score: 100 Tag: 150 Subfields: a Match check 1 Both source and target record check fields: Tag: 040 Subfields: a This rule says we want to match on the topical term heading, then confirm the match with 040$a. 2) Create two topical term authority records Authority 1: 150$a: Test 040$a: A Authority 2: 150$a: Test 040$a: B 3) Export authority 2 and save 4) Go to Cataloging -> Stage records for import 5) Upload your downloaded authority 2 file. Change the record type to Authority. Choose your new record matching rule. 6) Stage for import. 7) Confirm that with the record matching rule applied, both authorities 1 and 2 show as possible matches, even though only authority 2 has a matching 040$a. 8) Apply the patch and restart services 9) Change the matching rule to "Do not look for matching records" and apply. This is to essentially refresh the page. 10) Change the matching rule to your new matching rule and apply. Confirm only the matching authority 2 shows and is selected. Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #6 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.07 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #4 from Nick Clemens --- Note: I had to change 'subject-topical' to 'Heading-Main' for the matching to work This code could really use unit tests, but this patch is mostly a copy from the existing biblio code, and fixes a long standing bug - PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens changed: What|Removed |Added Attachment #151608|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 151622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151622=edit Bug 26611: Make authority record matching use required match checks This patch fixes record matching for authorities to correctly apply required match checks. To test: 1) Create a record matching rule: Threshold: 100 Record type: Authority record Match point 1 Search index: subject-topical Score: 100 Tag: 150 Subfields: a Match check 1 Both source and target record check fields: Tag: 040 Subfields: a This rule says we want to match on the topical term heading, then confirm the match with 040$a. 2) Create two topical term authority records Authority 1: 150$a: Test 040$a: A Authority 2: 150$a: Test 040$a: B 3) Export authority 2 and save 4) Go to Cataloging -> Stage records for import 5) Upload your downloaded authority 2 file. Change the record type to Authority. Choose your new record matching rule. 6) Stage for import. 7) Confirm that with the record matching rule applied, both authorities 1 and 2 show as possible matches, even though only authority 2 has a matching 040$a. 8) Apply the patch and restart services 9) Change the matching rule to "Do not look for matching records" and apply. This is to essentially refresh the page. 10) Change the matching rule to your new matching rule and apply. Confirm only the matching authority 2 shows and is selected. Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes match checking release notes||for authorities when ||importing records, so that ||the required match checks ||are correctly applied. ||Previously, match checks ||for authority records did ||not work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 David Nind changed: What|Removed |Added Attachment #151549|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 151608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151608=edit Bug 26611: Make authority record matching use required match checks This patch fixes record matching for authorities to correctly apply required match checks. To test: 1) Create a record matching rule: Threshold: 100 Record type: Authority record Match point 1 Search index: subject-topical Score: 100 Tag: 150 Subfields: a Match check 1 Both source and target record check fields: Tag: 040 Subfields: a This rule says we want to match on the topical term heading, then confirm the match with 040$a. 2) Create two topical term authority records Authority 1: 150$a: Test 040$a: A Authority 2: 150$a: Test 040$a: B 3) Export authority 2 and save 4) Go to Cataloging -> Stage records for import 5) Upload your downloaded authority 2 file. Change the record type to Authority. Choose your new record matching rule. 6) Stage for import. 7) Confirm that with the record matching rule applied, both authorities 1 and 2 show as possible matches, even though only authority 2 has a matching 040$a. 8) Apply the patch and restart services 9) Change the matching rule to "Do not look for matching records" and apply. This is to essentially refresh the page. 10) Change the matching rule to your new matching rule and apply. Confirm only the matching authority 2 shows and is selected. Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #1 from Aleisha Amohia --- Created attachment 151549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151549=edit Bug 26611: Make authority record matching use required match checks This patch fixes record matching for authorities to correctly apply required match checks. To test: 1) Create a record matching rule: Threshold: 100 Record type: Authority record Match point 1 Search index: subject-topical Score: 100 Tag: 150 Subfields: a Match check 1 Both source and target record check fields: Tag: 040 Subfields: a This rule says we want to match on the topical term heading, then confirm the match with 040$a. 2) Create two topical term authority records Authority 1: 150$a: Test 040$a: A Authority 2: 150$a: Test 040$a: B 3) Export authority 2 and save 4) Go to Cataloging -> Stage records for import 5) Upload your downloaded authority 2 file. Change the record type to Authority. Choose your new record matching rule. 6) Stage for import. 7) Confirm that with the record matching rule applied, both authorities 1 and 2 show as possible matches, even though only authority 2 has a matching 040$a. 8) Apply the patch and restart services 9) Change the matching rule to "Do not look for matching records" and apply. This is to essentially refresh the page. 10) Change the matching rule to your new matching rule and apply. Confirm only the matching authority 2 shows and is selected. Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | CC||alei...@catalyst.net.nz Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21972 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12586 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
