[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED Documentation||Caroline Cyr La Rose contact|| Resolution|--- |FIXED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/678 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #18 from Katrin Fischer --- I am a little worried that there could be an overlap with existing notice template codes resulting in 'strange' behaviour. 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account debit types (OVERDUE, PAYOUT) OVERDUE and circulation seems a super likely candidate, even if the standard notice is ODUE, but this can be configured as libraries like... Maybe it would be a little safer to use these with a prefix? Something like ACCOUNT_ could be a good fit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #19 from Martin Renvoize --- Created attachment 136744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136744&action=edit Bug 26689: Prepend letter codes. This patch prepends the credit_type_code and debit_type_code with CREDIT_ and DEBIT_ respectively when doing a lookup on the notice letter code. Test plan 1) As previous patches, however instead of just naming your notice to match the credit_type_code or debit_type_code use CREDIT_credit_type_code and DEBIT_debit_type_code respectively. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement allows end release notes||users to define their ||account notices (print ||receipt and print invoice ||for example) at the debit ||type and credit type level. || ||Simply add a new notice ||with code ||'DEBIT_your_debit_type_code ||' or ||'CREDIT_your_credit_type_co ||de' to the notices and we ||will pick that over the ||existing default ||'ACCOUNT_DEBIT' and ||'ACCOUNT_CREDIT' notices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #20 from Martin Renvoize --- Nice catch Katrin.. added a follow-up and added notes for the release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #21 from Katrin Fischer --- (In reply to Martin Renvoize from comment #20) > Nice catch Katrin.. added a follow-up and added notes for the release notes. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Caroline Cyr La Rose changed: What|Removed |Added Keywords|release-notes-needed| CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.05 released in|| --- Comment #23 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #24 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Depends on||24381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Depends on|24381 | Blocks||24381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Depends on||26734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 [Bug 26734] Convert accounts (monetary) notices to template toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #1 from Katrin Fischer --- Created attachment 112081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112081&action=edit Bug 26686: Fix sorting of "updated on" and "time created" on notices tab In the patron's account in the staff interface there is a tab 'Notices' that shows all notices sent out to a patron. The updated on column would not sort at all, but there was also some markup missing for the time created column. To test: - Make sure you have a patron account with some notices, ideally with different times and dates - Verify that the updated on column doesn't sort at all - Apply patch - Verify both date columns now sort correctly for different DateFormat settings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Katrin Fischer changed: What|Removed |Added Attachment #112081|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #2 from Martin Renvoize --- Created attachment 118204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118204&action=edit Bug 26689: Check for specific template then fallback This patch adds a check for a more specific ACCOUNT_CREDIT template (named to match the credit_type_code of the credit line) prior to falling back to the ACCOUNT_CREDIT template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #3 from Martin Renvoize --- Created attachment 118211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118211&action=edit Bug 26689: Check for specific template then fallback - printfeercpt This patch adds a check for a more specific ACCOUNT_CREDIT template (named to match the credit_type_code of the credit line) prior to falling back to the ACCOUNT_CREDIT template. Test plan 1/ On a patrons account page use the print option on a series of credit lines with differing credit types (Payment, Lost Item Return, Writeoff) 2/ Note that the same template 'ACCOUNT_CREDIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_CREDIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account credit types (PAYMENT, WRITEOFF, LOST_FOUND) 6/ Run step 1 again and note that where you have added a specific notice for that credit type it has been used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #4 from Martin Renvoize --- Created attachment 118212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118212&action=edit Bug 26689: Check for specific template then fallback - printinvoice This patch adds a check for a more specific ACCOUNT_DEBIT template (named to match the debit_type_code of the credit line) prior to falling back to the ACCOUNT_DEBIT template. Test plan 1/ On a patrons account page use the print option on a series of debit lines with differing credit types (Overdue, Payout) 2/ Note that the same template 'ACCOUNT_DEBIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_DEBIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account debit types (OVERDUE, PAYOUT) 6/ Run step 1 again and note that where you have added a specific notice for that debit type it has been used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #118204|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #5 from Martin Renvoize --- Where this becomes really cool is for where a debit type or credit type doesn't entirely fit with the expected... Examples: * WRITEOFF is a credit type but it's not a payment.. so doesn't make sense to have 'Thanks for your payment' * CREDIT is a credit type for credit notes.. it makes sense to have it's own notice * PAYOUT is a debit type.. but it really doesn't make sense to print it the same way as other debit types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Joonas Kylmälä --- Martin, this doesn't apply anymore, could you now do re-do this as the missing dependency was just pushed to master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #118211|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 119572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119572&action=edit Bug 26689: Check for specific template then fallback - printfeercpt This patch adds a check for a more specific ACCOUNT_CREDIT template (named to match the credit_type_code of the credit line) prior to falling back to the ACCOUNT_CREDIT template. Test plan 1/ On a patrons account page use the print option on a series of credit lines with differing credit types (Payment, Lost Item Return, Writeoff) 2/ Note that the same template 'ACCOUNT_CREDIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_CREDIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account credit types (PAYMENT, WRITEOFF, LOST_FOUND) 6/ Run step 1 again and note that where you have added a specific notice for that credit type it has been used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #118212|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 119573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119573&action=edit Bug 26689: Check for specific template then fallback - printinvoice This patch adds a check for a more specific ACCOUNT_DEBIT template (named to match the debit_type_code of the credit line) prior to falling back to the ACCOUNT_DEBIT template. Test plan 1/ On a patrons account page use the print option on a series of debit lines with differing credit types (Overdue, Payout) 2/ Note that the same template 'ACCOUNT_DEBIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_DEBIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account debit types (OVERDUE, PAYOUT) 6/ Run step 1 again and note that where you have added a specific notice for that debit type it has been used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #119572|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 119574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119574&action=edit Bug 26689: Check for specific template then fallback - printfeercpt This patch adds a check for a more specific ACCOUNT_CREDIT template (named to match the credit_type_code of the credit line) prior to falling back to the ACCOUNT_CREDIT template. Test plan 1/ On a patrons account page use the print option on a series of credit lines with differing credit types (Payment, Lost Item Return, Writeoff) 2/ Note that the same template 'ACCOUNT_CREDIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_CREDIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account credit types (PAYMENT, WRITEOFF, LOST_FOUND) 6/ Run step 1 again and note that where you have added a specific notice for that credit type it has been used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #119573|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 119575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119575&action=edit Bug 26689: Check for specific template then fallback - printinvoice This patch adds a check for a more specific ACCOUNT_DEBIT template (named to match the debit_type_code of the credit line) prior to falling back to the ACCOUNT_DEBIT template. Test plan 1/ On a patrons account page use the print option on a series of debit lines with differing credit types (Overdue, Payout) 2/ Note that the same template 'ACCOUNT_DEBIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_DEBIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account debit types (OVERDUE, PAYOUT) 6/ Run step 1 again and note that where you have added a specific notice for that debit type it has been used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #119574|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #119575|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #118211|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Attachment #118212|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #11 from Martin Renvoize --- It seems bug 26734 hasn't actually been pushed.. just the first patch from it accidentally made it in.. as such I've undone my rebase and unobsoleted the two patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #12 from Martin Renvoize --- This applies nicely again now as is :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Bug 26689 depends on bug 26734, which changed state. Bug 26734 Summary: Convert accounts (monetary) notices to use GetPreparedLetter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 sandbo...@biblibre.com changed: What|Removed |Added Attachment #118211|0 |1 is obsolete|| --- Comment #13 from sandbo...@biblibre.com --- Created attachment 135113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135113&action=edit Bug 26689: Check for specific template then fallback - printfeercpt This patch adds a check for a more specific ACCOUNT_CREDIT template (named to match the credit_type_code of the credit line) prior to falling back to the ACCOUNT_CREDIT template. Test plan 1/ On a patrons account page use the print option on a series of credit lines with differing credit types (Payment, Lost Item Return, Writeoff) 2/ Note that the same template 'ACCOUNT_CREDIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_CREDIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account credit types (PAYMENT, WRITEOFF, LOST_FOUND) 6/ Run step 1 again and note that where you have added a specific notice for that credit type it has been used. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 sandbo...@biblibre.com changed: What|Removed |Added Attachment #118212|0 |1 is obsolete|| --- Comment #14 from sandbo...@biblibre.com --- Created attachment 135114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135114&action=edit Bug 26689: Check for specific template then fallback - printinvoice This patch adds a check for a more specific ACCOUNT_DEBIT template (named to match the debit_type_code of the credit line) prior to falling back to the ACCOUNT_DEBIT template. Test plan 1/ On a patrons account page use the print option on a series of debit lines with differing credit types (Overdue, Payout) 2/ Note that the same template 'ACCOUNT_DEBIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_DEBIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account debit types (OVERDUE, PAYOUT) 6/ Run step 1 again and note that where you have added a specific notice for that debit type it has been used. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from Sally --- This is a really nice development - works great, signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Kyle M Hall changed: What|Removed |Added Attachment #135113|0 |1 is obsolete|| Attachment #135114|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 135685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135685&action=edit Bug 26689: Check for specific template then fallback - printfeercpt This patch adds a check for a more specific ACCOUNT_CREDIT template (named to match the credit_type_code of the credit line) prior to falling back to the ACCOUNT_CREDIT template. Test plan 1/ On a patrons account page use the print option on a series of credit lines with differing credit types (Payment, Lost Item Return, Writeoff) 2/ Note that the same template 'ACCOUNT_CREDIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_CREDIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account credit types (PAYMENT, WRITEOFF, LOST_FOUND) 6/ Run step 1 again and note that where you have added a specific notice for that credit type it has been used. Signed-off-by: Sally Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #17 from Kyle M Hall --- Created attachment 135686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135686&action=edit Bug 26689: Check for specific template then fallback - printinvoice This patch adds a check for a more specific ACCOUNT_DEBIT template (named to match the debit_type_code of the credit line) prior to falling back to the ACCOUNT_DEBIT template. Test plan 1/ On a patrons account page use the print option on a series of debit lines with differing credit types (Overdue, Payout) 2/ Note that the same template 'ACCOUNT_DEBIT' is used for all types 3/ Apply the patch 4/ Run step 1 again and note all still print using ACCOUNT_DEBIT 5/ Add a new notice template under the 'circulation' module with a code that matches one of your account debit types (OVERDUE, PAYOUT) 6/ Run step 1 again and note that where you have added a specific notice for that debit type it has been used. Signed-off-by: Sally Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||vic...@tuxayo.net --- Comment #25 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement allows end |**Sponsored by** *PTFS release notes|users to define their |Europe* |account notices (print | |receipt and print invoice |This enhancement |for example) at the debit |allows end users to define |type and credit type level. |their account notices | |(print receipt and print |Simply add a new notice |invoice for example) at the |with code |debit type and credit type |'DEBIT_your_debit_type_code |level. |' or| |'CREDIT_your_credit_type_co |Simply add a new |de' to the notices and we |notice with code |will pick that over the |'DEBIT_your_debit_type_code |existing default|' or |'ACCOUNT_DEBIT' and |'CREDIT_your_credit_type_co |'ACCOUNT_CREDIT' notices. |de' to the notices and we ||will pick that over the ||existing default ||'ACCOUNT_DEBIT' and ||'ACCOUNT_CREDIT' notices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
