[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Bug 26751 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Bug 26751 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Bug 26751 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Aleisha Amohia changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #12 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #11 from Lucas Gass --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 --- Comment #10 from David Cook --- (In reply to Tomás Cohen Arazi from comment #8) > I'd say we should leave this bug alone, and propose the refactoring in its > own bug, so stable branches can have this feature fixed. Also there might be > other options to explore. I proposed to move things into YAML or JSON, > splitting the Zebra and general config for good. I think using the XML::Simple "forcearray" option may have been a good idea in this case, but this patch works too. But I agree about a new bug about refactoring configuration. I've opened bug 26790. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751
--- Comment #8 from Tomás Cohen Arazi ---
(In reply to David Cook from comment #7)
> (In reply to Martin Renvoize from comment #5)
> > This patch fixes this nasty problem with how XML is parsed: if more than
> > one entry is found, repo => [] is generated. If only one, repo => {}.
>
> To nitpick, the nasty problem is just due to XML::Simple being problematic.
> Grant McLean (who is at Kohacon2020 and works at Catalyst IT) doesn't that
> people use it in new code, and I reckon we should work on just taking it out
> of our code.
>
> By the way, an alternative to this patch would be to update the forcearray
> option in Koha::Config::read_from_file. (See
> https://metacpan.org/pod/XML::Simple#ForceArray-=%3E-1-%23-in-important for
> more information)
>
> In fact, it might be better to use my alternative idea, because then we'd
> have more centralized in-code documentation about what config options *need*
> to be arrays.
I'd say we should leave this bug alone, and propose the refactoring in its own
bug, so stable branches can have this feature fixed. Also there might be other
options to explore. I proposed to move things into YAML or JSON, splitting the
Zebra and general config for good.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751
--- Comment #7 from David Cook ---
(In reply to Martin Renvoize from comment #5)
> This patch fixes this nasty problem with how XML is parsed: if more than
> one entry is found, repo => [] is generated. If only one, repo => {}.
To nitpick, the nasty problem is just due to XML::Simple being problematic.
Grant McLean (who is at Kohacon2020 and works at Catalyst IT) doesn't that
people use it in new code, and I reckon we should work on just taking it out of
our code.
By the way, an alternative to this patch would be to update the forcearray
option in Koha::Config::read_from_file. (See
https://metacpan.org/pod/XML::Simple#ForceArray-=%3E-1-%23-in-important for
more information)
In fact, it might be better to use my alternative idea, because then we'd have
more centralized in-code documentation about what config options *need* to be
arrays.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Good catch, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751
Martin Renvoize changed:
What|Removed |Added
Attachment #112070|0 |1
is obsolete||
--- Comment #5 from Martin Renvoize ---
Created attachment 112096
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112096=edit
Bug 26751: Fix fatal exception if only one repo defined
This patch fixes this nasty problem with how XML is parsed: if more than
one entry is found, repo => [] is generated. If only one, repo => {}.
To test:
1. Have more than one entries in the plugins_repo entry:
ByWater Solutions
bywatersolutions
github
Theke Solutions
thekesolutions
github
PTFS Europe
ptfs-europe
github
2. Search for plugins
=> SUCCESS: Searching works!
3. Leave only one entry
4. Restart all to refresh things
5. Try searching for plugins
=> FAIL: Fatal error
6. Apply this patch
7. Repeat 5
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Kyle M Hall
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- One of the unfortunate side-effects of using XML::Simple :( We really do need to get rid of it one day, although I wonder how many issues will be created as a result... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751
Kyle M Hall changed:
What|Removed |Added
Attachment #112065|0 |1
is obsolete||
--- Comment #3 from Kyle M Hall ---
Created attachment 112070
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112070=edit
Bug 26751: Fix fatal exception if only one repo defined
This patch fixes this nasty problem with how XML is parsed: if more than
one entry is found, repo => [] is generated. If only one, repo => {}.
To test:
1. Have more than one entries in the plugins_repo entry:
ByWater Solutions
bywatersolutions
github
Theke Solutions
thekesolutions
github
PTFS Europe
ptfs-europe
github
2. Search for plugins
=> SUCCESS: Searching works!
3. Leave only one entry
4. Restart all to refresh things
5. Try searching for plugins
=> FAIL: Fatal error
6. Apply this patch
7. Repeat 5
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Tomás Cohen Arazi changed: What|Removed |Added Depends on||23975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Tomás Cohen Arazi changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Tomás Cohen Arazi changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Tomás Cohen Arazi changed: What|Removed |Added Blocks||24633 Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 [Bug 24633] Add support for gitlab searching of plugins -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 112065
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112065=edit
Bug 26751: Fix fatal exception if only one repo defined
This patch fixes this nasty problem with how XML is parsed: if more than
one entry is found, repo => [] is generated. If only one, repo => {}.
To test:
1. Have more than one entries in the plugins_repo entry:
ByWater Solutions
bywatersolutions
github
Theke Solutions
thekesolutions
github
PTFS Europe
ptfs-europe
github
2. Search for plugins
=> SUCCESS: Searching works!
3. Leave only one entry
4. Restart all to refresh things
5. Try searching for plugins
=> FAIL: Fatal error
6. Apply this patch
7. Repeat 5
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 --- Comment #1 from Tomás Cohen Arazi --- Steps to reproduce: 1. Have several entries for querying 2. Search for plugins => SUCCESS: It doesn't die 3. Have only one entry 4. Repeat 2 => FAIL: It dies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
