[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2021-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
does not apply clean to 20.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #112584|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 112800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112800=edit
Bug 26833: Logged in library doesn't show with suggestions count

This patch corrects the template variables used by the suggestions
counts shown on the staff interface home page and the acquisitions home
page. They should use [% Branches.GetLoggedInBranchname %]

To test you should have some suggestions from multiple libraries.

- Log in to the staff interface.
- On the home page you should see "Suggestions pending approval,"
  followed by the name of your logged-in library and the count of
  suggestions for your library.
- Go to the acquisitions page.
- In the "Pending suggestions" section you should see the same
  information: Your logged-in library name, suggestion count, and the
  count of suggestions at all libraries.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

--- Comment #4 from Séverine Queune  ---
I've got a slightly different display from what is described.
Using 'independentbanches', a staff user sees only 'logged-in library: nb' on
both pages while a superlibrarian sees 'logged-in library: nb / All libraries:
nb'.
Without 'independentbanches', the 2 informations for the 'logged-in library'
and 'all librairies' are display including in the home page.
I signed thought, because that's completely relevant and what I expected as
display.
Let me know if I shouldn't have to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Séverine Queune  changed:

   What|Removed |Added

 Attachment #112576|0   |1
is obsolete||

--- Comment #3 from Séverine Queune  ---
Created attachment 112584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112584=edit
Bug 26833: Logged in library doesn't show with suggestions count

This patch corrects the template variables used by the suggestions
counts shown on the staff interface home page and the acquisitions home
page. They should use [% Branches.GetLoggedInBranchname %]

To test you should have some suggestions from multiple libraries.

- Log in to the staff interface.
- On the home page you should see "Suggestions pending approval,"
  followed by the name of your logged-in library and the count of
  suggestions for your library.
- Go to the acquisitions page.
- In the "Pending suggestions" section you should see the same
  information: Your logged-in library name, suggestion count, and the
  count of suggestions at all libraries.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

--- Comment #2 from Owen Leonard  ---
Created attachment 112576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112576=edit
Bug 26833: Logged in library doesn't show with suggestions count

This patch corrects the template variables used by the suggestions
counts shown on the staff interface home page and the acquisitions home
page. They should use [% Branches.GetLoggedInBranchname %]

To test you should have some suggestions from multiple libraries.

- Log in to the staff interface.
- On the home page you should see "Suggestions pending approval,"
  followed by the name of your logged-in library and the count of
  suggestions for your library.
- Go to the acquisitions page.
- In the "Pending suggestions" section you should see the same
  information: Your logged-in library name, suggestion count, and the
  count of suggestions at all libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

2020-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Owen Leonard  changed:

   What|Removed |Added

 Depends on||25033
 Status|NEW |ASSIGNED
Summary|Display issue for 'Pending  |Logged in library doesn't
   |suggestions' on Acq Home|show with suggestions count

--- Comment #1 from Owen Leonard  ---
Bug 25033 added library information to the counts of suggestions shown on the
staff interface home page and the acquisitions home page. The LoginBranchname
used in the template doesn't exist, having been removed by Bug 25765.

The template should use [% Branches.GetLoggedInBranchname %] instead.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033
[Bug 25033] Counts of suggestions are confusing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/