[Koha-bugs] [Bug 26860] Add search limit for records without items

2022-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|BLOCKED |RESOLVED

--- Comment #26 from Fridolin Somers  ---
(In reply to Fridolin Somers from comment #25)
> Maybe can now be implemented with Bug 17170

Yes it can :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2022-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17170

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2022-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2022-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #25 from Fridolin Somers  ---
Maybe can now be implemented with Bug 17170

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-09-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

mathieu saby  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #119114|0   |1
is obsolete||

--- Comment #24 from Fridolin Somers  ---
Created attachment 124127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124127=edit
Bug 26860: (follow-up) case requesting zebra with ccl query

When calling a ccl syntax query, code must be added like for
availability facet.
See Bug 17278: Use available limit when requesting zebra when ccl query is used

This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne
'available' } @limits".
Following the logic of :
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}

Test plan :
1) Use Zebra search engine
2) Perform a search on staff interface with explicit index, for example
'ti:history'
3) This search must return some records with and some without items
4) Click on 'Limit to records without items'
5) Check you see only records without items
6) Click on 'Show all records'
7) Check you see all records again
8) Check availability facet is also working

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #119113|0   |1
is obsolete||

--- Comment #23 from Fridolin Somers  ---
Created attachment 124126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124126=edit
Bug 26860: Add without items facet

Many libraries ask for a way to search biblio records without items.
In order to clean the catalogue or acquire items.
I propose to add a search limit and facet.
Only in staff interface for start.

I choose to use homebranch index, should always be defined on items.
Looks like itemnumber index can not be used because of its configuration in
ccl.properties.

Test plan :
1) Check with both Zebra and Elasticsearch
2) Perform a search on staff interface returning some records with and some
without items
3) Click on 'Limit to records without items'
4) Check you see only records without items
5) Click on 'Show all records'
6) Check you see all records again

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #120994|0   |1
is obsolete||

--- Comment #22 from Fridolin Somers  ---
Created attachment 124125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124125=edit
Bug 26860: facets.inc refactor availability facet

To prepare new facet, this patch refactors the availability facet,
without any change in restult.
Appart from an id 'facet-availability', like other facets.

Test plan:
1) Perform a search in staff interface
2) Check availability facet displays well
3) Click on it
4) Check availability facet displays well

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)|21.11.00|
released in||
  Text to go in the|Can be hidden with CSS, |Can be hidden with CSS,
  release notes|using the #withoutitems_id  |using the #withoutitems_id
   |selector.   |selector.
   ||
   ||RM NOTE:
   ||Reverted

--- Comment #21 from Jonathan Druart  ---
The patch that has been pushed is now reverted. Please clarify the situation.

Tests are missing anyway and the patches are not ready for integration into
master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #119114|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #119113|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #20 from Fridolin Somers  ---
(In reply to Kyle M Hall from comment #17)
> Created attachment 120994 [details] [review]
> Bug 26860: facets.inc refactor availability facet
> 
Oh crap, only first patch has been QA and others set obsolete.

So only first patch is in master :
 > git log --online --grep=26860 origin/master 
63d6c1d8c5 Bug 26860: facets.inc refactor availability facet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 CC||k...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #19 from Kyle M Hall  ---
Enhancment not backported to 21.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #18 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #119112|0   |1
is obsolete||
 Attachment #119113|0   |1
is obsolete||
 Attachment #119114|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 120994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120994=edit
Bug 26860: facets.inc refactor availability facet

To prepare new facet, this patch refactors the availability facet,
without any change in restult.
Appart from an id 'facet-availability', like other facets.

Test plan:
1) Perform a search in staff interface
2) Check availability facet displays well
3) Click on it
4) Check availability facet displays well

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

David Nind  changed:

   What|Removed |Added

 Attachment #113220|0   |1
is obsolete||

--- Comment #16 from David Nind  ---
Created attachment 119114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119114=edit
Bug 26860: (follow-up) case requesting zebra with ccl query

When calling a ccl syntax query, code must be added like for
availability facet.
See Bug 17278: Use available limit when requesting zebra when ccl query is used

This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne
'available' } @limits".
Following the logic of :
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}

Test plan :
1) Use Zebra search engine
2) Perform a search on staff interface with explicit index, for example
'ti:history'
3) This search must return some records with and some without items
4) Click on 'Limit to records without items'
5) Check you see only records without items
6) Click on 'Show all records'
7) Check you see all records again
8) Check availability facet is also working

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

David Nind  changed:

   What|Removed |Added

 Attachment #112932|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 119113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119113=edit
Bug 26860: Add without items facet

Many libraries ask for a way to search biblio records without items.
In order to clean the catalogue or acquire items.
I propose to add a search limit and facet.
Only in staff interface for start.

I choose to use homebranch index, should always be defined on items.
Looks like itemnumber index can not be used because of its configuration in
ccl.properties.

Test plan :
1) Check with both Zebra and Elasticsearch
2) Perform a search on staff interface returning some records with and some
without items
3) Click on 'Limit to records without items'
4) Check you see only records without items
5) Click on 'Show all records'
6) Check you see all records again

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

David Nind  changed:

   What|Removed |Added

 Attachment #112931|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 119112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119112=edit
Bug 26860: facets.inc refactor availability facet

To prepare new facet, this patch refactors the availability facet,
without any change in restult.
Appart from an id 'facet-availability', like other facets.

Test plan:
1) Perform a search in staff interface
2) Check availability facet displays well
3) Click on it
4) Check availability facet displays well

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #13 from Fridolin SOMERS  ---
Created attachment 113220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113220=edit
Bug 26860: (follow-up) case requesting zebra with ccl query

When calling a ccl syntax query, code must be added like for
availability facet.
See Bug 17278: Use available limit when requesting zebra when ccl query is used

This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne
'available' } @limits".
Following the logic of :
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}

Test plan :
1) Use Zebra search engine
2) Perform a search on staff interface with explicit index, for example
'ti:history'
3) This search must return some records with and some without items
4) Click on 'Limit to records without items'
5) Check you see only records without items
6) Click on 'Show all records'
7) Check you see all records again
8) Check availability facet is also working

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #12 from Fridolin SOMERS  ---
CCL part refers to :
Bug 17278: Use available limit when requesting zebra when ccl query is used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #11 from Jonathan Druart  
---
(In reply to Fridolin SOMERS from comment #4)
> I've add a TODO for code dealing with "ccl=".
> I will create a follow-up

Still waiting the follow-up then?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #10 from Jonathan Druart  
---
Comment on attachment 112932
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112932
Bug 26860: Add without items facet

Review of attachment 112932:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=26860=112932)
-

::: C4/Search.pm
@@ +1322,4 @@
>  }
>  $q .= ' and '.join(' and ', @limits) if @limits;
>  }
> +#TODO withoutitems limit

What is this TODO about?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 112931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112931=edit
Bug 26860: facets.inc refactor availability facet

To prepare new facet, this patch refactors the availability facet,
without any change in restult.
Appart from an id 'facet-availability', like other facets.

Test plan:
1) Perform a search in staff interface
2) Check availability facet displays well
3) Click on it
4) Check availability facet displays well

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 112932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112932=edit
Bug 26860: Add without items facet

Many libraries ask for a way to search biblio records without items.
In order to clean the catalogue or acquire items.
I propose to add a search limit and facet.
Only in staff interface for start.

I choose to use homebranch index, should always be defined on items.
Looks like itemnumber index can not be used because of its configuration in
ccl.properties.

Test plan :
1) Check with both Zebra and Elasticsearch
2) Perform a search on staff interface returning some records with and some
without items
3) Click on 'Limit to records without items'
4) Check you see only records without items
5) Click on 'Show all records'
6) Check you see all records again

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #112914|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #112913|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||Can be hidden with CSS,
  release notes||using the #withoutitems_id
   ||selector.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #7 from Séverine Queune  ---
Can't test with Zebra, I only validate the very good behaviour with ES.
Thanks Frido for this nice patch :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Séverine Queune  changed:

   What|Removed |Added

 Attachment #112859|0   |1
is obsolete||

--- Comment #6 from Séverine Queune  ---
Created attachment 112914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112914=edit
Bug 26860: Add without items facet

Many libraries ask for a way to search biblio records without items.
In order to clean the catalogue or acquire items.
I propose to add a search limit and facet.
Only in staff interface for start.

I choose to use homebranch index, should always be defined on items.
Looks like itemnumber index can not be used because of its configuration in
ccl.properties.

Test plan :
1) Check with both Zebra and Elasticsearch
2) Perform a search on staff interface returning some records with and some
without items
3) Click on 'Limit to records without items'
4) Check you see only records without items
5) Click on 'Show all records'
6) Check you see all records again

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Séverine Queune  changed:

   What|Removed |Added

 Attachment #112858|0   |1
is obsolete||

--- Comment #5 from Séverine Queune  ---
Created attachment 112913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112913=edit
Bug 26860: facets.inc refactor availability facet

To prepare new facet, this patch refactors the availability facet,
without any change in restult.
Appart from an id 'facet-availability', like other facets.

Test plan:
1) Perform a search in staff interface
2) Check availability facet displays well
3) Click on it
4) Check availability facet displays well

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #4 from Fridolin SOMERS  ---
I've add a TODO for code dealing with "ccl=".
I will create a follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #2 from Fridolin SOMERS  ---
Created attachment 112858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112858=edit
Bug 26860: facets.inc refactor availability facet

To prepare new facet, this patch refactors the availability facet,
without any change in restult.
Appart from an id 'facet-availability', like other facets.

Test plan:
1) Perform a search in staff interface
2) Check availability facet displays well
3) Click on it
4) Check availability facet displays well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #3 from Fridolin SOMERS  ---
Created attachment 112859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112859=edit
Bug 26860: Add without items facet

Many libraries ask for a way to search biblio records without items.
In order to clean the catalogue or acquire items.
I propose to add a search limit and facet.
Only in staff interface for start.

I choose to use homebranch index, should always be defined on items.
Looks like itemnumber index can not be used because of its configuration in
ccl.properties.

Test plan :
1) Check with both Zebra and Elasticsearch
2) Perform a search on staff interface returning some records with and some
without items
3) Click on 'Limit to records without items'
4) Check you see only records without items
5) Click on 'Show all records'
6) Check you see all records again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry  ---
+1, this would be handy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2020-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/