[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #16 from wainuiwitikap...@catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in||20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in|| --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #13 from Fridolin Somers --- > We have been restarting SIP nightly for years ourselves Same at BibLibre ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com Version(s)|21.11.00|21.11.00,21.05.05 released in|| --- Comment #12 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #10 from Jonathan Druart --- That's definitely where it should have been put originally. It was due to my lack of understanding of C4::SIP code and how SIP machines work. I thought that "process_request" was used to... process the request, but it's actually used at connection time. Having used misc/sip_cli_emulator.pl instead of telnet in the test plan of bug 23640 was also misleading. I also thought that a connection was made for each request. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- OK.. well this works as expected and resolves some serious problems for users (We have been restarting SIP nightly for years ourselves.. but we shouldn't all need to do that!). I would love to see Unit Tests for this change.. and I'd love to see some POD updates for the SIPServer code as hardly any of these functions are properly documented and I think had they been we might have fixed this earlier. Passing QA for now, as the code works.. I'll leave it up to the RM to require a Unit Test if he feels it's a) important and b) attainable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Martin Renvoize changed: What|Removed |Added Attachment #127111|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 127157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127157&action=edit Bug 26871: Flush SIP2 cache on every SIP request SIP connections tend to be long lived, weeks if not months, in the libraries I see. Basically the connection per SIP machine is initiated once when the SIP machine boots and then never closed until maintanance needs to be done. Therefore we need to reset the Koha's L1 caches on every SIP request to get the latest sysprefs and configs from the memcached cache that is shared between all the Koha programs (intranet, opac, sip, cronjobs) and is guaranteed to be up to date. To test: 0. Have kohadevbox 1. Enable IssueLog 2. In one terminal run the command "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml" 3. Checkin and return a book using telnet: $ telnet localhost 6001 9300CNterm1|COterm1|CPCPL| 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 4. Keep the telnet connection open and go to http://localhost:8081/cgi-bin/koha/tools/viewlog.pl and check that the *checkout* entry is in the circulation rules 5. 6. Disable IssueLog 7. Move back to the telnet prompt and check out and return a book again 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 8. Go check out the circulation logs and notice a new entry was added when it shouldn't have according to the IssueLog syspref! 9. Apply patch and repeat steps to notice that the syspref is now followed correctly. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- I'd love to see a unit test for this... but I'm not entirely sure how we'd go about that. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 David Nind changed: What|Removed |Added Text to go in the||This fixes SIP connections release notes||so that when system ||preference and ||configuration changes are ||made (for example: enabling ||or disabling logging of ||issues and returns) they ||are picked up automatically ||with the next message, ||rather than requiring the ||SIP connection to be closed ||and reopened. || ||SIP ||connections typically tend ||to be long lived - weeks if ||not months. Basically the ||connection per SIP machine ||is initiated once when the ||SIP machine boots and then ||never closed until ||maintenance is required. ||Therefore we need to reset ||Koha's caches on every SIP ||request to get the latest ||system preference and ||configuration changes from ||the memcached cache that is ||shared between all the Koha ||programs (staff interface, ||OPAC, SIP, cronjobs, etc). Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- Testing notes (koha-testing-docker (KTD)): 1. Install telnet: apt-get install telnet 2. SIP user already setup in KTD - koha-sip with login name term1 which is included in the SIPconfig.xml. Accessing SIP server as per step 2 of the test plan works as expected. 3. IssueLog is already set to 'Log' in KTD. 4. Responses for entries - basically checks out a book (barcode - 30001) to Koha Admin (card number - 1) and returns it (note for 4.2 this is all one entry on one line): 4.1 9300CNterm1|COterm1|CPCPL| => 941 4.2 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| => 121NNY20211030200556AOCPL|AA1|AB30001|AJE Street shuffle :|AH20211104235900| => Log entry (when recorded): . Date: 10/30/2021 20:05 [will be the date and time action performed] . Librarian: koha_sip (53) . Module: Circulation . Action: Checkout . Object: Koha Admin (1) . Info: Item 30001 [Linked to item] . Interface: SIP 4.3 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| => 101YNN20211030200704AOCPL|AB30001|AQCPL|AJE Street shuffle :|AA1| => Log entry (when recorded): . Date: 10/30/2021 20:07 [will be the date and time action performed] . Librarian: koha_sip (53) . Module: Circulation . Action: Return . Object: Koha Admin (1) . Info: Item 30001 [Linked to item] . Interface: SIP 5. If the telnet connection is closed or automatically times out enter 9300CNterm1|COterm1|CPCPL| after reconnecting. Note that when you reconnect it will pick up any system preference changes, so depending on where you are in testing you may need to start again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 David Nind changed: What|Removed |Added Attachment #126016|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 127111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127111&action=edit Bug 26871: Flush SIP2 cache on every SIP request SIP connections tend to be long lived, weeks if not months, in the libraries I see. Basically the connection per SIP machine is initiated once when the SIP machine boots and then never closed until maintanance needs to be done. Therefore we need to reset the Koha's L1 caches on every SIP request to get the latest sysprefs and configs from the memcached cache that is shared between all the Koha programs (intranet, opac, sip, cronjobs) and is guaranteed to be up to date. To test: 0. Have kohadevbox 1. Enable IssueLog 2. In one terminal run the command "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml" 3. Checkin and return a book using telnet: $ telnet localhost 6001 9300CNterm1|COterm1|CPCPL| 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 4. Keep the telnet connection open and go to http://localhost:8081/cgi-bin/koha/tools/viewlog.pl and check that the *checkout* entry is in the circulation rules 5. 6. Disable IssueLog 7. Move back to the telnet prompt and check out and return a book again 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 8. Go check out the circulation logs and notice a new entry was added when it shouldn't have according to the IssueLog syspref! 9. Apply patch and repeat steps to notice that the syspref is now followed correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 --- Comment #4 from David Cook --- Wow, this one isn't already fixed? I thought that someone had already done a patch but they must not have... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Joonas Kylmälä changed: What|Removed |Added CC||nug...@gmail.com, ||stalkern...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 --- Comment #3 from Joonas Kylmälä --- Created attachment 126016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126016&action=edit Bug 26871: Flush SIP2 cache on every SIP request SIP connections tend to be long lived, weeks if not months, in the libraries I see. Basically the connection per SIP machine is initiated once when the SIP machine boots and then never closed until maintanance needs to be done. Therefore we need to reset the Koha's L1 caches on every SIP request to get the latest sysprefs and configs from the memcached cache that is shared between all the Koha programs (intranet, opac, sip, cronjobs) and is guaranteed to be up to date. To test: 0. Have kohadevbox 1. Enable IssueLog 2. In one terminal run the command "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml" 3. Checkin and return a book using telnet: $ telnet localhost 6001 9300CNterm1|COterm1|CPCPL| 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 4. Keep the telnet connection open and go to http://localhost:8081/cgi-bin/koha/tools/viewlog.pl and check that the *checkout* entry is in the circulation rules 5. 6. Disable IssueLog 7. Move back to the telnet prompt and check out and return a book again 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 8. Go check out the circulation logs and notice a new entry was added when it shouldn't have according to the IssueLog syspref! 9. Apply patch and repeat steps to notice that the syspref is now followed correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Joonas Kylmälä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|NEW |ASSIGNED Severity|normal |major Assignee|koha-b...@lists.koha-commun |joonas.kylm...@iki.fi |ity.org | --- Comment #2 from Joonas Kylmälä --- Moving this to major as the original report (bug 23640) was as well, and the problem reported there should still exists for many of the users with the same severity. Starting to work on a patch now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26877 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- (In reply to Joonas Kylmälä from comment #0) > The SIP2 server L1 cache is still too long, it is per connection rather than > per SIP2 message. The bug 23640 made the cache per connection but we would > need it to be per sip2 message because the SIP2 machines don't close the > connections after every SIP2 message and so it might be many days or weeks > before the new circ rules, sysprefs, etc. take effect. I wondered at the time if clearing the cache per connection was going to be too infrequent... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
