[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Katrin Fischer changed: What|Removed |Added Summary|Ensure no CR occurs in an |Ensure no CR occurs in an |EDIFACT Order message |EDIFACT order message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in|| --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.06 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Katrin Fischer changed: What|Removed |Added Summary|Ensure no CR occurs in an |Ensure no CR occurs in an |Edifact Order message |EDIFACT Order message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Kyle M Hall changed: What|Removed |Added Attachment #119637|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 119765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119765=edit Bug 26989: Safeguard Order Messages from unwanted characters Carriage returns in notes were causing a supplier's parser to truncate Order messages received from Koha. Have removed those and also made a global removal of CR, Line feeds and tabs - the latter two having the possibility of causing errors in the future Signed-off-by: Owen Leonard There was no test plan to follow, but the patch appears to be making sensible changes. If someone wants to provide a thorough test plan I can re-test. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Grr, this is another one where I've spent some time trying to work out how to write a unit test for the change but completely failed.. leaving for another QA person to take a look and comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Owen Leonard changed: What|Removed |Added Attachment #113414|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 119637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119637=edit Bug 26989: Safeguard Order Messages from unwanted characters Carriage returns in notes were causing a supplier's parser to truncate Order messages received from Koha. Have removed those and also made a global removal of CR, Line feeds and tabs - the latter two having the possibility of causing errors in the future Signed-off-by: Owen Leonard There was no test plan to follow, but the patch appears to be making sensible changes. If someone wants to provide a thorough test plan I can re-test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Colin Campbell changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an Edifact Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Colin Campbell changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 113414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113414=edit Patch to remove unwanted CRs etc from ORDER message Substitution should remove any unwanted characters from message in final formatting. In production at a site who helpfully(?) were adding CR after all notes and in some shelfmarks. Trivial code change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
