[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Jonathan Druart changed: What|Removed |Added Text to go in the|This enhancement adds |This enhancement adds release notes|classes to the various |classes to the various |information spans displayed |information spans displayed |in the suggestions table. |in the suggestions table. |This allows for simple |This allows for simple |targeting of CSS rules to |targeting of CSS rules to |highlight or hide |highlight or hide |information that is |information that is |important/irrelevant for|important/irrelevant for |your libraries use. |your library's use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement adds |This enhancement adds release notes|classes to the various |classes to the various |information spans displayed |information spans displayed |in the suggestions table. |in the suggestions table. |This allows for simple |This allows for simple |targeting of css rules to |targeting of CSS rules to |highlight or hide |highlight or hide |information that is |information that is |important/irrelevant for|important/irrelevant for |your libraries use. |your libraries use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds release notes||classes to the various ||information spans displayed ||in the suggestions table. ||This allows for simple ||targeting of css rules to ||highlight or hide ||information that is ||important/irrelevant for ||your libraries use. CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #15 from Andrew Fuerste-Henry --- Enhancement, not backporting to 20.05. Please ask if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.03 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin Somers --- Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Attachment #115214|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 115221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115221&action=edit Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) Move spaces around a bit so the strings don't start with spaces. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Attachment #115213|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 115220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115220&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass changed: What|Removed |Added Attachment #115209|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #10 from Lucas Gass --- (In reply to Katrin Fischer from comment #7) > Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong > now, but not sure if you tested with or without. Sorry about that. I have tested with your QA follow-up. I the reattached them in the correct order. I am still keeping David's SO line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass changed: What|Removed |Added Attachment #114995|0 |1 is obsolete|| --- Comment #9 from Lucas Gass --- Created attachment 115214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115214&action=edit Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #8 from Lucas Gass --- Created attachment 115213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115213&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #7 from Katrin Fischer --- Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong now, but not sure if you tested with or without. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass changed: What|Removed |Added Attachment #114994|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 115209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115209&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart --- Typo suggestion_coprightdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Summary|Add class names in the |Add class names in the |suggestions column in |suggestions column in |Suggestions management |suggestions management -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Attachment #113640|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 114994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114994&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #4 from Katrin Fischer --- Created attachment 114995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114995&action=edit Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 David Nind changed: What|Removed |Added Attachment #113635|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 113640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113640&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #1 from Lucas Gass --- Created attachment 113635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113635&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
