[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #44 from David Cook --- I am tempted to mark this as Failed QA, since I'm pretty sure the session handling doesn't work as intended (I think it's saving the session data in a file rather than in the database), but I haven't actually tested it, so leaving it as is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds release notes||autocomplete suggestions ||for searches in the OPAC ||and staff interface, ||including the advanced ||search forms (when using ||Elasticsearch). || ||This is ||enabled using two new ||system preferences: ||- ||StaffInterfaceAutocompleteE ||lasticsearch ||- ||OPACAutocompleteElasticSear ||ch || ||Note: For this to work ||the search index needs ||rebuilding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #43 from David Nind --- I finally got this to work for me, and it is a really nice feature. Nice work! I've signed off, but these are my suggestions for the wording for the new system preferences - the QA Team will probably comment on this is as well, so you may as well get ahead of them!: 1. IntranetAutocompleteElasticSearch: change system preference name to StaffInterfaceAutocompleteElasticsearch - We are using 'staff interface' now, instead of 'intranet' - not sure what the protocol is for system preference names, but for new system preferences we should probably start using StaffInterface; Elasticsearch doesn't have a capital S (see for example the SearchEngine system preference) 2. Wording for IntranetAutocompleteElasticSearch: . Currently: Don't show/Show looking terms based on a provided text by using an ElasticSearch for Intranet. . Suggested: Don't show/Show search suggestions in the staff interface when using Elasticsearch. 3. Wording for OPACAutocompleteElasticSearch: . Currently: Don't show/Show looking terms based on a provided text by using an ElasticSearch for OPAC. . Change to: Don't show/Show search suggestions in the OPAC when using Elasticsearch. Other testing notes (using koha-testing-docker): . Package command to rebuild the index: koha-elasticsearch -d --rebuild -a -b kohadev . Needed to change .env file as a result of recent commits to koha-testing-docker for Elasticsearch (compared default with custom .env file and added new variables) . As indicated earlier, had to apply patch interactively: 1st excluding CSS patch, then again to include CSS patch . Rebuild CSS as per CSS patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What|Removed |Added Attachment #120109|0 |1 is obsolete|| --- Comment #42 from David Nind --- Created attachment 121558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121558&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What|Removed |Added Attachment #121498|0 |1 is obsolete|| --- Comment #41 from David Nind --- Created attachment 121557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121557&action=edit Bug 27113: (follow-up) Correction with Session I have changed CGI::Session->new() from CGI::Session->load() for use session. This condition - 'CGI::Session->load() or die CGI::Session->errstr();' I am not sure that was good idea to use 'die' in this condition...What do you think? Thanks! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What|Removed |Added Attachment #120806|0 |1 is obsolete|| --- Comment #40 from David Nind --- Created attachment 121556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121556&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What|Removed |Added Attachment #120140|0 |1 is obsolete|| --- Comment #39 from David Nind --- Created attachment 121555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121555&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #38 from David Nind --- (In reply to Ivan Dziuba from comment #33) .. > I checked it and it works :). Do you use Koha 21.05? Thanks. .. Hi Ivan. I'm using master - I tried again and still get the same error for the CSS follow-up patch: .. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css). error: could not build fake ancestor Patch failed at 0001 Bug 27113: (follow-up) Move new CSS to main SCSS files .. I can get the patches to apply if I use interactive, comment out the CSS follow-up patch, then apply again using interactive and then just apply the CSS follow-up patch. I'm assuming the error is because the follow-up CSS is being applied first, but what it is changing doesn't exist yet as it is one of the later patches. I don't know enough about patches to fix this up, but will try and test with what I have. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #37 from David Cook --- Also, it's not clear from the test plan what the user is expected to see/do in terms of the autocomplete... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #36 from David Cook --- (In reply to Tomás Cohen Arazi from comment #34) > I agree with Fridolin: we should think of adding API routes for this. There > should be a privileged route, and an unprivileged route. > You shouldn't worry about sessions and all. Just add the required > permissions to interact with the routes. Yeah, I don't get why session data is being used here. I don't even know if there needs to be 2 routes. Maybe just 1 public/unprivileged API route. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #35 from Blou --- I'm sorry Tomas, this really muddied the picture for Ivan, and I can't help him as I've no idea how he should proceed. Do you mean his api/elasticsearch/elasticsearch.pl should be put under /v1/ and the routes added to swagger, etc... Any wiki to help him there? We had hope this would get into 21.05 initially, but right now it looks like Ivan will recode it for the foreseable future. Which won't happen, I'll give him one more go at it then drop it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #34 from Tomás Cohen Arazi --- I agree with Fridolin: we should think of adding API routes for this. There should be a privileged route, and an unprivileged route. You shouldn't worry about sessions and all. Just add the required permissions to interact with the routes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #33 from Ivan Dziuba --- (In reply to David Nind from comment #32) > Patch no longer applies 8-(... > > Bug 27113 - ElasticSearch: Autocomplete in input search > > 120109 - Bug 27113: (follow-up) Move new CSS to main SCSS files > 120140 - Bug 27113: ElasticSearch: Autocomplete in input search > 120806 - Bug 27113: (follow-up) QA Tests > 121498 - Bug 27113: (follow-up) Correction with Session > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css). > error: could not build fake ancestor > Patch failed at 0001 Bug 27113: (follow-up) Move new CSS to main SCSS files I checked it and it works :). Do you use Koha 21.05? Thanks. Bug 27113 - ElasticSearch: Autocomplete in input search 120109 - Bug 27113: (follow-up) Move new CSS to main SCSS files 120140 - Bug 27113: ElasticSearch: Autocomplete in input search 120806 - Bug 27113: (follow-up) QA Tests 121498 - Bug 27113: (follow-up) Correction with Session Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files Using index info to reconstruct a base tree... A koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css M koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc A koha-tmpl/opac-tmpl/bootstrap/css/opac-elasticsearch/opac-autocomplete.css M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Applying: Bug 27113: ElasticSearch: Autocomplete in input search Applying: Bug 27113: (follow-up) QA Tests Applying: Bug 27113: (follow-up) Correction with Session -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #32 from David Nind --- Patch no longer applies 8-(... Bug 27113 - ElasticSearch: Autocomplete in input search 120109 - Bug 27113: (follow-up) Move new CSS to main SCSS files 120140 - Bug 27113: ElasticSearch: Autocomplete in input search 120806 - Bug 27113: (follow-up) QA Tests 121498 - Bug 27113: (follow-up) Correction with Session Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css). error: could not build fake ancestor Patch failed at 0001 Bug 27113: (follow-up) Move new CSS to main SCSS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #31 from Ivan Dziuba --- Created attachment 121498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121498&action=edit Bug 27113: (follow-up) Correction with Session I have changed CGI::Session->new() from CGI::Session->load() for use session. This condition - 'CGI::Session->load() or die CGI::Session->errstr();' I am not sure that was good idea to use 'die' in this condition...What do you think? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #121497|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #30 from Ivan Dziuba --- Created attachment 121497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121497&action=edit I have changed CGI::Session->new() from CGI::Session->load() for use session. This condition - 'CGI::Session->load() or die CGI::Session->errstr();' I am not sure that was good idea to use 'die' in this condition...What do you think? Thanks! Bug 27113: (follow-up) Correction with Session TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #120141|0 |1 is obsolete|| --- Comment #29 from Ivan Dziuba --- Created attachment 120806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120806&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #28 from Katrin Fischer --- > > You have changed/moved CSS files and it provoke your problem with the layout > (it was not good idea). Katrin Fischer gave you notice of that! > Thanks! I think I am the one who messed up here. Owen is our GUI expert, what he says goes :) I think where I got confused was the file endings. It should have been: RM does generate .css files, but you should commit the .scss changes. (Basically, the fiels that are minified and generated - don't submit them, but the normal ones you need to). Owen, please feel free to correct if I got it not quite right again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #27 from Ivan Dziuba --- Created attachment 120141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120141&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #120029|0 |1 is obsolete|| --- Comment #26 from Ivan Dziuba --- Created attachment 120140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120140&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Owen Leonard changed: What|Removed |Added Attachment #120084|0 |1 is obsolete|| --- Comment #25 from Owen Leonard --- Created attachment 120109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120109&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #24 from Owen Leonard --- (In reply to Owen Leonard from comment #21) > The layout is off My mistake--I recorded that screengrab without having rebuilt the CSS from SCSS. I will modify the test plan to make that part clear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #23 from Owen Leonard --- (In reply to Ivan Dziuba from comment #22) > You have changed/moved CSS files and it provoke your problem with the layout Okay, but the issue with the input field focus is the same without my follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #22 from Ivan Dziuba --- (In reply to Owen Leonard from comment #21) > Created attachment 120088 [details] > GIF showing the buggy behavior > > I have to mark this "Failed QA" again because the QA tool issues were not > all addressed. Please run the QA tool and fix the problems it raises. > > The only other thing I noticed in testing today was that there is a change > in behavior of the search tabs in the staff client. The layout is off, and > the focus doesn't move to the input field like it does on the other tabs. > See the attached screen grab. You have changed/moved CSS files and it provoke your problem with the layout (it was not good idea). Katrin Fischer gave you notice of that! Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #21 from Owen Leonard --- Created attachment 120088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120088&action=edit GIF showing the buggy behavior I have to mark this "Failed QA" again because the QA tool issues were not all addressed. Please run the QA tool and fix the problems it raises. The only other thing I noticed in testing today was that there is a change in behavior of the search tabs in the staff client. The layout is off, and the focus doesn't move to the input field like it does on the other tabs. See the attached screen grab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #20 from Owen Leonard --- Created attachment 120084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120084&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test, follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #120028|0 |1 is obsolete|| --- Comment #19 from Ivan Dziuba --- Created attachment 120029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120029&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #119979|0 |1 is obsolete|| --- Comment #18 from Ivan Dziuba --- Created attachment 120028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120028&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #17 from Katrin Fischer --- (In reply to Blou from comment #15) > Good idea on the button. But I asked Ivan to focus on feature at hand and > everything else can be a new BZ. If he gets it through, it'll be easy to > add on afterward. > > For the .css, you mean merging autocomplete.css into opac.css ? Couldn't > that be a RM thing at the end, if really needed? Otherwise that makes the > rebasing very painful. Ivan is certainly not at ease with that demand. The RM will generate the scss files, you don't need to submit those. But they won't merge CSS changes into the css files. But the risk of conflict is not usually high there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #16 from Owen Leonard --- (In reply to Blou from comment #15) > For the .css, you mean merging autocomplete.css into opac.css ? I mean adding the contents of autocomplete.css into opac.scss. I'd be happy to submit a follow-up for this part, converting the CSS to SCSS, if that would help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #15 from Blou --- Good idea on the button. But I asked Ivan to focus on feature at hand and everything else can be a new BZ. If he gets it through, it'll be easy to add on afterward. For the .css, you mean merging autocomplete.css into opac.css ? Couldn't that be a RM thing at the end, if really needed? Otherwise that makes the rebasing very painful. Ivan is certainly not at ease with that demand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard --- This is very cool, and is working well in the OPAC. I don't think you need to add a separate CSS file. I think it should be incorporated into the main one. It's not a large enough addition to necessitate a separate file. I wonder if we should have an entry at the end of the autocomplete menu every time which the user can click on to submit the string they've entered? For instance, I type "dogs," and the autocomplete shows the first 10 results. A last menu item could say, "See full search results for " or something like that? This patch adds the feature to the OPAC and staff interface but only adds one preference. I think it should be separated into two, one for each interface. It doesn't work for me in the staff interface. There is an error: "Could not compile /kohadevbox/koha/api/elasticsearch/autocomplete.pl: Can't locate Switch.pm in @INC (you may need to install the Switch module)" There are many errors flagged by the QA tool. There are instances of "console.log" in the code which must be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #116293|0 |1 is obsolete|| --- Comment #13 from Ivan Dziuba --- Created attachment 119979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119979&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Bug 27113: ElasticSearch: Autocomplete in input search. Fix bugs. Bug 27113: ElasticSearch: Autocomplete in input search. Use Unicode::Normalize instead Text::Unaccent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #115117|0 |1 is obsolete|| --- Comment #12 from Ivan Dziuba --- Created attachment 116293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116293&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Bug 27113: ElasticSearch: Autocomplete in input search. Fix bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #11 from Fridolin Somers --- (In reply to Ivan Dziuba from comment #9) > Are you sure that OPAC search uses REST API? It's only GET request (with > parametres 'q', 'idx', ...) for file opac-search.pl and return a results for > template *-results.tt. > I don't see here REST API. > > Best regards, No indeed, search is not actually using API. I say your autocomplete feature should use a dedicated API service. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #114945|0 |1 is obsolete|| --- Comment #10 from Ivan Dziuba --- Created attachment 115117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115117&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he starting search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! We need do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). If need do 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 4. For add information in the index we need run script for indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find "AutocompleteElasticSearch". Value must be "Show". 7. Now we have Autocomplete for all search input (advanced search also) Bug 27113: ElasticSearch: Autocomplete in input search v.2.0 Bug 27113: ElasticSearch: Autocomplete on input search. Code change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #9 from Ivan Dziuba --- Are you sure that OPAC search uses REST API? It's only GET request (with parametres 'q', 'idx', ...) for file opac-search.pl and return a results for template *-results.tt. I don't see here REST API. Best regards, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #8 from Fridolin Somers --- I think you can provide a public API for OPAC : https://wiki.koha-community.org/wiki/REST_api_RFCs#Unprivileged_.28public.29_routes datas are the same as searching with OPAC website. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #7 from Ivan Dziuba --- Yes, I see many errors in the files. I will change it. I would like to provide the service for both opac and intranet through REST API. But, I see many preferences for REST API: ('RESTBasicAuth'- 'If enabled, Basic authentication is enabled for the REST API.','YesNo'), ('RESTdefaultPageSize' - 'Default page size for endpoints listing objects','Integer'), ('RESTOAuth2ClientCredentials' - 'If enabled, the OAuth2 client credentials flow is enabled for the REST API.','YesNo'), ('RESTPublicAnonymousRequests' -'If enabled, the API will allow anonymous access to public routes that don\'t require authenticated access.','YesNo'), ('RESTPublicAPI' - 'If enabled, the REST API will expose the /public endpoints.','YesNo') I am not sure that good idea for OPAC because REST API uses Auth. It is possible to disable authentication in the preferences for REST API, but this may have a consequences... Do you have a solution about this? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #6 from Fridolin Somers --- I see : api/elasticsearch/intranet-autocomplete.pl This is strange, its not using the REST API right ? Its more a perl script like : opac/svc/elasticsearch/opac-autocomplete.pl Should be in svc/elasticsearch I'd say. BTW : It is possible to use the REST API ? It whould provide the service for both opac and intranet. Best regards, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #5 from Fridolin Somers --- In koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc + var OL_PREVIEW = _("Preview"); Why this ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #4 from Fridolin Somers --- Whaou I like this :D Just a question : The patch changes some unrelated text in installer/data/mysql/mandatory/sysprefs.sql : -('AnonymousPatron','0',NULL,'Set the identifier (borrowernumber) of the anonymous patron. Used for suggestion and checkout history privacy',''), +('AnonymousPatron','0',NULL,'Set the identifier (borrowernumber) of the anonymous patron. Used for Suggestion and reading history privacy',''), Looks like is it unwanted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #114168|0 |1 is obsolete|| --- Comment #3 from Ivan Dziuba --- Created attachment 114945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114945&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he starting search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! We need do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). If need do 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 4. For add information in the index we need run script for indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find "AutocompleteElasticSearch". Value must be "Show". 7. Now we have Autocomplete for all search input (advanced search also) Bug 27113: ElasticSearch: Autocomplete in input search v.2.0 Update v.2 - API passing tests: prove t - fixed bugs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added CC||ivan.dzi...@inlibro.com --- Comment #2 from Ivan Dziuba --- Created attachment 114169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114169&action=edit Result -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ivan.dzi...@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added CC||eric.be...@inlibro.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #1 from Ivan Dziuba --- Created attachment 114168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114168&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he starting search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! We need do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). If need do 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 4. For add information in the index we need run script for indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find "AutocompleteElasticSearch". Value must be "Show". 7. Now we have Autocomplete for all search input (advanced search also) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/