[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I don't recreate the problem without the patch.
1. Edit biblionumber=1
2. 020 => 0452254264
=> Detail pages (both staff and OPAC) have the "Editions" tab

The sysprefs are passed from C4::Auth
% grep FRBRizeEditions C4/Auth.pm
FRBRizeEditions
   => C4::Context->preference("FRBRizeEditions"),
OPACFRBRizeEditions   =>
C4::Context->preference("OPACFRBRizeEditions"),


Please provide more infos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #119618|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 119806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119806=edit
Bug 27239: Detail templates remove redundant test

Template variables FRBRizeEditions and OPACFRBRizeEditions aren't
assigned with syspref values and are redundant anyway. If syspref
FRBRizeEditions or OPACFRBRizeEditions aren't set XISBN is empty.

Test plan:
1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions
2 - Search for a notice with multiple ISBN in ThingISBN and with some of
these ISBNs in Koha.
Example:
http://www.librarything.com/api/thingISBN/0452254264
In koha imported from LOC ISBN:
0452254264
0198185219
3 - Select one notice
4 - Edition tab is not there.
5 - Apply patch
6 - Redo 2
7 - Edition tab is there.
8 - Unset FRBRizeEditions and OPACFRBRizeEditions
9 - Edition tab isn't there.

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2021-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Owen Leonard  changed:

   What|Removed |Added

 Attachment #114407|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 119618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119618=edit
Bug 27239: Detail templates remove redundant test

Template variables FRBRizeEditions and OPACFRBRizeEditions aren't
assigned with syspref values and are redundant anyway. If syspref
FRBRizeEditions or OPACFRBRizeEditions aren't set XISBN is empty.

Test plan:
1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions
2 - Search for a notice with multiple ISBN in ThingISBN and with some of
these ISBNs in Koha.
Example:
http://www.librarything.com/api/thingISBN/0452254264
In koha imported from LOC ISBN:
0452254264
0198185219
3 - Select one notice
4 - Edition tab is not there.
5 - Apply patch
6 - Redo 2
7 - Edition tab is there.
8 - Unset FRBRizeEditions and OPACFRBRizeEditions
9 - Edition tab isn't there.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2021-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2020-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2020-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

--- Comment #1 from Didier Gautheron  ---
Created attachment 114407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114407=edit
Bug 27239: Detail templates remove redundant tests

Template variables FRBRizeEditions and OPACFRBRizeEditions aren't assigned with
syspref values and are redundant anyway. If syspref FRBRizeEditions or
OPACFRBRizeEditions aren't set XISBN is empty.

Test plan:
1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions
2 - Search for a notice with multiple ISBN in ThingISBN and with some of these
ISBNs in Koha.
Example:
http://www.librarything.com/api/thingISBN/0452254264
In koha imported from LOC ISBN:
0452254264
0198185219
3 - Select one notice
4 - Edition tab is not there.
5 - Apply patch
6 - Redo 2
7 - Edition tab is there.
8 - Unset FRBRizeEditions and OPACFRBRizeEditions
9 - Edition tab isn't there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2020-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Didier Gautheron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27239] FRBRizeEditions is broken

2020-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239

Didier Gautheron  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/