[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2022-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||32348


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348
[Bug 32348] Library public is missing from columns settings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2022-09-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12242

--- Comment #40 from Katrin Fischer  ---
(In reply to David Cook from comment #39)
> (In reply to Katrin Fischer from comment #23)
> > While I am testing this: I am not sure about using "Public" to describe this
> > feature as it only affects the  libraries page in the OPAC right now. I
> > think we should at least add a hint about what it really does to the
> > input/edit form for libraries.
> 
> I think we could leverage this flag to not display library branches in
> dropdown menus as well (for the masthead dropdown and advanced search
> dropdowns specifically)

Not sure if it should be the same flag, but it could be: see bug 12242.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2022-09-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

David Cook  changed:

   What|Removed |Added

 Blocks||31549


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31549
[Bug 31549] Don't show library in OPAC dropdowns if marked as not public
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2022-09-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #39 from David Cook  ---
(In reply to Katrin Fischer from comment #23)
> While I am testing this: I am not sure about using "Public" to describe this
> feature as it only affects the  libraries page in the OPAC right now. I
> think we should at least add a hint about what it really does to the
> input/edit form for libraries.

I think we could leverage this flag to not display library branches in dropdown
menus as well (for the masthead dropdown and advanced search dropdowns
specifically)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Holly  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #38 from Holly  ---
*** Bug 26834 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #37 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #36)
> Created attachment 127629 [details] [review]
> Bug 27360: (follow-up) DBRev 21.06.00.041

Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #36 from Jonathan Druart  ---
Created attachment 127629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127629&action=edit
Bug 27360: (follow-up) DBRev 21.06.00.041

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Jonathan Druart  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #35 from Jonathan Druart  ---
*** Bug 29479 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This patch adds a new
  release notes||field, `Public` to the
   ||definable library
   ||information. When enabled,
   ||the library details will be
   ||displayed in the libraries
   ||page on the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #34 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #33 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #32)
> (In reply to Jonathan Druart from comment #30)
> > We could think it will hide them from Hea, but it won't!
> 
> Does the hint not help enough with that?

I guess it does. But a "non public library" could have their info shared with
Hea.

I just wanted to highlight it, not requested something :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #32 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #30)
> We could think it will hide them from Hea, but it won't!

Does the hint not help enough with that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #31 from Jonathan Druart  ---
Created attachment 127253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127253&action=edit
Bug 27360: Prevent crash if branchcode does not exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
   Keywords||release-notes-needed

--- Comment #30 from Jonathan Druart  ---
We could think it will hide them from Hea, but it won't!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127158|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #29 from Katrin Fischer  ---
Created attachment 127163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127163&action=edit
Bug 27360: Add hint to input field

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127147|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 127162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127162&action=edit
Bug 27360: (follow-up) Mark public as boolean

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127146|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 127161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127161&action=edit
Bug 27360: Use 'public' to filter libraries for opac display

This patch adds the ability to set a library as 'public' or not; this
allows librarians to hide back office library branches from the opac.

Test plan
1/ Set a library as public from `admin > libraries`.
2/ Navigate to the `Libraries` page in the OPAC
3/ Note that only `public` libraries are displayed.

Signed-off-by: Barbara Johnson 
Signed-off-by: Christopher Brannon 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127145|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 127160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127160&action=edit
Bug 27360: DBIC Build

Signed-off-by: Barbara Johnson 
Signed-off-by: Christopher Brannon 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127144|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 127159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127159&action=edit
Bug 27360: Add public field to branches table

Signed-off-by: Barbara Johnson 
Signed-off-by: Christopher Brannon 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #24 from Martin Renvoize  ---
Created attachment 127158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127158&action=edit
Bug 27360: (follow-up) Add hint

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #23 from Katrin Fischer  ---
While I am testing this: I am not sure about using "Public" to describe this
feature as it only affects the  libraries page in the OPAC right now. I think
we should at least add a hint about what it really does to the input/edit form
for libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #22 from Martin Renvoize  ---
Thanks Kyle, all fixed :)

Thanks for the quick testing everyone, glad the email field wasn't a blocker.
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #21 from Martin Renvoize  ---
Created attachment 127147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127147&action=edit
Bug 27360: (follow-up) Mark public as boolean

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127013|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 127146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127146&action=edit
Bug 27360: Use 'public' to filter libraries for opac display

This patch adds the ability to set a library as 'public' or not; this
allows librarians to hide back office library branches from the opac.

Test plan
1/ Set a library as public from `admin > libraries`.
2/ Navigate to the `Libraries` page in the OPAC
3/ Note that only `public` libraries are displayed.

Signed-off-by: Barbara Johnson 
Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127012|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 127145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127145&action=edit
Bug 27360: DBIC Build

Signed-off-by: Barbara Johnson 
Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127011|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 127144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127144&action=edit
Bug 27360: Add public field to branches table

Signed-off-by: Barbara Johnson 
Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Katrin Fischer  ---
Some problems noted by the QA script, can you please fix?

 FAIL   installer/data/mysql/atomicupdate/bug_27360.pl
   OK critic
   FAIL   file permissions
File must have the exec flag
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   OK valid

 FAIL   installer/data/mysql/kohastructure.sql
   OK boolean_vs_tinyint
   OK charset_collate
   OK git manipulation
   FAIL   tinyint_has_boolean_flag
The new column branches.public is using TINYINT(1) as type but
is not defined as boolean in the schema file (Koha/Schema/Result/Branch.pm),
see the SQL12 coding guideline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #16 from Christopher Brannon  ---
As far as I can see, e-mails don't even show.  I checked our production server
on 20.05, and I don't see it in master.  Since it was mentioned in the original
description to be able to allow individual elements, and another comment
mentioning the e-mail specifically, I thought it would be wise to address.  I
like the patch as is.  I think if someone wants to reveal the e-mail address,
it could be addressed in another patch.  I would just state that individual
elements are not going to be addressed in this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #15 from Martin Renvoize  ---
Blimey.. I wasn't expecting that one to move so quickly!

I kept it simple to start with by just adding the proposed 'public' flag.  Do
you think email is the only field that would need to be optionally hidden on
top of this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

--- Comment #14 from Christopher Brannon  ---
(In reply to Martin Renvoize from comment #1)
> I think we should add a 'public' field to the libraries table.. so you can
> hide/show whole libraries in this interface.. then perhaps a checkbox for
> exposing/hiding email address... 

E-mail does not seem to be revealed in general.  Nothing in this patch touches
e-mail addresses as an option to hide OR reveal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #127009|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 127013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127013&action=edit
Bug 27360: Use 'public' to filter libraries for opac display

This patch adds the ability to set a library as 'public' or not; this
allows librarians to hide back office library branches from the opac.

Test plan
1/ Set a library as public from `admin > libraries`.
2/ Navigate to the `Libraries` page in the OPAC
3/ Note that only `public` libraries are displayed.

Signed-off-by: Barbara Johnson 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #127008|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 127012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127012&action=edit
Bug 27360: DBIC Build

Signed-off-by: Barbara Johnson 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #127007|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 127011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127011&action=edit
Bug 27360: Add public field to branches table

Signed-off-by: Barbara Johnson 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #127000|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 127009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127009&action=edit
Bug 27360: Use 'public' to filter libraries for opac display

This patch adds the ability to set a library as 'public' or not; this
allows librarians to hide back office library branches from the opac.

Test plan
1/ Set a library as public from `admin > libraries`.
2/ Navigate to the `Libraries` page in the OPAC
3/ Note that only `public` libraries are displayed.

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #126998|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 127008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127008&action=edit
Bug 27360: DBIC Build

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #126997|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 127007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127007&action=edit
Bug 27360: Add public field to branches table

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Martin Renvoize  changed:

   What|Removed |Added

Summary|Libraries should be able to |Libraries should be able to
   |pick what information   |pick which branches display
   |displays on the 'Libraries' |on the public 'Libraries'
   |pages.  |page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/