[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Arthur Suzuki changed: What|Removed |Added Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in||21.11.21 --- Comment #12 from Arthur Suzuki --- actually minors should also be backported for oldstable : try and backport regardless of severity. Applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Arthur Suzuki --- Minor, won't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass changed: What|Removed |Added Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #10 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #9 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Jacob O'Mara changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.05 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Jacob O'Mara changed: What|Removed |Added CC||jacob.om...@ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass changed: What|Removed |Added Attachment #149068|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 149149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149149=edit Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #6 from Lucas Gass --- Simple fix that works as described, no issues from the QA scripts. Like David mentions, the display is a bit weird. The notes are also lacking a label, "Notes: ", when entering parameters. I think we can address that all in another bug. This gets the notes on the page so we should move it along! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Testing notes (using KTD): 1. Not related to this bug, but on the reports results page, the text for 'Notes:' and 'Total number of results:' aren't aligned with the labels (the text is slightly higher than the labels). Not sure whether there is already a bug for this or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind changed: What|Removed |Added Attachment #149012|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 149068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149068=edit Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #3 from Philip Orr --- Created attachment 149012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149012=edit Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Philip Orr changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Philip Orr changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |philip@lmscloud.de |ity.org | CC||philip@lmscloud.de --- Comment #2 from Philip Orr --- Looks like the template file for the Report parameters page actually already had TT code to display the notes field, it just wasn't getting the TT variable 'notes' from guided_reports.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Katrin Fischer changed: What|Removed |Added Summary|Add description to Reports |Add description to reports |page|page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to Reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #1 from Katrin Fischer --- +1 You might also make notes on how to use the form fields in the notes and it would be helpful to see those earlier. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to Reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Katrin Fischer changed: What|Removed |Added Keywords||Academy Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to Reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27513] Add description to Reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
