[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #35 from Katrin Fischer --- (In reply to Katrin Fischer from comment #34) > We just updated to 20.11.12 and noticed that libyaml-libyaml-perl was > missing. This was marked only for 21.05, but is it possible a backport could > require it? It was cleared up on IRC: http://irc.koha-community.org/koha/2021-12-07#i_2392844 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #34 from Katrin Fischer --- We just updated to 20.11.12 and noticed that libyaml-libyaml-perl was missing. This was marked only for 21.05, but is it possible a backport could require it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Fridolin Somers changed: What|Removed |Added Blocks||23583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 [Bug 23583] Handle OpacHiddenItems with yaml_preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Julian Maurice changed: What|Removed |Added Blocks||28110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28110 [Bug 28110] YAML::XS minimum version should be 0.67, not 0.41 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #33 from Mason James --- (In reply to Joonas Kylmälä from comment #28) > (In reply to Mason James from comment #27) > > Created attachment 116990 [details] [review] [review] > > Bug 27673: remove libyaml-syck-perl, and lower libyaml-libyaml-perl to 0.41 > > (for u16) > > > > 1/ apply patch > > 2/ build koha package > > 3/ confirm that libyaml-libyaml-perl package is installed, and > > libyaml-syck-perl is not > > I think libyaml-syck-perl cannot be removed because bug 22824 is not pushed. update: bug 22824 is now pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #32 from Martin Renvoize --- Great to see this one in.. , I'm going to spend some time on bug 22824 today. It'll be fantastic to get Koha onto one consistent yaml handler :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #31 from Jonathan Druart --- Mason, I pushed your follow-up, but did you see Joonas's comment about it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #30 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #29 from Fridolin Somers --- Enhancement will not be pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #28 from Joonas Kylmälä --- (In reply to Mason James from comment #27) > Created attachment 116990 [details] [review] > Bug 27673: remove libyaml-syck-perl, and lower libyaml-libyaml-perl to 0.41 > (for u16) > > 1/ apply patch > 2/ build koha package > 3/ confirm that libyaml-libyaml-perl package is installed, and > libyaml-syck-perl is not I think libyaml-syck-perl cannot be removed because bug 22824 is not pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Mason James changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Mason James changed: What|Removed |Added Status|Pushed to master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #27 from Mason James --- Created attachment 116990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116990=edit Bug 27673: remove libyaml-syck-perl, and lower libyaml-libyaml-perl to 0.41 (for u16) 1/ apply patch 2/ build koha package 3/ confirm that libyaml-libyaml-perl package is installed, and libyaml-syck-perl is not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Keywords||dependency CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #26 from Jonathan Druart --- Right, thanks Joonas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #25 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #24) > Very strange because https://packages.ubuntu.com/xenial/libyaml-libyaml-perl > lists it as being available on Ubuntu 16.04 / Xenial. Could the > Jenkins/Docker setup have some problem relating to which packages get > installed? I think it is because in our debian control file we don't specify libyaml-libyaml-perl to be installed explicitly, we only install libyaml-perl which has two alternative recommendations (see https://packages.ubuntu.com/xenial/libyaml-perl): - libyaml-syck-perl - libyaml-libyaml-perl and in our control file we explicitly say we want libyaml-syck-perl so the other one doesn't get installed most likely because of that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #24 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #23) > U16 is failing because of this, YAML::XS is missing. > > Don't backport! Very strange because https://packages.ubuntu.com/xenial/libyaml-libyaml-perl lists it as being available on Ubuntu 16.04 / Xenial. Could the Jenkins/Docker setup have some problem relating to which packages get installed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #23 from Jonathan Druart --- U16 is failing because of this, YAML::XS is missing. Don't backport! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > Created attachment 116929 [details] [review] > Bug 27673: Fix t/Context.t > > YAML::XS is not failing on that string, it generates > 'uno - dos' => "asd" > > This new string is not YAML valid because of > "found a tab character that violate intendation" Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #21 from Jonathan Druart --- Created attachment 116929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116929=edit Bug 27673: Fix t/Context.t YAML::XS is not failing on that string, it generates 'uno - dos' => "asd" This new string is not YAML valid because of "found a tab character that violate intendation" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #19 from Jonathan Druart --- (In reply to Jonathan Druart from comment #18) > Created attachment 116835 [details] [review] > Bug 27673: (follow-up) Fix encoding issues - Dump Julian caught that, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #18 from Jonathan Druart --- Created attachment 116835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116835=edit Bug 27673: (follow-up) Fix encoding issues - Dump -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #17 from Joonas Kylmälä --- The last QA follow-up from me had typo in the commit title: "YAML:XS" -> "YAML::XS". Attached fixed version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Joonas Kylmälä changed: What|Removed |Added Attachment #116766|0 |1 is obsolete|| --- Comment #16 from Joonas Kylmälä --- Created attachment 116778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116778=edit Bug 27673: (QA follow-up) Remove unused YAML::XS import The last use of this module was removed in commit "Bug 27673: Fix encoding issues - Dump". Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #15 from Joonas Kylmälä --- The QA script gave some warning about C4::Circulation but it was because the patches modified the POD that was already broken. IMHO, out of scope for this bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@helsinki.fi |y.org | Text to go in the||Replaces uses of YAML release notes||module with more widely ||supported YAML::XS module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #14 from Joonas Kylmälä --- Created attachment 116766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116766=edit Bug 27673: (QA follow-up) Remove unused YAML:XS import The last use of this module was removed in commit "Bug 27673: Fix encoding issues - Dump". Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #13 from Joonas Kylmälä --- Created attachment 116765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116765=edit Bug 27673: Fix encoding issues - Dump Same as Load, but for Dump. Test plan: Edit ES mappings, replace withdrawn's label with "withdrawn ✔️ ❤️ ★" Export the mappings perl misc/search_tools/export_elasticsearch_mappings.pl > admin/searchengine/elasticsearch/mappings.yaml Reset mappings from the UI => Notice that the label is correct Signed-off-by: Kyle M Hall Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #12 from Joonas Kylmälä --- Created attachment 116764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116764=edit Bug 27673: Rename C4::Circulation decode to _decode To prevent conflict with Encode::encode Signed-off-by: Kyle M Hall Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #11 from Joonas Kylmälä --- Created attachment 116763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116763=edit Bug 27673: Fix encoding issues There is a difference between YAML::Load and YAML::XS::Load From YAML::XS pod: "YAML::XS only deals with streams of utf8 octets" Test plan: We are going to test 1 occurence and QA will confirm others don't contain typos. 0. Don't apply the patches 1. Create a new itemtype with code=❤️ 2. Create a new item using this itemtype (to biblionumber=1 will work) 3. Fill OpacHiddenItems with itype: [❤️] 4. Search for "street shuffle" or any terms that will return the biblio Notice that the item is there (there is an error in logs) 5. Apply the patches 6. Repeat 4 and confirm that the item is now hidden Signed-off-by: Kyle M Hall Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Joonas Kylmälä changed: What|Removed |Added Attachment #116737|0 |1 is obsolete|| Attachment #116738|0 |1 is obsolete|| Attachment #116739|0 |1 is obsolete|| Attachment #116740|0 |1 is obsolete|| --- Comment #10 from Joonas Kylmälä --- Created attachment 116762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116762=edit Bug 27673: Replace YAML with YAML::XS From tht YAML pod: """ This module has been released to CPAN as YAML::Old, and soon YAML.pm will be changed to just be a frontend interface module for all the various Perl YAML implementation modules, including YAML::Old. If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time. It requires that you have a C compiler, since it is written in C. """ See also https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35 Test plan: Try some place where YAML::XS is not used and confirm that it works correctly QA note: This patch removes some uses of YAML that were not useful Signed-off-by: Kyle M Hall Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #8 from Kyle M Hall --- Created attachment 116739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116739=edit Bug 27673: Rename C4::Circulation decode to _decode To prevent conflict with Encode::encode Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #9 from Kyle M Hall --- Created attachment 116740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116740=edit Bug 27673: Fix encoding issues - Dump Same as Load, but for Dump. Test plan: Edit ES mappings, replace withdrawn's label with "withdrawn ✔️ ❤️ ★" Export the mappings perl misc/search_tools/export_elasticsearch_mappings.pl > admin/searchengine/elasticsearch/mappings.yaml Reset mappings from the UI => Notice that the label is correct Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #7 from Kyle M Hall --- Created attachment 116738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116738=edit Bug 27673: Fix encoding issues There is a difference between YAML::Load and YAML::XS::Load From YAML::XS pod: "YAML::XS only deals with streams of utf8 octets" Test plan: We are going to test 1 occurence and QA will confirm others don't contain typos. 0. Don't apply the patches 1. Create a new itemtype with code=❤️ 2. Create a new item using this itemtype (to biblionumber=1 will work) 3. Fill OpacHiddenItems with itype: [❤️] 4. Search for "street shuffle" or any terms that will return the biblio Notice that the item is there (there is an error in logs) 5. Apply the patches 6. Repeat 4 and confirm that the item is now hidden Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Kyle M Hall changed: What|Removed |Added Attachment #116675|0 |1 is obsolete|| Attachment #116694|0 |1 is obsolete|| Attachment #116695|0 |1 is obsolete|| Attachment #116696|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 116737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116737=edit Bug 27673: Replace YAML with YAML::XS From tht YAML pod: """ This module has been released to CPAN as YAML::Old, and soon YAML.pm will be changed to just be a frontend interface module for all the various Perl YAML implementation modules, including YAML::Old. If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time. It requires that you have a C compiler, since it is written in C. """ See also https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35 Test plan: Try some place where YAML::XS is not used and confirm that it works correctly QA note: This patch removes some uses of YAML that were not useful Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Blocks||22824 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22824 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 [Bug 22824] Replace YAML::Syck with YAML::XS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #5 from Jonathan Druart --- Created attachment 116696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116696=edit Bug 27673: Fix encoding issues - Dump Same as Load, but for Dump. Test plan: Edit ES mappings, replace withdrawn's label with "withdrawn ✔️ ❤️ ★" Export the mappings perl misc/search_tools/export_elasticsearch_mappings.pl > admin/searchengine/elasticsearch/mappings.yaml Reset mappings from the UI => Notice that the label is correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #4 from Jonathan Druart --- Created attachment 116695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116695=edit Bug 27673: Rename C4::Circulation decode to _decode To prevent conflict with Encode::encode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #3 from Jonathan Druart --- Created attachment 116694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116694=edit Bug 27673: Fix encoding issues There is a difference between YAML::Load and YAML::XS::Load From YAML::XS pod: "YAML::XS only deals with streams of utf8 octets" Test plan: We are going to test 1 occurence and QA will confirm others don't contain typos. 0. Don't apply the patches 1. Create a new itemtype with code=❤️ 2. Create a new item using this itemtype (to biblionumber=1 will work) 3. Fill OpacHiddenItems with itype: [❤️] 4. Search for "street shuffle" or any terms that will return the biblio Notice that the item is there (there is an error in logs) 5. Apply the patches 6. Repeat 4 and confirm that the item is now hidden -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Kyle M Hall changed: What|Removed |Added Attachment #116670|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 116675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116675=edit Bug 27673: Replace YAML with YAML::XS From tht YAML pod: """ This module has been released to CPAN as YAML::Old, and soon YAML.pm will be changed to just be a frontend interface module for all the various Perl YAML implementation modules, including YAML::Old. If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time. It requires that you have a C compiler, since it is written in C. """ See also https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35 Test plan: Try some place where YAML::XS is not used and confirm that it works correctly QA note: This patch removes some uses of YAML that were not useful Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13953, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22824 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #1 from Jonathan Druart --- Created attachment 116670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116670=edit Bug 27673: Replace YAML with YAML::XS From tht YAML pod: """ This module has been released to CPAN as YAML::Old, and soon YAML.pm will be changed to just be a frontend interface module for all the various Perl YAML implementation modules, including YAML::Old. If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time. It requires that you have a C compiler, since it is written in C. """ See also https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35 Test plan: Try some place where YAML::XS is not used and confirm that it works correctly QA note: This patch removes some uses of YAML that were not useful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
