[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin Somers --- Arg C4::Items::PrepareItemrecordDisplay has no unit test :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mag...@libriotech.no --- Comment #11 from Magnus Enger --- Sounds to me like this is "Failed QA" until the questions in Comment 9 have been answered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 --- Comment #10 from Katrin Fischer --- I think this is about the different behaviour of the add item form (cataloguing) vs. the add item form (serials). If I read the test plan right, they should preselect the 0 value in both when you open the forms. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 --- Comment #9 from David Nind --- I'm not that familiar with serials, so could you clarify steps 1-6 in a bit more detail? I've: 1. Added an authorized value for NOT_LOAN: . Authorized value = 0 . Description = Available . Library limitations = All libraries 2. Created a serial, set so that it creates an item record when received. 3. Received an edition: 952$7 has no value selected by default and I set it to Available (using the authorized value setup in step 1). 4. After applying the patch and receiving another edition, the default still has no value selected by default. Am I supposed to manually create an item when I first set up the serial? (Do subsequent editions received inherit the values set up for this first item?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684
--- Comment #8 from Didier Gautheron ---
(In reply to Jonathan Druart from comment #6)
> You need a test and certainly to modify this other place:
>
> Koha/UI/Form/Builder/Item.pm
> 122 $value = $subfield->{defaultvalue};
No, in my understanding it's already done there :
if ( $prefill_with_default_values && ( !defined($value) || $value eq '' ) ) {
$value = $subfield->{defaultvalue} if !$item->{itemnumber}; # apply
defaultvalue only to new items
it's only set $value if it's undefined or an empty string.
Unlike 0 empty string for a VA code is an issue in a lot of place.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #7 from David Nind --- Changed status to failed QA - see comment #6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684
--- Comment #6 from Jonathan Druart ---
You need a test and certainly to modify this other place:
Koha/UI/Form/Builder/Item.pm
122 $value = $subfield->{defaultvalue};
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Didier Gautheron changed: What|Removed |Added Attachment #124169|0 |1 is obsolete|| --- Comment #5 from Didier Gautheron --- Created attachment 127221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127221&action=edit Bug 27684: Serial 0 is valid default value. To test: 1- Create a NOT_LOAN VA: code = 0 lib = available 2- Add a serial with one item 3- Check that in items modification 952$7 is on 'available' 4- Receive this serial. 5- Add item 6- check that not for loan is empty 6- Apply patch 7- redo 4,5 8- check that not for loan is on 'available' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 --- Comment #4 from Didier Gautheron --- (In reply to Martin Renvoize from comment #3) > Does it make sense to leave in the unless.. can you explain? No it doesn't. Regards Didier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Does it make sense to leave in the unless.. can you explain? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Katrin Fischer changed: What|Removed |Added Summary|serial add is confused by |Serial add is confused by |authorized values with a|authorized values with a |code of '0' |code of '0' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 --- Comment #2 from Didier Gautheron --- Created attachment 124169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124169&action=edit Bug 27684: Serial 0 is valid default value. To test: 1- Create a NOT_LOAN VA: code = 0 lib = available 2- Add a serial with one item 3- Check that in items modification 952$7 is on 'available' 4- Receive this serial. 5- Add item 6- check that not for loan is empty 6- Apply patch 7- redo 4,5 8- check that not for loan is on 'available' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Didier Gautheron changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Didier Gautheron changed: What|Removed |Added Depends on||8976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 [Bug 8976] Default sequence of subfields in cataloguing and item editor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27684] serial add is confused by authorized values with a code of '0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Can you provide a patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
