[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Attachment #126323|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 139517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139517=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #12 from Owen Leonard ---
(In reply to Barbara Johnson from comment #7)
> On basket.pl ... is also incorrectly including series data from the 490|a and
> 490|v.
basket.pl and invoice.pl have code to deliberately add the series information
to the title variable:
if ( $line{'title'} ) {
my $volume = $order->{'volume'};
my $seriestitle = $order->{'seriestitle'};
$line{'title'} .= " / $seriestitle" if $seriestitle;
$line{'title'} .= " / $volume" if $volume;
}
parcel.pl appears to be showing 245$b correctly for me in the "Already
received" table, which is the only place this patch changes anything. The
display of title information in the "Pending orders" table is not affected.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #11 from Katrin Fischer --- Owen, could you have a look at Barbara's comments please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #10 from Barbara Johnson --- Created attachment 130901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130901=edit wimpy kid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #9 from Barbara Johnson --- Created attachment 130900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130900=edit acq_ordered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #8 from Barbara Johnson --- Created attachment 130899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130899=edit acq_basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #7 from Barbara Johnson --- Here's what I have found so far in my testing: On basket.pl the title and subtitle display correctly in the 245|a and 245|b. However, it is also incorrectly including series data from the 490|a and 490|v. See the attachment acq_basket.png. The info highlighted in yellow is coming from the 490 tag. On ordered.pl only data from the 245|a is displaying. See the attachment acq_ordered.png. Each title that has been highlighted has a subtitle in the 245|b but it is not displaying. On orderreceive.pl, parcel.pl and invoice.pl the 245|a and 245|b display correctly. Actually parcel.pl is the the place the extra info from the 245|b would be most useful. I attached a screenshot (which_wimpy_kid_is_it.png) showing the display a staff person sees when receiving. In the example all four books are different wimpy kid titles, but without the subtitle displayed it's not readily apparent which is the correct book to receive. Staff then has to start looking at the ISBNS which is more time consuming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #6 from Owen Leonard --- I couldn't (In reply to Barbara Johnson from comment #3) > I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a > "Template process failed" error. I couldn't reproduce this error, but the patch needed to be rebased so a new version is attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Attachment #118969|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 126323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126323=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- Thanks for testing, Barbara. Please feel free to mark something "Failed QA" if anything doesn't work. It's not a setting which is reserved for the QA team. Because this was still "needs signoff" I didn't realize there was a problem with it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #3 from Barbara Johnson --- I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a "Template process failed" error. For all other pages I'm not seeing the additional info from the 245$b, 245$h, 245$n or 245$p subfields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 20532 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #1 from Owen Leonard --- Created attachment 118969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118969=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Barbara Johnson changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20532 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
