[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 George Veranis changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #1 from George Veranis --- Created attachment 122549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122549&action=edit Bug 27943: add support for 7XX equal terms on authorities marc21 display Currently when a MARC21 authority has 7XX field they do not display on authority search result page. 7XX is equal term of 1XX based on LC rules. Applying this patch will enable that feature, which is important for non latin catalogues. Test plan: 1) Add a new authority with 1XX and 7XX fields. 2) Try to search that authority and check if 7XX values are displayed 3) Apply this patch 4) Try to search that authority and you will see that 7XX values are displayed like "1XX = 7XX" Sponsored-by: Keratsini-Drapetsona Municipal Library, Greece Mentored-by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 George Veranis changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |gvera...@dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Attachment #132778|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 157173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157173&action=edit Bug 27943: add support for 7XX equal terms on authorities marc21 display Currently when a MARC21 authority has 7XX field they do not display on authority search result page. 7XX is equal term of 1XX based on LC rules. Applying this patch will enable that feature, which is important for non latin catalogues. Test plan: 1) Add a new authority with 1XX and 7XX fields. 2) Try to search that authority and check if 7XX values are displayed 3) Apply this patch 4) Try to search that authority and you will see that 7XX values are displayed like "1XX = 7XX" Sponsored-by: Keratsini-Drapetsona Municipal Library, Greece Mentored-by: Andreas Roussos Signed-off-by: Frank Hansen Works for me! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Attachment #133712|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 157174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157174&action=edit Bug 27943: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Attachment #154502|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 157175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157175&action=edit Bug 27943: (follow-up) Fix unit test, and use systempreference AuthoritySeparator Instead of hardcoding the separator we take the value from systempreference. Also adjust the unit test to expect the "equalterm" array. Test plan same as before. Signed-off-by: Christian Nelson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #12 from Katrin Fischer --- Created attachment 157176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157176&action=edit Bug 27943: (QA follow-up) Perltidy I have some trouble to get the tidyness test on AuthoritiesMarc.pm passing. There are several outstanding patches touching this file, so I didn't dare to perltidy the whole file just yet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #13 from Katrin Fischer --- Created attachment 157177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157177&action=edit Bug 27943: (QA follow-up) Alternate display in result lists The original display put the equivalent heading right after the main heading with a = as separator. As the 7xx are repeatable that could get croweded easily, also if the terms are longer we might see not so nice breakage. This puts every 7xx on its own line below the main heading with some indentation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Needs documenting --- Comment #15 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Biblibre Sandboxes changed: What|Removed |Added Attachment #146945|0 |1 is obsolete|| --- Comment #8 from Biblibre Sandboxes --- Created attachment 154502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154502&action=edit Bug 27943: (follow-up) Fix unit test, and use systempreference AuthoritySeparator Instead of hardcoding the separator we take the value from systempreference. Also adjust the unit test to expect the "equalterm" array. Test plan same as before. Signed-off-by: Christian Nelson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 George Veranis changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #7 from George Veranis --- Created attachment 146945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146945&action=edit Bug 27943: (follow-up) Fix unit test, and use systempreference AuthoritySeparator Instead of hardcoding the separator we take the value from systempreference. Also adjust the unit test to expect the "equalterm" array. Test plan same as before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Frank Hansen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Frank Hansen changed: What|Removed |Added Attachment #122549|0 |1 is obsolete|| --- Comment #2 from Frank Hansen --- Created attachment 132778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132778&action=edit Bug 27943: add support for 7XX equal terms on authorities marc21 display Currently when a MARC21 authority has 7XX field they do not display on authority search result page. 7XX is equal term of 1XX based on LC rules. Applying this patch will enable that feature, which is important for non latin catalogues. Test plan: 1) Add a new authority with 1XX and 7XX fields. 2) Try to search that authority and check if 7XX values are displayed 3) Apply this patch 4) Try to search that authority and you will see that 7XX values are displayed like "1XX = 7XX" Sponsored-by: Keratsini-Drapetsona Municipal Library, Greece Mentored-by: Andreas Roussos Signed-off-by: Frank Hansen Works for me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Frank Hansen changed: What|Removed |Added CC||frank.han...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #3 from Katrin Fischer --- Created attachment 133712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133712&action=edit Bug 27943: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #4 from Katrin Fischer ---
I have added a follow-up to fix the missing TT filters, but there are 2 issues
that are a bit more than QA can fix:
1) Tests are failing
Changes to any core routines in C4 and Koha need to be accompanied by unit
tests per the coding guidelines, but there is a little more here as the
existing tests fail with the patches applied:
prove t/db_dependent/AuthoritiesMarc.t
t/db_dependent/AuthoritiesMarc.t .. 2/12
# Failed test 'test BuildSummary for MARC21'
# at t/db_dependent/AuthoritiesMarc.t line 158.
# Structures begin differing at:
# $got->{equalterm} = ARRAY(0x563fe77a47f0)
# $expected->{equalterm} = Does not exist
# Failed test 'test BuildSummary for UNIMARC'
# at t/db_dependent/AuthoritiesMarc.t line 202.
# Structures begin differing at:
# $got->{equalterm} = ARRAY(0x563fe36e6b00)
# $expected->{equalterm} = Does not exist
Cannot determine authority type for record: 1710 at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 566.
t/db_dependent/AuthoritiesMarc.t .. 12/12 # Looks like you failed 2 tests of
12.
t/db_dependent/AuthoritiesMarc.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/12 subtests
Test Summary Report
---
t/db_dependent/AuthoritiesMarc.t (Wstat: 512 Tests: 12 Failed: 2)
Failed tests: 6, 8
Non-zero exit status: 2
2) Hardcode delimiter
This hardcodes the delimiter for subheadings to "--", but I believe it should
be using the system preference AuthoritySeparator instead.
Please let us know if you need help in fixing those.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #5 from Katrin Fischer --- My testing record had 2 700 fields, as the field is repeatable. It works nicely for display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #6 from George Veranis --- Hi Katrin, thanks for the review of that bug I will try to do the changes that you proposed . I'm not sure about the unit tests but I will check it to be compatible with that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
